Code suggenstion

Before i make some complain. Gallery is great ;-)

There are some calls in gallery which are not nessarcy.

good example 1.4.3

    
Album classe file:

function getPhotoId($index) {
                $photo = $this->getPhoto($index);
                return $photo->getPhotoId($this->getAlbumDirURL("full"));
}

Albumitem class file:

function getPhotoId($dir) {
                if ($this->image) {
                        return $this->image->getId($dir);
                } else {
                        return "unknown";
                }
}

Image class file:

function getId($dir) {
                return $this->name;
}

As you can see the argument made in album is pointless.

I made a smart mirror system which does a lot in getAlbumDirURL().
Don't say "full" if you only need a number or something like that. I believe that you should only call the methode with a argument when you really intent to show the picture. Else my mirror engine does not what is going on.

In my version I changed some code to "real_full"

All methode like this need to be checked.

I volunteer for this job.

       function getAlbumDirURL($type) {
                global $gallery;

                if (!empty($this->transient->mirrorUrl)) {
                        return $this->transient->mirrorUrl;
                }

                $albumPath = "/".urlencode ($this->fields['name']);

                /* 
                 * Highlights are typically shown for many albums at once,
                 * and it's slow to check each different album just for one
                 * image.  Highlights are also typically pretty small.  So,
                 * if this is for a highlight, don't mirror it.
                 */
                if ($gallery->app->feature["mirror"] &&
                    strcmp($type, "highlight")) {
                        foreach(split("[[:space:]]+", $gallery->app->mirrorSites) as $base_url) {
                                $base_url .= $albumPath;
                                $serial = $base_url . "/serial.{$this->fields['serial_number']}.dat";

                                /* Don't use fs_fopen here since we're opening a url */
                                if ($fd = @fopen($serial, "r")) {
                                        $serialContents = fgets($fd, strlen($this->tsilb)+1);
                                        if (!strcmp($serialContents, $this->tsilb)) {
                                                $this->transient->mirrorUrl = $base_url;
                                                return $this->transient->mirrorUrl;
                                        }
                                }
                        }

                        /* All mirrors are out of date */
                        $this->transient->mirrorUrl =
                                $gallery->app->albumDirURL . $albumPath;
                        return $this->transient->mirrorUrl;
                }

                return $gallery->app->albumDirURL . $albumPath;
        }

If you notice, however, the only $type which actually does anything special is "highlight", and only if mirroring is also enabled.

Passing "full" may not be accurate, since it's completely ignored, but it doesn't do anything different.

h0bbel, i will join IRC this evening/night. Thanks for inviting