URL Rewrite for page number

Hi, I'm not sure it's the right forum, but here goes -

Currently URL Rewrite module does not support page keyword making all pages >1 into links with &g2_page=2.

I'm proposing a simple addition -

1. Add

'page' => array(
'pattern' => '([0-9]*)',
'help' => $this->translate('Page number)'),
'function' => array('rewrite', 'RewriteSimpleHelper', 'parsePage')),

to getRewriteRules() in module.inc for Show Item

2. Add

function parsePage(&$url, &$params, &$entity) {
$url = str_replace('%page%', $params['page'], $url);
unset($params['page']);
return true;
}

function to RewriteSimpleHelper.class

And voila! Go to your site admin and add %page% to the Show Item link, for instance - /%path%/%page%

The rewrite pattern ([0-9]*) ensures that links without page numbers work fine too.

The only downside to this that I have not been able to figure out so far, is that all permalinks for the first page must have a "/" at the end.

Thanks!
Art

Yes, I thought about it and I think it should be done with minimal impact on existing configurations... However I lacked knowledge to do that on my own

- Non albums could be excluded from the logic altogether. is it possible to determine whether the entity is an album or a photo?

I think I'm answering my own question - $entity->entityType will tell whether to perform the translation or not. Note, that this might be a weak point of this function because we will miss or misuse the new types added at a later date

- It is a problem for people who already bookmarked specific albums.

Solution 1: change the rewrite pattern to make the / at the end optional (no idea how at this moment).

Pros:
- existing links work exactly like before

Cons:
- albums cannot have numeric names

Solution 2: leave the way it is

Pros:
- links are consistent - the ones with a '/' at the end are album's first page
- does not matter what albums are called

Cons:
- existing bookmarks are not working anymore

This way or another we're going to have to bite the bullet and screw up some users in order to please the others

Or, make this configurable so users may choose

Thanks!
Art

This %page% token is tricky because it is optional.. I wonder if we could use 2 rewrite rules, like this:

  RewriteCond %{THE_REQUEST} \ /gallery2/v/([^?]+)/([0-9]+)(\?.|\ .)
  RewriteCond %{REQUEST_URI} !/gallery2/main\.php$
  RewriteRule .   /gallery2/main.php?g2_view=core.ShowItem&g2_path=%1&g2_page=%2   [QSA,L]

  RewriteCond %{THE_REQUEST} \ /gallery2/v/([^?]+)(\?.|\ .)
  RewriteCond %{REQUEST_URI} !/gallery2/main\.php$
  RewriteRule .   /gallery2/main.php?g2_view=core.ShowItem&g2_path=%1   [QSA,L]

I'm not sure how to get URL rewrite module to write that, but if it could, would this work?
Note I changed [0-9]* to [0-9]+ in the first rule, so this one only matches when there IS a page number.
Seems like this could work for v/%path%/%page% .. what if someone did some other pattern like %page%::%path% or %path%@page%page% ? How could we parse these patterns into the approprite rules? ie, since %page% is optional, how do we know what to strip out of the pattern for the 2nd rule... for %path%/%page% we stripped the / before %page%

agreed, doesn't seem trivial to keep the non-album links as they were.
and, since we don't use this token by default it seems ok to put it in, and those that want it can use it as is... it's in svn now, give it a try!

Well,
I've managed to make it work. The only problem is that the URL is:
domain.com/gallery2/album/picture_name.jpg/

Spent a few hours trying to move the "page" rule to anothere category but I was unable to make the / dissapear. There are so many flaws from search engine point of view. Lots of things needs to be taken care off before it will be trully search engine friendly.

PLease tell me if anyone find a sollution for making the URL domain.com/gallery2/album/picture_name.html and still keep the "page" option. I've tryed to make 2 rules on core.ShowItem but i was not able.

Thanx.

no need to hack it.
see the message from mindless. it's in svn (our development repository / version) now.

you can upgrade to the latest nightly snapshot to get that feature.
in site admin -> rewrite, you can then use the "%page%" placeholder in the ShowItem rule.

I tried installing the tortoise SVN app as i am on Windows...both the latest and an older version wouldn't install. I don't have unix shell access but I might be able to get my hosting TS to do it. Do I need to upgrade though?

ok...do I have to install ALL the files in nightly snapshot or can I just overwrite my current rewrite module files with the new ones from the snapshot? Also, should I deactivate the module first? Thanks!

ichtyous,
just wanted to answer 'all' ;)

Gallery version = 2.2-svn core 1.1.16
PHP version = 5.1.6 apache2handler
Webserver = Apache/2.2.3 (Win32) DAV/2 PHP/5.1.6 mod_ssl/2.2.3 OpenSSL/0.9.8c
Database = mysql 5.1.11 beta-log,
Theme=PGlightbox,
Gallery-URL=http://lf-photodesign.de

ichthyous----
You've got it hardcoded I think.
Search your template tree for the character sequence:
</a>7</a>
----best wishes, Robert

ichthyous----
It is in my own site's template...

{* Navigator *}{* ----------------------------------------------- *}

{if $theme.totalPages > 1}
    <div class="refresh-right">
      {g->text text="&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;an on-site Ctrl-F5 refreshes 'empty' pictures"}
    </div>
  {g->block type="core.Navigator" navigator=$theme.navigator prefix="&laquo;" suffix="&raquo;" currentPage=$theme.currentPage totalPages=$theme.totalPages}
    {if !empty($theme.jumpRange)}
      <div id="gsPages" class="gbBlock gcBackground1">
        {g->block type="core.Pager"}
      </div>
    {/if}
{else}
  {if !empty($theme.parents)}
    <div class="refresh-right">
      {g->text text="an on-site Ctrl-F5 refreshes 'empty' pictures"}
    </div>
  {/if}
{/if}

...the "core.Pager" calls up the magic...
/modules/core/templates/blocks/local/Pager.tpl

So, it looks like you've got a small edit in the core to correct?

----best wishes, Robert

ichthyous----
I'm curious please upload your...
/modules/core/templates/blocks/Pager.tpl
/modules/core/templates/blocks/local/Pager.tpl
...files to the forum.
----best wishes, Robert

I've got this working for the standard albums, but not for the dynamic albums.

Does this need to be changed in every dynamic album too?

Ideally I'd like to be able to do www.example.com/key/Foo/274 to get page 274 of the Foo keyword list. when I tried to add %page% to the keyword it wouldn't accept the url rewrite specification

If you want to change the keyword album so it supports the same format /key/%keyword%/%page% then in module.inc change the function getRewriteRules() as below:

/**
* @see GalleryModule::getRewriteRules
*/
function getRewriteRules() {
return array(
array('comment' => $this->translate('Keyword Album'),
'match' => array('view' => 'keyalbum.KeywordAlbum'),
'pattern' => 'key/%keyword%/%page%',
'help' => $this->translate('Short URL for Keyword Albums'),
'keywords' => array(
'keyword' => array('pattern' => '([^?/]+)',
'help' => $this->translate('Keyword to use for dynamic album')),
'page' => array('pattern' => '([0-9]*)',
'help' => $this->translate('Page number in a dynamic album')) )
));

@micrafty:
> I've seen in the forums today, this has been a problem since 2005.

what? the short URL part for pages? the first official release with this functionality has been released in 2007 (Gallery 2.2).

> Why not fix the URLs properly and be done with it?

works for me.

please don't cross post. let's continue your case in the thread that you've started in the support forum.

--------------
Documentation: Support / Troubleshooting | Installation, Upgrade, Configuration and Usage

I have same problem.
pavel.pola's describtion is better then my in http://gallery.menalto.com/node/81643#comment-288881

Please, how can I fix it?

Thanks for topic