Gallery 1.6 Alpha3 Bugs

hi Jens,

thanks again for your dedication to and your efforts for G1, it's appreciated!

I finally downloaded the RC1 of 1.6 and played around a bit.

I haven't found any bugs so far, but I noted a change from last alpha to RC1 which I did not like much:

I normally have ecards and photo properties active. when the album is displayed this now shows up as little icons below each thumb nail pic. this results in a cluttered album display, I actually prefer the cleaner look & feel without those icons. I did not find a layout/display option to switch of these icons. only disabling the actual functionality (ecards and photo properties) would hide the icons.

please reconsider, thanks!

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

hi, I played around some more and found the following (v1.6-RC1-svn-b13):

1. subalbum tree is not shown on main page, even though I'm not using matrix theme and have complete tree enabled
2. logic of page title (in div g-pagetitle):
   
   • main page --> gallery title, ok
   • album --> album title, ok
   • subalbum --> subalbum title, ok
   • photo --> gallery title, not ok, should be album or subalbum title (as in 1.5.x)
3. for a new album I get this php notice msg for every pic on the album page:
   Notice: Undefined index: dimensionsAsPopup in /path2gallery/view_album.php on line 689
   after setting the pop up condition in album properties the notice disappears (= dimensionsAsPopup is defined then?)
4. function locateDir in lib/setup.php might return an undefined $dir
5. when adding fotos from a remote web site I get first the following php notice: Notice: Undefined index: userfile in /path2gallery/popups/save_photos.php on line 352 and then a couple of times these warnings with two different missing arguments:
   

   Warning: Missing argument 4 for imcmd() in /path2gallery/lib/imageManipulation.php on line 723
   Warning: Missing argument 5 for imcmd() in /path2gallery/lib/imageManipulation.php on line 723

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

ok, let's try to clarify things a bit:

to 1.): I checked the html source actually being presented to the browser (Firefox 2.0.0.1 and IE6): I found a <div> for the subalbum tree <td> that contains javascript code (some YAHOO widget) but nothing is displayed (both browsers have java and javascript enabled). can you point me to a 1.6 gallery page where you know it works? that way I could at least find out whether it's a client or server based problem. however, if browser settings are essential for the display of the subalbum tree, I'd rather prefer the none script way as it is/was in 1.5.x

to 2.) ok, thanks!

to 3.) I do not quite understand why this should help: it happened with a newly created album, not an existing that would first require some update procedure (the wizard actually did some updates to albums the first time I ran it).

to 4.) the php function locateDir in lib/setup.php is not complete, it requires a $dir = null; as initial statement, otherwise the function might return an undefined $dir in some cases

to 5.) I turned developer mode on in config wizard, which in turn activates php notice and warnings reporting. when adding fotos via URL from another website the above mentioned notices and warnings are listed.

hope this helps!

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

to 1.) ok, checked it out, your site worked fine. my site still showed no subalbum tree. I then installed v1.6-RC1-svn-b19 and - voilà - I got the subalbum tree alright. (???)

the subalbum tree sure looks nice, but I do have a major concern: if I want google to find my subalbums this java script solution is a problem, as google will not follow some script generated links. what's the option for a 'google friendly' subalbum tree?

to 3.) still seeings this in v1.6-RC1-svn-b19 for new albums (pics added via URLs)

thanks!

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

I think in the Photoview it makes sense to show the name of the photo.
But you are right, the (file)name is bad.
I will switch to the caption.

G1.6 has the new description feature, thus long captions are obsolete ;-)

Jens
--
Last Gallery v1 Developer and v1 translation manager.

long captions are possibly obsolete for new albums, but what do I do with my zillions of albums (almost) that already have pics with long captions? I don't feel like rearranging them all...

as a side note: for all your design considerations/decisions please keep in mind that most of the 1.6 users will probably be 1.5.x (or earlier) users that are in need of a feature update (such as user groups, yes!), but do not want a big change/step in functionality or 'look and feel' (otherwise they would move to G2, I think). I think this consideration is even more important for an end of life product, as G1 is now 'advertized' (it's not for me, though...). thanks!

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

Hey Guys! Hats of to Peter and Tim_j ! Peter your bug reports are so cool man! the open source community thanks you man!

I have installed Gallery 1.6 Alpha3 and have a few bugs to report, maybe they have enev been fixed, but at least you know about them,
my gallery is here: http://www.3am.co.za/modules.php?name=gallery and my gallery config can be found here: http://www.3am.co.za/modules/gallery/2007-02-28_gallery_config.txt
embedded in nuke version: 7.8
my php version is: dev-lang/php-5.1.6-r6
my os is: Linux server 2.6.14-gentoo-r5 #2 SMP PREEMPT Wed Dec 21 08:55:42 EST 2005 i686
my apache version is: net-www/apache-2.0.58-r2

the bugs:
1) when i search for something in gallery it changes the url from http://www.3am.co.za/modules.php?name=gallery to http://www.3am.co.za/modules.php and is no longer embedded within nuke, so my stylesheet and theme is lost :
2) when i submit a comment it does noty post the comment, and when the page refresh i end up on the home page :\
those are the only 2 bugs i found :D so far, just a word of thanks! gallery 1 revamp looks amasing! i don't know how you guys do it!

Enjoy the rest of your day and thank you for the help!
Ciao/Riaan
3am.co.za Psytrance

Hi,

i am working on the search page bug. Is not done in b41

I dont understand what you are saying about the users "bug".

Jens
--
Last Gallery v1 Developer and v1 translation manager.

Gallery 1.x _uses_ the phpnuke users when embedded.
When standalone it uses its on users.

Gallery 1.x does no syncronisation. The bridge for G2 does this (as far as i know). It duplicates the phpnuke users.
Jens
--
Last Gallery v1 Developer and v1 translation manager.

hi Tim_j
thanks for the reply, uhm ... you installed postnuke 0.7.6.4 (http://www.postnuke.com/) and not phpnuke 7.9 (http://phpnuke.org/) which is what i am using

i have disabled search now, so that takes care of that, thanks anyway

ciao/riaan
3am.co.za Psytrance
edited*

sooner than expected I got bleeding b45:

here some findings:

1. (function) when using the new crop function for full pics I get the following error: The requested URL /path2gallery/popups/crop_photo.php was not found on this server.
2. (cosmetic) for the new crop function 3:4 screen ratio would be helpful in some cases
3. (cosmetic) for my understanding the defaults for letterbox and 16:9 hdtv should be landscape format (funny look though...)
4. (permission) user2 has a subalbum test2 in album test1 of user1. user2 belongs to group1 that has permission to create subalbums in test1. the drop down menu below the thumb of subalbum test2 in test1 album display contains 'Move'. selecting 'Move' generates a popup window with no valid html code, but just with the text 'You are not allowed to perform this action!' when setting group1 permission for 'Modify items' in album test1, then subalbum test2 can be moved properly. the 'Move' command should probably be disabled in the first case.
5. (cosmetic) layout problem for the 'Move' command: selection combobox for new album is much wider than popup window (drop down arrow not accessible without enlarging window or scrolling. this is probably related to a very long album name, the album names should probably be truncated to a useful length to not disrupt the layout (the problem is illustrated in the file attachment).

that's it for now...

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

@Peter:

Thanks again for this very good testing.

1.) I was not able to reproduce this. How did you manage to get this ?
2.) Done in b47
3.) Well i would have to make a fancy Javascript that changes the right box to reflect 16:9, or change ALL entries to landscape ;)
4.) Wooow ! I would never have been found this. I agree and fixed this in b48.
Question: What about deletion ? user2 owns the subalbum, but its also an item of the parent album?
5.) HMMM. How would you truncate "DonauDampfschiffartskapitänsalbum" ?
a.) "...änsalbum"
b.) "DonauDam..."
c.) "Dona...lbum"

Jens
--
Last Gallery v1 Developer and v1 translation manager.

glad to help, thank you for keeping G1 alive and improving it!

well I was just using the crop feature. the 'Preview' button works and shows a properly cropped pic, but when I press the 'Crop' button I get the above mentioned file not found error. when looking at the code the form generation in crop_photo.php is done with

	echo makeFormIntro('crop_photo.php',
		array('name' => 'crop'),
		array('index' => $index, 'type' => 'popup')
	);

which in turn calls - through some wrappers - makeGalleryUrl which contains the following

	if (stristr($target, 'help') === false) {
		if((isset($args['type']) && $args['type'] == 'popup') ||
			!empty($args['gallery_popup'])) {
			$target = "popups/$target";
		}
	}

in url.php. I can't understand why you can't reproduce, because the submit url in the form tag is always generated as gallerybasedir/popups/crop_photo.php

thanks!

well, when I check my pics I have an awful majority of landscape pics, so yes, why not landscape as default? it's ok with me...

hmmm, tricky logic. but I think as there is a separate permission setting for deleting things in an album a user that is only allowed to create/add something to that album is therefore not allowed to delete that again.

hmmm, got your point. the änsalbum has some appeal, but is probably not very helpful. unique identification of an album is not possible in all cases as soon as some truncating is applied, but IMHO the best way of doing it is your example c).

cheers,
-- Peter
[img]http://www.schumacher.ch/logob.jpg[/img]

Bugs in 1.6-RC1-svn-b54:

1. Albums sub-tree is not displayed for large number of albums
(see http://foto.L7.ru/gallery-1.6/ vs http://foto.L7.ru/gallery/ - the last is 1.5.6).
Checked in IE 6 and FireFox 1.5.

2. At stats-wizard.php and validate_albums.php the order of "return to admin page" and "return to gallery" links
is reverse those at "Filesystem Usage", "find comment spam" and "find orphans" pages.

0. Thank you for your support of 1.x branch! I'll prefer to use it rather than 2.x as long as I can.
If one could help me to create a theme for 1.6 looking like my favorite skin "none" in 1.5.x,
I'll be even more happy!

2. IMHO the a) is better ([return to admin...] [return to gallery]): the last link appeared alone
at the Admin page, so it should remains most right in the upper corner )

1. First of all, I've got
Warning: html_entity_decode() [function.html-entity-decode]: cannot yet handle MBCS! in /home/jens/public_html/gallery-1.6/lib/lang.php on line 763
after switching to Russian (KOI8-R) locale.

> and make albums with the same names?

Do you mean the same URL-s (directory names) or the same Titles (in Russian)?

One more issue when building the albums tree: if we have the album title ending with CRLF (\r\n),
the problem still exists. Here is the dump of album.dat file:
O:5:"album":5:{s:6:"fields";a:69:{s:5:"title";s:11:"Маерхофен\r\n
";[...]. And the page js fails.
Probably we need more escaping in content.php?

And what about KOI8-R? I have no problems with it in 1.6-RC1-b55 (uncommented in lang.php)
under PHP 4.4.4.

I don't know. The fact is that CRLF is there. Probably the result of copy&paste.
Nobody touched album.dat by hands/editors/etc.

Should we start a new thread for features/improvements of 1.6 branch?

Two things are appreciated at first glance for the 1-st page:
- Ability to choose the order of albums (not only "sort by ..."), like action Reorder in a simple album.
- Ability to switch off the animation for sub-albums tree (in my case it breakes the font of g-subalbumTree-box).

About CRLF in album.dat: probably you should add a check in the "Validate albums" action?

Could you please check if "Filesystem usage" statistics works correctly for
"Show usage per album" sorted by "used space". I see no ordering by space,
random figures.

Got it, thank you!
Is it very difficult to add ordering to sub-albums too?

>> 1. First of all, I've got
>> Warning: html_entity_decode() [function.html-entity-
>> decode]: cannot yet handle MBCS!
> 1.) Hmm, according to the PHP-dev list, this was fixed in PHP5, i use 5.2.1 :-|

Please note that KOI8-R is not a multi-byte encoding!
Should work without MBCS support.

Hi,

Dont try the alpha3. Get a later version from my archive, or svn.

Jens
--
Last Gallery v1 Developer and v1 translation manager.

Archive: http://jems.de/archive

i dont understand the locale issue.
Can you explain it a little more?

Jens
--
Last Gallery v1 Developer and v1 translation manager.

I wrote that because I noticed that in the options screen it defaulted to going back to the "wrong" setting, but before I hit POST I went back to see if it still actually acted like the old version and showed the date wrong and it seems not to. I don't know if that's because I don't have all the language packs I did when I had 1.5 But if you want to see what I'm talking about so you can decide for yourself, go into the Locales tab in the setup and look at what it says in the dropdown list. If yours is like mine it will have the en_AUxxx showing instead of whatever you selected and saved the last time. I meant to delete my message, but I guess I hit post without thinking. I installed the latest update version and all seems OK. I've got 6000 photos in about a dozen sub-albums and all is working OK.

I did notice (and tested thoroughly )that if I try to change ownership of a sub-album from outside it (that is, on the page that shows the sub-album as a single thumb and not inside where all the pictures are), no matter which sub-album I select it always goes to change ownership of the first sub-album on the page. So if I have an album called "Birthdays" and in that I have "Mike's 1st Bday", "Mike's 2nd Bday", and "Mike's 3rd Bday" and I select the drop-down under "Mike's 3rd Bday" and select Change Owner, it shows the thumbnail from "Mike's 1st Bday" (the one in the upper left) and the option to select the owner. It also shows the owner as "Nobody". If I go into the sub-album and make the change from Permissions in the the drop-down in the upper right from there it works OK, and it shows me as the owner.

Also, if you have a drop-down open with an item highlighted, decide not to do it and click off of the menu to make it disappear, when you click on any link either into a sub-album or up one level it will pop up the window to make whatever settings you last highlighted.