Community Repository not updating
|
alecmyers
Joined: 2006-08-01
Posts: 613 |
Posted: Tue, 2008-04-29 08:45
|
|
I've uploaded the Favourites module to the community repository, with an uptodate MANIFEST file, but it's not showing up in the list of available plugins (after 15 hours or so) - can someone have a look and see what I've done wrong? Thanks |
|
| Login or register to post comments |
Posts: 4956
The MANIFEST file was not quite up to date so I updated it. See http://gallery-contrib.svn.sourceforge.net/viewvc/gallery-contrib?view=rev&revision=1320
Perhaps you build the MANIFEST at the same time as you checked in the module.inc? An unwritten rule: you need to build the MANIFEST *last* and by itself because the svn keywords change on checkin and modify the file :-/
Posts: 613
Hi Bharat - that's great! Thanks. (I really thought I'd done that, but obviously something was wrong...)
The module shows up fine now - but when I try to install it I get:
Error (ERROR_PLATFORM_FAILURE) : Integrity check failed for 'C:xampphtdocs/modules/favourites/Callbacks.inc'.
* in C:xampphtdocsmodulescoreclassesGalleryRepository.class at line 739 (GalleryCoreApi::error)
* in C:xampphtdocsmodulescoreAdminRepositoryDownload.inc at line 312 (GalleryRepository::verifyPackageIntegrity)
* in ??? at line 0 (AdminRepositoryDownloadController::performDownloadAndInstallation)
...
That file is failing the crc/md5 checksum, by the look of it - would that be another problem with the MANIFEST?
Posts: 19
bharat I am getting a similar problem when I am trying to install my User Info module on 2.2.4
I am still seeing if I can figure out what might be the issue.
Posts: 4956
This is actually the same problem that Charles had. You both had windows-style carriage returns in your files, which causes the MANIFEST generation code to fail. I removed those and updated the MANIFEST again. The next push starts in about 20 minutes, so try again in about an hour.
Posts: 613
Hi Bharat,
Thanks. I'm not sure what implications that has for the future, though: do I need to strip windows cr/lf from every single file before checking in? (other modules, I'm thinking of, particularly.) Does it preclude windows users from editing files in case they introduce cr/lf?
Posts: 4956
Sorry, I should have clarified. The problem happens when you use a Windows based editor on files that are stored on a Unix filesystem. The Windows editor thinks that the files are on a Windows filesystem and will leave the CRs in. Are you mounting a Unix filesystem onto your Windows box? Alternatively, if you use a unix-based version of svn to commit the files, but you're running it against a windows partition (again, cross mounting is usually how this happens) then the svn client doesn't realize that it should strip CRs off. I can help you more if I understand a bit more about your dev env.
Posts: 613
Aha...
My desktop is a windows machine, but I don't have cygwin so to use the various makefiles, I have a headless linux box in the cupboard under the stairs (doesn't everyone) whose volumes mount on my desktop via Samba and to which I copy the modules whenever I need to eg. rebuild the database schema files or compile/include .po files or make the MANIFEST. Access to the linux box is via ssh. And yes - sometimes it's expedient to edit the files on the linux volume from windows. I guess I can live without that, and use vi via ssh instead. I have Subversion clients on both systems, command line on linux and TortoiseSVN integrating with the Windows shell. The whole setup is a bit awkward because it does involve a lot of copying files backwards and forwards, but it more-or-less works for me. If I know what *not* to do in terms of cross-editing then I'm pretty sure I can work out a system!
Posts: 4956
Ah ha, that makes sense. Ok, the simple rule is this -- if the file is going to live on a Unix filesystem configure your editor not to add windows-style line endings (without carriage returns). If it's going to live on a Windows filesystem, configure it to use windows-style line endings (with carriage returns). How that works depends on the editor you're using, but there's always a config option for that.
Posts: 19
My problem with mine is that I had used a file from another project not knowing that it had the windows-style carriage returns in it. My dev. system is Mac OSX(unix based) so there should not be any more problems on my end. Next time I use a file from another project I will make sure to check things.
Thank bharat!!
Posts: 4956
In general, this is not a problem. It's just that in 2.2 the manifest code is sensitive to this particular issue because it does checksums. I believe that the 2.3 manifest handling code does not have this problem. But it's still a good idea to remove those CR's because they serve no purpose.