Gallery 1.5.8

Any chance to revert to the simple link-style reference for "Photo properties" control
in the album viewer? What was the reason to do <select> element for a single choice?

Upgrading to 1.5.8 I've found three issues:

1) $gallery->app->comments_overview_for_all = "no" seems to have no effect. It is described as this:
"Do you want to allow every user who is allowed to view comments (set in permission) to see a complete overview of all comments of an Album? Set this to "no"; if only admin and owners can use this feature."
However any gallery user can get a comments overview, although fortunately they still don't get to see the comments unless the album indicates they have permission to view the comment.

2) The PNG files used by the 'shadows' frame style do not render on my browser, although they worked in the past. My firefox just treats them as fully transparent, i.e. no shadow effect at all. It looks like this actually broke between 1.5.3 and 1.5.4. Reverting to the PNG files of 1.5.3 fixed it. The differences seem to be with nulls and carriage returns, so I wonder if the files simply got corrupted. If they did they may not be alone.

3) It appears that only the album owner or admin can view the photo properties (i.e. EXIF data) now. When admin is logged in, I can see the photo properties icon and click on it. When I log out, the icon for photo properties disappears. For the avoidance of doubt the "Display EXIF data" album property is enabled (and if disabled, the photo properties icon disappears entirely even for admin).

Thanks for looking at this, and all the work on gallery for that matter

Jifl

Thanks for the reply Jens.

1) Sorry I can't really give out admin. But I'm, shall we say, a sufficiently proficient geek, so just tell me what you want to know about and I can find out. I'm just not familiar with where things are in the gallery codebase specifically. The gallery is here: http://gallery.jifvik.org:9999/gallery/albums.php and to prove the point:
# grep overview_for_all config.php
$gallery->app->comments_overview_for_all = "no";

you can see it happening just by clicking on the 2008 album. There is a "View comments" icon at the top-right and with the description of that option, I would not expect that to be there. And clicking on it does indeed allow you to see comments.
Indeed, the only reference to the comments_overview_for_all option in the whole of my gallery sources is in view_comments.php:

// Further hack check
if (!$gallery->user->canViewComments($gallery->album) &&
        (! isset($gallery->app->comments_overview_for_all) || $gallery->app->comments_overview_for_all != "yes"))
{
        printPopupStart(gTranslate('core', "View Comments"));
        showInvalidReqMesg();
        exit;
}

The only time the option is referenced is if the user isn't allowed to view the comments in the first place. So I'm not even sure the described functionality is really implemented.

2) Ah, I hadn't noticed that an intervening release worked - I haven't always upgraded (unless there was a security fix) so missed some. I would speculate it might be something to do with Windows and line-endings and whatever source code control system you use, although not everything fits for that.

3) Sorry, yes, single photo view. The album view does have a drop down to see the properties, and that works. But the icon is not displayed looking at a single image. The relevant snippet in view_photo.php for deciding whether to show the icon is:

    if ($gallery->album->fields["use_exif"] == "yes" &&
                (eregi("jpe?g\$", $photo->image->type)) &&
                (isset($gallery->app->use_exif) || isset($gallery->app->exiftags)) &&
                sizeof($albumItemOptions) == 2)
        {

From some probing, in fact sizeof($albumItemOptions) is 1. This is because getItemActions is called with its $caption argument left at its default of false. The getItemActions in view_album.php by contrast explicitly sets it to true, causing '<< Photo actions >>' or whatever to be returned in addition to 'Photo Properties'. Anyway, the fix is just to compare against 1 in the above test.

Although this exposes a little visual problem when displaying brackets when $gallery->app->useIcons is set to 'both', as you'll see if you look at the icon text when viewing a photo after the fix. view_photo.php calls getIconText and popup_link. In that case getIconText in content.php puts a <br> at the start. Then popup_link gets called with addBrackets implicitly true, and thus puts square brackets around the icon text, which by now includes the <br>, and so doesn't look right at all. I've worked around this in my gallery by setting addBrackets false.

I suspect that view_album.php is in fact not meant to show the photo properties option in a drop-down though. It seems that the test:

    if (sizeof($albumItemOptions) > 2 ||
         (sizeof($albumItemOptions) == 2 && !isset($albumItemOptions['showExif'])))

is meant to specifically prevent the case where the only option is the photo properties. However for me, that above isset returns false, even though it appears to be one of the arrays. I don't know why: my lack of PHP experience shows here.

Anyway, sorry for the length and hope this helps!

Jifl

Your issue is already fixed (b7). You can download the fixes from my archive.

For your upload problem, please enable debug mode, upload a photo via form method and post the output here.
I doubt that its a specific 1.5.8 issue, but who knows.

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

Try another image, or does it happen with all images?
What does the ImageMagick / Netpbm Test from the diagnostic page say? (Setup -> Step 1 -> Diagnostic)

Jens
--
Last Gallery v1 Developer.
Tryout the TEST-Version of Gallery 1.6

I just upgraded from 1.5.7 to 1.5.9-b7 with only one minor problem: the setup wizard fails on choices where the selected index value is "0".

Best regards
/Niels

Could you please give back the KOI8-R charset in lib/lang.php:

diff -rbu gallery-1.5.9-b1/lib/lang.php gallery-1.5.9-b13/lib/lang.php
--- gallery-1.5.9-b1/lib/lang.php 2008-08-07 03:01:08.000000000 +0400
+++ gallery-1.5.9-b13/lib/lang.php 2008-08-28 01:43:18.000000000 +0400
@@ -701,7 +709,7 @@
$supportedCharsetsNewerPHP = array(
'cp866',
'cp1251',
- 'KOI8-R'
+ //'KOI8-R'
);

/**

Or is it a Punishment of Russia? ((

Another strange thing is:

diff -rbu gallery-1.5.9-b1/html_wrap/stats.header.default gallery-1.5.9-b13/html_wrap/stats.header.default
--- gallery-1.5.9-b1/html_wrap/stats.header.default 2008-08-15 02:26:44.000000000 +0400
+++ gallery-1.5.9-b13/html_wrap/stats.header.default 2008-08-23 17:30:58.000000000 +0400
- <td class="head" align="left"><?php echo gTranslate('core', "Gallery statistics") . $stats_title; ?></td>
+ <td class="head" align="left"><?php echo _("Gallery statistics") . $stats_title; ?></td>

(gTranslate() to _()).

Hi Jens,
How can I change font-size in selectbox's?
I try used RU.utf8 and RU.cp1251 locale, looks is very huge ;(

I noticed a bug in 1.5.7 with exif data.
It only displays the first keyword of the "keywords" although there are multiple keywords. Is this bug still present in 1.5.8, does anyone know?