Gallery 1.5.9 Bugs
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
This topic is a for users who have installed Gallery 1.5.9 and have specific bugs to report. Fixed Version are available via SVN or separately from Jens' archive: 1.5.9 fixes, or 1.5.10 pre versions. Once reported bugs have been acknowledged and fixed, the bug will be noted here, and responses will be deleted to keep the thread readable. The known list of bugs in 1.5.9, and their statuses: Fixed: 1.5.10-svn-b1 * Fix: Attempt to delete a subalbum via album commandbox failed. Thanks to Drrrl 1.5.10-svn-b3 1.5.10-svn-b4 1.5.10-svn-b5 * Fix: Voting in thumbsview broken. 1.5.10-svn-b6 Investigation in progress: Rejected: Quote:
Warning: strftime() expects parameter 2 to be long, array given in /home/site/gallery/lib/stats.php on line 394 Answer: Quote:
German translation broken on Debian Answer: Quote:
Have you removed the ability to process certain html tags? I can still post links, but not this image. Answer: Part of the security fixes is a path traversal and xss protection. Thus ../ is not allowed anymore. Please use the full URL. |
|
Drrrl
Joined: 2003-02-02
Posts: 23 |
![]() |
When you are in an album and try to delete is by selecting "Delete this (sub)album", the pop-up windows appears with the following error: Not Found The requested URL /delete_item.php was not found on this server. If you are one level above, however, and you choose "Delete" from a menu under thumbnail, delete_photo.php script is used and everything is fine. Gallery version: 1.5.9 (final), unpacked to a new directory (not upgraded) |
|
jifl
Joined: 2003-07-06
Posts: 18 |
![]() |
Hi Jens, The "Further hack check" at the top of view_comments.php still isn't quite right. It only needs comments_enable==yes for the whole expression in the 'if' to evaluate to false. I think you meant something like this: if (! ($gallery->app->comments_enabled == 'yes') || ! ($gallery->user->isAdmin() || $gallery->user->isOwnerOfAlbum($gallery->album) || ( $gallery->user->canViewComments($gallery->album) && isset($gallery->app->comments_overview_for_all) && $gallery->app->comments_overview_for_all == "yes") )) Other than that looks great so far, thanks! |
|
piploff
Joined: 2008-08-27
Posts: 22 |
![]() |
About Quote:
Warning: strftime() expects parameter 2 to be long, array given in /home/site/gallery/lib/stats.php on line 394 i fixed this with opening "edit caption" for these images and just press save, but if i add new photos, this warring appear again (ver. 1.5.9) |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
It should not be related to the album. Album created | pictured added | Error Jens |
|
rollcage
Joined: 2007-01-08
Posts: 17 |
![]() |
The "true" got left off the following line in albums.php which makes the slideshow link look like "Slideshow" instead of "[Slideshow]". Correct entry should look like: |
|
rollcage
Joined: 2007-01-08
Posts: 17 |
![]() |
I'm not certain this is a bug, but thought I'd get some feedback. I upgraded from 1.5.7 to 1.5.9 and now all my album descriptions which needed to contain <br> to create a newline have massive space between paragraphs. Did something change in the interpretation of the text blocks such that I don't need <br> anymore to establish a newline? If so, I'll have to go back and edit 86 albums worth of descriptions. I'm also curious about the change to the arrows in base.css.default. Why were the arrows changed to use g-borderright/left? I liked the old look and have had to update base.css.default to retain the black lines instead of dotted white lines. Is there a place I can look to see when these kind of changes are made before I deploy? Thank you, |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello Rollcage, thanks for the feedback. It everytime VERY welcome. About the CSS change... well, why not? ;-) Its a small change. I don't understand the "deploy" question. Jens |
|
GerhardSchild
Joined: 2008-09-23
Posts: 1 |
![]() |
Hi Jens, thanks for your feedback. I did some debugging and found some very strange things going on (the only locales I could set from php were de_DE.utf8 and C, although there were iso8859-locales installed). Finally things disappeared. Now I was able to fix it by putting I swear that it didn't work when I started debugging... Thanks anyway, now it is working as supposed. Gerhard |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello Rollcage, now i know what you mean. Yes there were a change related to this. So if you entered newlines, gallery shows now newlines. There is a Changelog file, but if you want an indeep comparisan, i suggest using a diff tool. Jens |
|
rollcage
Joined: 2007-01-08
Posts: 17 |
![]() |
Jens, |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
In this case its done in lib/content.php Gallery 1 has a so called integrityCheck, you could increase the album version number in version.php and write code in classes/Albums.php and classes/AlbumItem.php that modifies your captions. As this is no bug, i suggest you open a separate thread in the forum where we can continue on this. Jens |
|
rollcage
Joined: 2007-01-08
Posts: 17 |
![]() |
Jens, |
|
MrC
Joined: 2004-04-20
Posts: 12 |
![]() |
I'm seeing a "Call to undefined function vd() in .../gallery/classes/Album.php on line 1111". This occurs when trying to rebuild thumbnails, and when $gallery->app->emailOn is "yes". I also see in the ChangeLog: Quote:
I don't find vd() in the source, so am I correct that this call to vd() wasn't replaced back in 2005? Any fix suggestions? I've disabled emailOn as a workaround. |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Oh boy! This bug is there for nearly 3 years ;-) LOL. Just remove line 1111 in that file. Thanks, Jens |
|
MrC
Joined: 2004-04-20
Posts: 12 |
![]() |
Thanks for the response. Yet, is it more complicated that this? User's are getting the "msg should be an array!" error, so some code isn't following the save() function's API. The code looks like: // send email if ($gallery->app->emailOn == 'yes' && $success && $msg) { if (!is_array($msg)) { echo gallery_error(gTranslate('core', "msg should be an array!")); vd($msg); return $success; } |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hi, you found another bug. Manually you can do this: Jens |
|
Drrrl
Joined: 2003-02-02
Posts: 23 |
![]() |
Jens, I'm very sorry but it seems that bug "strftime() expects parameter 2 to be long" still exists in 1.5.9. After my installation of 1.5.9 on 17.09.2008 at around 12:06 I was pretty sure that the problem has gone. But in the same day, in the late evening, one of my users reported the problem to appear with his newly added photos. I ignored it, although the date of file was later than a date of 1.5.9 installation - but both events were so close to each other, that I decided to forget about it, especially after your post you send on 19.09. Meanwhile, on 30.09, I deleted manually installed 1.5.9 and installed Gentoo-package version instead - but it's still 1.5.9. And today I have noticed the problem to reappear, with an image I had created and added to an existing album on 7.10. Moreover, I have created two albums on that day, and added several new photo. In one of the albums, for 29 photos added in the same time, only 2 have this problem. In the second album there are 25 photos and 7 of them have this problem. I realize that it will be very hard to replicate this problem - especially in such situation, where problem appears only for some of the newly added photos. I cannot see any difference between photos with error and without - there were even captured in almost the same time, they come from one camera and were exported to JPGs from Lightroom in one "session" (they come from one event). Best regards, Grzegorz |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Well, its exactly as you say, its very hard to reproduce. I will wait till somebody has a way to reproduce. Sorry, |
|
tomrbrand
Joined: 2008-10-30
Posts: 1 |
![]() |
Hi, just upgraded from 1.5.6 to 1.5.9 and have come across a few issues. I have upgraded from earlier releases several times in the past without issue. My albums are at http://pics.diveclubri.org/ 1) I have 82 albums; memory requirements seem to have increased; album updates are failing Increasing mem allocation to 16MB fixed this issue 2) Call to a non-existant function: To get around this, I used the suggestion here: http://osdir.com/ml/web.wiki.pmwiki.user/2004-06/msg00246.html 3) When uploading images with Gallery Remote, and unchecking the 'resize before upload', the upload fails with the error: The apache logs show: Uploading of images when leaving the 'resize before uploading' checked works without a problem. Gallery URL (optional but very useful): http://tnbrand.getmyip.com:8080/DCRI/gallery Cheers, |
|
gethjones
Joined: 2008-11-16
Posts: 2 |
![]() |
I get the same as tomrbrand with regard to Item looks like an image, but has no dimensions? Please verify it's not a broken image. |
|
aapjes
Joined: 2008-12-08
Posts: 1 |
![]() |
Pressing next when viewing a photo doesn't skip hidden photo's |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello, this is indeed a bug. It will be fixed for Jallery 1.0 I will ask the Gallery team if i am allowed to make an unofficial fix for Gallery 1.5.x Thanks for reporting. Jens |
|
sen8or
Joined: 2008-12-09
Posts: 2 |
![]() |
iam having this same problem, point 3 from tomrbrand. tried leaving "resize" checked, it will no work. Is this a common problem and if so is there an update out for it. I love gallery and have been using it for at least 5 years now, will miss Gallery 1. |
|
mwronkowski
Joined: 2008-12-12
Posts: 3 |
![]() |
Jens, I too am encountering this issue in 1.5.10. Any idea when/if a fix will be produced? -m |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello, i talked to the Gallery team. I forgot to ask if it would be okay to make explizit dedicated fixes/patches and put them on my Jallery site. Jens |
|
sen8or
Joined: 2008-12-09
Posts: 2 |
![]() |
hmmm, okay guess i have to upgrade to gallery 2 as i can no longer upload photos. hopefully there is a patch released |
|
mwronkowski
Joined: 2008-12-12
Posts: 3 |
![]() |
I downgraded from 1.5.10 to 1.5.7, sigh. |
|
OldWoman
Joined: 2008-12-17
Posts: 2 |
![]() |
The issue associated with "Item looks like an image, but has no dimensions? Please verify it's not a broken image." is a PHP one. You have to change the "upload_max_filesize" in your php.ini file to something more than whatever you are uploading. I updated gallery and PHP at the same time and that is why mine broke (php file was overwritten). You may have done the same thing. |
|
mwronkowski
Joined: 2008-12-12
Posts: 3 |
![]() |
Okay. That fixed my problem though something in gallery changed in 1.5.9/10 to now require those variables. |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
This PHP setting is not related to any change in Gallery 1.5.9/10 Jens |
|
rollcage
Joined: 2007-01-08
Posts: 17 |
![]() |
Picture description text containing double quotes (like "Hi there"), displays properly when viewing thumbnails and full sized images, except when in slideshow mode. In slideshow mode, the quotes are removed. |
|
fangji
Joined: 2008-12-07
Posts: 3 |
![]() |
this is indeed a bug. It will be fixed for Jallery 1.0 I will ask the Gallery team if i am allowed to make an unofficial fix for Gallery 1.5.x http://www.drivers-updates.com drivers updates |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello Fangji, _you_ can always make fixes for Gallery 1.5.x. Jens |
|
web gallery
Joined: 2009-01-14
Posts: 6 |
![]() |
>> "If I'm allowed to make an unofficial fix" Man, you can do anything UNOFFICIAL...))) You'd better ask if you can do it OFFICIALLY, because there REALLY are some people who would like to get it.. But well.. At least post it on your blog.. _______________ |
|
JourdonAbraham
![]()
Joined: 2009-06-02
Posts: 1 |
![]() |
Just input enjoy myself everyday with dragonkicks and kicksexpress |
|
MalastiC
Joined: 2007-03-21
Posts: 34 |
![]() |
Good morning and happy new year. I completed the test for Spanish as well: My Webs: http://www.topiberian.com & http://www.solutein.com |
|
Tim_j
![]()
Joined: 2002-08-15
Posts: 6818 |
![]() |
Hello MalastiC, you need to figure out which locale is installed. Jens |
|
MalastiC
Joined: 2007-03-21
Posts: 34 |
![]() |
Tim_j wrote:
Hello MalastiC, Ok. I go to probe now and report you. PD. Sorry for my bad english. My Webs: http://www.topiberian.com & https://www.solutein.com |
|
pemga
Joined: 2010-07-29
Posts: 1 |
![]() |
Quote:
"Item looks like an image, but has no dimensions? Please verify it's not a broken image." is a PHP one. You have to change the "upload_max_filesize" in your php.ini Verified, I had the same problem and after digging the PHP code and debuglogs for some hours I came to the same conclusion |
|