Checkout wont allow $0.00 cost items to be downloaded.

Describe how you've set up your products/options/download-option, what you're doing, how you expect it to function, and how it does in fact function.

The checkoutemail payment option (only) does allow orders with $0 value, and progresses them immediately to "payment cleared" status after the customer details have been entered in that case, so the download can be made immediately. So you should install and use that. You must have at least one payment option that the customer can use for the order status to be changed to "payment cleared" which is a prerequisite for downloading - except when the "Allow download before payment" option is checked.

Two customizations you might want to make (they can both be done by template editing) are firstly to prevent checkoutemail displaying if the order value is non-zero (i.e. you don't want to give people the option to pay by cheque) and further (it only makes sense for a non-zero order value) *not* to ask for customer details if you really don't want to trouble people to enter their details and you don't care to have a record of who's downloading from your site. But those would be custom modifications for you to make, as they're not going to be something everybody wants. I can describe in outline how to do those if you want.

It doesn't really have anything to do with the "Allow download before payment" option. In your situation this option is not useful as it applies to all downloads, including the ones you want people to pay for - as you have seen.

Sure.

Edit the Payment.tpl file, look for the line (currently line 5) that reads

{if $payment.paymentVariables.active}

and change it to

{if $payment.paymentVariables.active && $payment.paymentVariables.orderTotal == 0}

Follow the usual procedure for modifying template files; see the header of the file for details, if you're not sure.

You've saved the change to the master Payment.tpl, instead of editing your (pre-existing) local/Payment.tpl file.

Alternatively, you're using Gallery 2.3 and you haven't flushed the template cache (no-longer happens automatically for template file changes). You can temporarily disable the template cache in site admin -> performance (I think) which you should do while editing templates, then reenable it after.

Oh, my error then.

Try additionally adding these lines to checkoutemail/classes/CheckoutEmailPaymentPlugin.class, at line 58:

	list ($ret, $transaction) = GalleryCheckoutApi::getCurrentTransactionForPayment();
	if ($ret) {
	    return array($ret, null);
	}
	$transactionId = $transaction->getId();
	
	$orderTotal = $transaction->getAmount();

and also change lines 77 ff. to read

	return array(null, array('paymentButtonText' => $paymentButtonText, 
				'paymentText' => $paymentText,
                                'orderTotal' => $orderTotal,
				'active' => $active));

I'll schedule something like that into an update for checkoutemail soon - but that might get you going. (I haven't tested it - let me know if it works.)

EDIT: corrected filename as per post below.