Renaming albums with a period in the new name (tentative patch attached)

TomPouce25

Joined: 2009-01-28
Posts: 13
Posted: Tue, 2009-02-10 18:00

Hi All,

In Gallery, 2.3, I can create albums with a period character in the name, e.g. "test.test". However, it is not possible to edit the basic properties of such an album without changing the name to remove the period characters. I indeed receive an error about the use of "illegal characters". The problem is that it is not possible to rename an album with a period in the new name.

It seems that it is fairly recent that one is allowed to use periods when creating albums:
http://codex.gallery2.org/Gallery2:API_Changes_From_2.2_To_2.3#7.35_.3D.3E_7.36

I guess that this explains the inconsistent behavior.

I have made a tentative patch for this issue. Since I am new to Gallery 2, I would really appreciate if someone could review my mod and tell me if I am doing something stupid.

Thanks!
Tom


Gallery version = 2.3 core 1.3.0
API = Core 7.54, Module 3.9, Theme 2.6, Embed 1.5
PHP version = 5.2.6-2ubuntu4 apache2handler
Webserver = Apache/2.2.9 (Ubuntu) PHP/5.2.6-2ubuntu4 with Suhosin-Patch
Database = mysqli 5.0.67-0ubuntu6, lock.system=flock
Toolkits = LinkItemToolkit, NetPBM, Thumbnail, SquareThumb, jpegtran, Ffmpeg
Acceleration = none, none
Operating system = Linux oahu 2.6.27-11-generic #1 SMP Thu Jan 29 19:24:39 UTC 2009 i686
Default theme = ebony
gettext = enabled
Locale = en_US
Browser = Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.5) Gecko/2008121622 Ubuntu/8.10 (intrepid) Firefox/3.0.5

AttachmentSize
album-rename-period.txt3.96 KB
 
alecmyers

Joined: 2006-08-01
Posts: 4338
Posted: Tue, 2009-02-10 22:18

HI Tom,

You're really asking in the wrong place. This forum is for user-to-user assistance. Contact the developers on IRC on #gallery at irc.freenode.net or email the mailing list at

 
TomPouce25

Joined: 2009-01-28
Posts: 13
Posted: Tue, 2009-02-10 22:28

Thanks Alec, I will move this post.
Tom