[checkout] problem with postage bands

Knilch

Joined: 2009-01-19
Posts: 34
Posted: Thu, 2009-04-23 09:50

Hello everybody!

A few minutes ago I discovered a small glitch in checkout. I want to have framed pictures costing more to be shipped than normal ones, obviously. With the postage bands I have the tool I need to do that and I added the framed version to the more expensive band.

However, when I visit the cart I can select my two destination options (Germany and Europe) and they both show the cheaper shipping fee for the unframed pictures. When I continue with the checkout the correct (higher) fee is added to the order.

So internally it works correctly but when selecting a destination it shows the wrong amount of money. Can that be fixed easily? In my case it would even be sufficient to just remove the price tag in the dropdown menue so the shipping fee is only shown when the whole amount is calculated. A "correct" version would be nice, though :).

Thanks in advance!

 
alecmyers

Joined: 2006-08-01
Posts: 4338
Posted: Thu, 2009-04-23 10:04
Quote:
However, when I visit the cart I can select my two destination options (Germany and Europe) and they both show the cheaper shipping fee for the unframed pictures. When I continue with the checkout the correct (higher) fee is added to the order.

It's not a bug, it's a "feature".

You'll notice the shipping cost is listed as "From <price>" rather than just the price.

The reason it always shows the first option in the band until you go to the second checkout page is because in the first page you can add items to the order of a higher band - and the page can't update the postage rate (that would require some javascript) until completely refreshed. It would therefore be inconsistent and possibly misleading to attempt to show the correct rate at all. Hence the very important "From ...".

You can remove the actual figure entirely with a template edit - SessionContents.tpl line 263. Obey the instructions at the top of the file, carefully, as with all template edits.

Quote:
A "correct" version would be nice, though

You write and debug the javascript, I'll include it in the module. Deal?

 
Knilch

Joined: 2009-01-19
Posts: 34
Posted: Thu, 2009-04-23 10:20

Thanks for your answer.

I see the problem here: it is an error in the translation (which I made... :) ). I translated the "from" into the German "für" which means "for". So the solution is pretty simple: change the "für" into "ab". If you want I can provide the corrected file today in the evening.

JavaScript... oh well, I already told you some times that I'm not really into coding... :-).

 
alecmyers

Joined: 2006-08-01
Posts: 4338
Posted: Thu, 2009-04-23 10:40

The latest de.po actually has it translated as "von". You can see the translation currently included with the module here:
http://gallery-contrib.svn.sourceforge.net/viewvc/gallery-contrib/trunk/gallery2/modules/checkout/po/de.po?view=markup

If you want me to change the one word I can do it now.

 
Knilch

Joined: 2009-01-19
Posts: 34
Posted: Thu, 2009-04-23 22:44

Hello Alec,

no, "von" is also correct. It looks like I only translated that single word here with my version of checkout as I found "von" strange. Now that I know how the postage calculation works, it is grammatically correct.

The word "ab" would be a tad better, though.

 
alecmyers

Joined: 2006-08-01
Posts: 4338
Posted: Thu, 2009-04-23 23:24

OK - I guess we'll leave it be then. Thanks.