Watermark module behaviour

chivitli

Joined: 2009-03-23
Posts: 4

Posted: Sun, 2009-06-07 20:02

Hello everyone

I was testing gallery 3, preparing for Coppermine migration, but after trying out watermarks module, I noticed that it works exactly the opposite than what I would like

On my website gallery is bridged to forum, so many users have access and permissions to add photos. Anyone who registers on the forum is able to upload photos to gallery too. Although in gallery3 users cannot register by themselves (or am I missing something?), I understand that I wont be the only person to bridge it to either Joomla, either some forum system. Especially with development of Jfusion, I think such integrations will become very popular.

Problem is that, in order to protect non-watermaked images, full-size access should be denied to all users, since anyone can register and steal them.

To overcome that problem, there should be possibility to watermark full sized images too. Actually, I think that watermark should be applied only to full sized and optionally to medium sized images, and not to thumbnails. Another problem is watermark scaling: It remains the same size despite the image size, so if watermark is set to some not too small size for medium image, it will cover whole thumbnail. There should be an option for watermark scaling depending on the image size, and also an option to choose which images should it be applied to, thumbs, medium, or full.

One more thing is watermark background. When I apply transparent png watermark to some image using some external software, I get watermarked image, without watermark background. In gallery though, watermark background is visible, and how much depends of the transparency level. I guess this is not wanted behaviour?

So, should I make a feature request for watermak module enhancements, or you think it would be pointless?

RobertR

Joined: 2007-07-05
Posts: 5

Posted: Sun, 2009-06-07 20:57

Many comments have already been posted regarding the watermark module, and personally I join your opinion. Watermarking thumbnails is pointless, and it would be nice to have the option available to watermark resizes and / or full size images.

I understand that the developers look for someone who can code this part, so there is hope

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Tue, 2009-06-09 04:01

http://apps.sourceforge.net/trac/gallery/ticket/271 is the relevant ticket. That should satisfy the "one watermark won't fit all" problem.

Watermarking originals changes the original, causing the watermark to show up in resizes and thumbnails which is undesirable. Preserving an un-watermarked original and using it as the source for image operations is possible, but a pain. If you're going to watermark, why would you not deny full-size access in this case?

We are open to somebody writing the code here. Please create a fork on GitHub and start coding away. I'll be happy to assist.

---
Problems? Check gallery3/var/logs before you post! and file bugs here!
Latest zip: http://github.com/gallery/gallery3/zipball/master
Latest git: http://codex.gallery2.org/Gallery:Using_Git

dimbels

Joined: 2010-08-06
Posts: 6

Posted: Thu, 2010-08-12 15:37

so what ever happened to #271? I see that he uplaoded modified code but it cant be implemented as is it seems?

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Sat, 2010-08-14 18:11

I've moved that ticket to 3.1. If somebody does a polished solution in a fork, we'll pull it in.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

tour93

Joined: 2006-09-15
Posts: 1

Posted: Sun, 2010-12-12 17:48

Hi,
One thing is sure, to not show watermark in thumbnails just remove "thumb" in line 140 of admin_watermarks.php.
before:
foreach (array("thumb", "resize") as $target) {
after:
foreach (array("resize") as $target) {

And of course refresh the watermarking.

chivitli Joined: 2009-03-23 Posts: 4	Posted: Sun, 2009-06-07 20:02
	Hello everyone I was testing gallery 3, preparing for Coppermine migration, but after trying out watermarks module, I noticed that it works exactly the opposite than what I would like On my website gallery is bridged to forum, so many users have access and permissions to add photos. Anyone who registers on the forum is able to upload photos to gallery too. Although in gallery3 users cannot register by themselves (or am I missing something?), I understand that I wont be the only person to bridge it to either Joomla, either some forum system. Especially with development of Jfusion, I think such integrations will become very popular. Problem is that, in order to protect non-watermaked images, full-size access should be denied to all users, since anyone can register and steal them. To overcome that problem, there should be possibility to watermark full sized images too. Actually, I think that watermark should be applied only to full sized and optionally to medium sized images, and not to thumbnails. Another problem is watermark scaling: It remains the same size despite the image size, so if watermark is set to some not too small size for medium image, it will cover whole thumbnail. There should be an option for watermark scaling depending on the image size, and also an option to choose which images should it be applied to, thumbs, medium, or full. One more thing is watermark background. When I apply transparent png watermark to some image using some external software, I get watermarked image, without watermark background. In gallery though, watermark background is visible, and how much depends of the transparency level. I guess this is not wanted behaviour? So, should I make a feature request for watermak module enhancements, or you think it would be pointless?
	XUser login Username: * Password: * Create new account Request new password
RobertR Joined: 2007-07-05 Posts: 5	Posted: Sun, 2009-06-07 20:57
	Many comments have already been posted regarding the watermark module, and personally I join your opinion. Watermarking thumbnails is pointless, and it would be nice to have the option available to watermark resizes and / or full size images. I understand that the developers look for someone who can code this part, so there is hope

bharat Joined: 2002-05-21 Posts: 7994	Posted: Tue, 2009-06-09 04:01
	http://apps.sourceforge.net/trac/gallery/ticket/271 is the relevant ticket. That should satisfy the "one watermark won't fit all" problem. Watermarking originals changes the original, causing the watermark to show up in resizes and thumbnails which is undesirable. Preserving an un-watermarked original and using it as the source for image operations is possible, but a pain. If you're going to watermark, why would you not deny full-size access in this case? We are open to somebody writing the code here. Please create a fork on GitHub and start coding away. I'll be happy to assist. --- Problems? Check gallery3/var/logs before you post! and file bugs here! Latest zip: http://github.com/gallery/gallery3/zipball/master Latest git: http://codex.gallery2.org/Gallery:Using_Git

dimbels Joined: 2010-08-06 Posts: 6	Posted: Thu, 2010-08-12 15:37
	so what ever happened to #271? I see that he uplaoded modified code but it cant be implemented as is it seems?

bharat Joined: 2002-05-21 Posts: 7994	Posted: Sat, 2010-08-14 18:11
	I've moved that ticket to 3.1. If somebody does a polished solution in a fork, we'll pull it in. --- Problems? Check gallery3/var/logs bugs/feature req's \| upgrade to the latest code \| use git

tour93 Joined: 2006-09-15 Posts: 1	Posted: Sun, 2010-12-12 17:48
	Hi, One thing is sure, to not show watermark in thumbnails just remove "thumb" in line 140 of admin_watermarks.php. before: foreach (array("thumb", "resize") as $target) { after: foreach (array("resize") as $target) { And of course refresh the watermarking.

Watermark module behaviour

XUser login