FFmpeg mime types for thumbnails

budinsky

Joined: 2008-11-20
Posts: 28

Posted: Sat, 2009-06-20 04:52

How do I remove audio/mpeg from the ffmpeg list?

I want the thumbnail manager to look after all audio but when i enable ffmpeg the thumbnail manager gets shafted, and when i upload an mp3 i get the imfamous broken image and my flash player wont run.

There needs to be an option in ffmpeg so that you can choose which mime types it looks after.
But i am happy to hack the ffmpeg module if someone can point me in the right direction.

suprsidr

Joined: 2005-04-17
Posts: 6138

Posted: Sat, 2009-06-20 11:05

You can assign a custom jpg to represent the thumb of an mp3 in the thumbnail module even if ffmpeg claims it.
You can also add a custom thumb to individual mp3 like album art and such.
And the thumbnail has no bearing on whether or not it plays in the mp3Player.

We only check if mp3 support is available as an encoder for the convert-to-video/x-flv operation - so again it is not involved in the thumbnail operations.
But if you must hack ffmpeg.... FfmpegToolkitHelper.class ~ line 107

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky

Joined: 2008-11-20
Posts: 28

Posted: Sat, 2009-06-20 14:52

Thanks for the fast reply.

I have tried the custom jpg for mp3 in the thumbnail module. But when I upload a new mp3 it still shows the broken image instead and when you click on the image instead of showing the flash player and playing the mp3, it just shows a bigger picture of the broken image with a download link.

Your right, the thumbnail image doesn't matter but the problem only happens with ffmpeg activated.
All the mp3's uploaded while ffmpeg was disabled continue to work fine so the problem is with uploading the mp3 while ffmpeg is loaded. Then when I unload ffmpeg the mp3 I uploaded continues to not work.

What is it that ffmpeg does to break the mp3?

suprsidr

Joined: 2005-04-17
Posts: 6138

Posted: Sat, 2009-06-20 15:20

Quote:

But if you must hack ffmpeg.... FfmpegToolkitHelper.class ~ line 107

ffmpeg has nothing to do with the play of mp3

url to example mp3

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky

Joined: 2008-11-20
Posts: 28

Posted: Sun, 2009-06-21 00:47

I agree that ffmpeg has nothing to do with playing mp3's
But, it does cause mp3's to break on upload

example url's:

ffmpeg deactivated while uploading mp3
http://www.sexystreetcars.com/Sounds/Ferrari-F355.html

ffmpeg activated while uploading mp3
http://www.sexystreetcars.com/Sounds/test.html

note:
file extensions have been removed from the url's, but if you want them just add replace .html with .mp3.html

budinsky

Joined: 2008-11-20
Posts: 28

Posted: Sun, 2009-06-21 04:13

I fixed it!
I edited FfmpegToolkitHelper.class ~215 and removed 'mp3' => 'mp3'
Now ffmpeg doesn't control my mp3's and has stopped screwing up my uploads

This was most definately caused by ffmpeg and removing it's association with mp3's corrected the problem

suprsidr

Joined: 2005-04-17
Posts: 6138

Posted: Sun, 2009-06-21 05:02

Do you happen to have my ffmpeg and transcode modules installed?

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky

Joined: 2008-11-20
Posts: 28

Posted: Sun, 2009-06-21 11:18

In desperation I tried everything to fix this issue.
I did install transcode but it's no longer activated.
Would uninstalling it made a difference?

suprsidr

Joined: 2005-04-17
Posts: 6138

Posted: Sun, 2009-06-21 11:40

It is my addition of mp3 as a transcodable mimetype which causes this issue.
We had future plans for transcode to be able to convert different audio types to mp3, but I'm no longer interested in doing so.
This issue does not exist with the distributed ffmpeg package, only with my special transcode enabled ffmpeg.
Although I still cannot reproduce your issue(my working version may be a little more advanced then my distributed version).
I'm guessing its related to transcode on upload or something.

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky Joined: 2008-11-20 Posts: 28	Posted: Sat, 2009-06-20 04:52
	How do I remove audio/mpeg from the ffmpeg list? I want the thumbnail manager to look after all audio but when i enable ffmpeg the thumbnail manager gets shafted, and when i upload an mp3 i get the imfamous broken image and my flash player wont run. There needs to be an option in ffmpeg so that you can choose which mime types it looks after. But i am happy to hack the ffmpeg module if someone can point me in the right direction.
	XUser login Username: * Password: * Create new account Request new password
suprsidr Joined: 2005-04-17 Posts: 6138	Posted: Sat, 2009-06-20 11:05
	You can assign a custom jpg to represent the thumb of an mp3 in the thumbnail module even if ffmpeg claims it. You can also add a custom thumb to individual mp3 like album art and such. And the thumbnail has no bearing on whether or not it plays in the mp3Player. We only check if mp3 support is available as an encoder for the convert-to-video/x-flv operation - so again it is not involved in the thumbnail operations. But if you must hack ffmpeg.... FfmpegToolkitHelper.class ~ line 107 -s FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky Joined: 2008-11-20 Posts: 28	Posted: Sat, 2009-06-20 14:52
	Thanks for the fast reply. I have tried the custom jpg for mp3 in the thumbnail module. But when I upload a new mp3 it still shows the broken image instead and when you click on the image instead of showing the flash player and playing the mp3, it just shows a bigger picture of the broken image with a download link. Your right, the thumbnail image doesn't matter but the problem only happens with ffmpeg activated. All the mp3's uploaded while ffmpeg was disabled continue to work fine so the problem is with uploading the mp3 while ffmpeg is loaded. Then when I unload ffmpeg the mp3 I uploaded continues to not work. What is it that ffmpeg does to break the mp3?

suprsidr Joined: 2005-04-17 Posts: 6138	Posted: Sat, 2009-06-20 15:20
	Quote: But if you must hack ffmpeg.... FfmpegToolkitHelper.class ~ line 107 ffmpeg has nothing to do with the play of mp3 url to example mp3 -s FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky Joined: 2008-11-20 Posts: 28	Posted: Sun, 2009-06-21 00:47
	I agree that ffmpeg has nothing to do with playing mp3's But, it does cause mp3's to break on upload example url's: ffmpeg deactivated while uploading mp3 http://www.sexystreetcars.com/Sounds/Ferrari-F355.html ffmpeg activated while uploading mp3 http://www.sexystreetcars.com/Sounds/test.html note: file extensions have been removed from the url's, but if you want them just add replace .html with .mp3.html

budinsky Joined: 2008-11-20 Posts: 28	Posted: Sun, 2009-06-21 04:13
	I fixed it! I edited FfmpegToolkitHelper.class ~215 and removed 'mp3' => 'mp3' Now ffmpeg doesn't control my mp3's and has stopped screwing up my uploads This was most definately caused by ffmpeg and removing it's association with mp3's corrected the problem

suprsidr Joined: 2005-04-17 Posts: 6138	Posted: Sun, 2009-06-21 05:02
	Do you happen to have my ffmpeg and transcode modules installed? -s FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

budinsky Joined: 2008-11-20 Posts: 28	Posted: Sun, 2009-06-21 11:18
	In desperation I tried everything to fix this issue. I did install transcode but it's no longer activated. Would uninstalling it made a difference?

suprsidr Joined: 2005-04-17 Posts: 6138	Posted: Sun, 2009-06-21 11:40
	It is my addition of mp3 as a transcodable mimetype which causes this issue. We had future plans for transcode to be able to convert different audio types to mp3, but I'm no longer interested in doing so. This issue does not exist with the distributed ffmpeg package, only with my special transcode enabled ffmpeg. Although I still cannot reproduce your issue(my working version may be a little more advanced then my distributed version). I'm guessing its related to transcode on upload or something. -s FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

FFmpeg mime types for thumbnails

XUser login