Search module: duplicated fields

Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 601
Posted: Sun, 2009-09-27 18:55

Search form is placed in the header. This is nice...
But why do we have separate form inside the grid area?
What is the reason not to reuse header area?

Yes, I know, google show it even when search toolbox in the browser area is used, but it is different story...
Any other reasons?

Login or register to post comments
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 11023
Posted: Mon, 2009-09-28 21:29

Can you show me what you're seeing? I'm only seeing the form and fields on the page once.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 601
Posted: Mon, 2009-09-28 22:09

See attached SS.
I am shooting for test2 result

AttachmentSize
test2.png7.73 KB
test1.png11.16 KB
Login or register to post comments
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 11023
Posted: Mon, 2009-09-28 22:33

I see what you're saying now. Well you can override that behavior by copying modules/search/views/search.html.php into your theme's views directory and modifying it. :)

I'll ask the UI guys to see if this was intentional or what the logic is behind it.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 601
Posted: Tue, 2009-09-29 00:08

Thanks
I have made some customization to it in my theme, but was wondering if there is a reason

Login or register to post comments
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 11023
Posted: Tue, 2009-09-29 16:30

Got some feedback:
There's no reason. They don't see a major problem with having both forms on the search results page. Either one could be easily hidden with some scripting or you can override the behavior of the search results page in your theme. I personally like the option to override because then you can better customize the look and feel of all of Gallery at the theme level.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 601
Posted: Tue, 2009-09-29 16:47

Ok then.
But with one slight difference to consider which would involve more then just CSS: "header" is not prepopulated with last search criteria on reload, while "in-page" search box does.

Login or register to post comments
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 11023
Posted: Tue, 2009-09-29 17:14

Ah, that's probably why thumb said specifically, "wouldn't be too hard to hide or remove the quick search form in the header if another search form is detected."
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 601
Posted: Tue, 2009-09-29 17:21

well, I want to use just CSS for customization. Ok, I'll do just a template thing

Login or register to post comments