serveradd module does not support spaces in filename

thebrandons

Joined: 2008-11-08
Posts: 27

Posted: Tue, 2009-10-20 15:32

To illustrate the problem assume you have a picture named “two word.jpg”. If you import the picture with “Picture Add”, gallery3 renames the server file and link to “two_word.jpg” (Works). However the “serveradd” Module will import the file and retain the name “two word.jpg” on the server. The problem is that Gallery3 displays a blank image and when I hover over it I notice the link refers to “two-word.jpg”. Thus it is not only broken but inconsistent with the primary Gallery3 import method. If understand correctly the “serveradd” Module needs to be modified to change both filename and link to “two_word.jpg” during import.

I imagine most people have thousands of digital pictures assorted into numerous folders on their hard drive. For a new Gallyer3 it would be impractical to create and import these items 1 folder at a time. In addition it is very common to name files with spaces (ie. “California Vacation.jpg”). Therefore I am curious why everybody isn’t using “serveradd” module and running into this issue?

Login or register to post comments

griffinmt

Joined: 2009-09-06
Posts: 126

Posted: Tue, 2009-10-20 17:46

I have about 20,000 jpg photos that were imported via Server Add, in several sections, and only a couple via the picture upload. I think that the reason I never had a problem is that almost all were stored with the filename right out of the camera, which contained no blanks etc.

Martyn T. Griffin

Login or register to post comments

nivekiam

Joined: 2002-12-10
Posts: 9282

Posted: Tue, 2009-10-20 19:00

Try not to post the same issue in multiple places. I thought I had already replied, but I did so here:

http://gallery.menalto.com/node/91914

Quote:

Everything in contrib is listed here (themes and modules)
http://github.com/gallery/gallery3-contrib

Oh wait, something you said just rang a bell with me. Are you using default permissions or have you restricted (removed) the view permissions for the Everybody group?

There's a bug right now with having the Internet Address and the file or directory name not match if you're forcing every request through the file_proxy (only happens if you remove view for Everybody).

http://sourceforge.net/apps/trac/gallery/ticket/812

____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments

thebrandons

Joined: 2008-11-08
Posts: 27

Posted: Tue, 2009-10-20 22:09

I have read all threads related to Bug 812. This is very bad because I have thousands of files with spaces and I do not want "Everyone" to have permission!

I cannot tell from the bug report if a solution exists. How do I get the latest/experimental code if gallery3 was created via "git clone git://github.com/gallery/gallery3.git"? The update documents only talk about downloading zip files.

Ammendments to BUG 812:

-For picture uploads (ie. "two words.jpg") there is inconsistency between serveradd and "Add Photos". On the server "Add Photos" renames picture to "two_words.jpg" and serveradd leaves the space. This inconsistent naming will surely cause future frustrations and confusion.

-Adding pictures with "Add Photos" works with spaces and gallery permission=deny for "Everyone". Thus it is perfect, so serveradd just needs to do the same and rename to "two_words.jpeg".

Login or register to post comments

nivekiam

Joined: 2002-12-10
Posts: 9282

Posted: Tue, 2009-10-20 22:17

If you are using git, you have the latest code.

The bug hasn't been fixed yet. It will (I hope) before RC1 or before final release.

Thanks for coming up with the inconsistency between Server Add and Add Photos. I'll create a ticket for that.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

Login or register to post comments

floridave

Joined: 2003-12-22
Posts: 16315

Posted: Wed, 2009-10-21 03:37

http://sourceforge.net/apps/trac/gallery/ticket/853

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Login or register to post comments

floridave

Joined: 2003-12-22
Posts: 16315

Posted: Thu, 2009-11-05 05:09

Fixed:
http://github.com/gallery/gallery3/commit/baca223e1d5a5d495b41b0232d2528a776bbc49c

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Login or register to post comments

thebrandons Joined: 2008-11-08 Posts: 27	Posted: Tue, 2009-10-20 15:32
	To illustrate the problem assume you have a picture named “two word.jpg”. If you import the picture with “Picture Add”, gallery3 renames the server file and link to “two_word.jpg” (Works). However the “serveradd” Module will import the file and retain the name “two word.jpg” on the server. The problem is that Gallery3 displays a blank image and when I hover over it I notice the link refers to “two-word.jpg”. Thus it is not only broken but inconsistent with the primary Gallery3 import method. If understand correctly the “serveradd” Module needs to be modified to change both filename and link to “two_word.jpg” during import. I imagine most people have thousands of digital pictures assorted into numerous folders on their hard drive. For a new Gallyer3 it would be impractical to create and import these items 1 folder at a time. In addition it is very common to name files with spaces (ie. “California Vacation.jpg”). Therefore I am curious why everybody isn’t using “serveradd” module and running into this issue?
	Login or register to post comments XUser login Username: * Password: * Create new account Request new password
griffinmt Joined: 2009-09-06 Posts: 126	Posted: Tue, 2009-10-20 17:46
	I have about 20,000 jpg photos that were imported via Server Add, in several sections, and only a couple via the picture upload. I think that the reason I never had a problem is that almost all were stored with the filename right out of the camera, which contained no blanks etc. Martyn T. Griffin
	Login or register to post comments
nivekiam Joined: 2002-12-10 Posts: 9282	Posted: Tue, 2009-10-20 19:00
	Try not to post the same issue in multiple places. I thought I had already replied, but I did so here: http://gallery.menalto.com/node/91914 Quote: Everything in contrib is listed here (themes and modules) http://github.com/gallery/gallery3-contrib Oh wait, something you said just rang a bell with me. Are you using default permissions or have you restricted (removed) the view permissions for the Everybody group? There's a bug right now with having the Internet Address and the file or directory name not match if you're forcing every request through the file_proxy (only happens if you remove view for Everybody). http://sourceforge.net/apps/trac/gallery/ticket/812 ____________________________________________ Like Gallery? Like the support? Donate now!!! See G2 live here
	Login or register to post comments
thebrandons Joined: 2008-11-08 Posts: 27	Posted: Tue, 2009-10-20 22:09
	I have read all threads related to Bug 812. This is very bad because I have thousands of files with spaces and I do not want "Everyone" to have permission! I cannot tell from the bug report if a solution exists. How do I get the latest/experimental code if gallery3 was created via "git clone git://github.com/gallery/gallery3.git"? The update documents only talk about downloading zip files. Ammendments to BUG 812: -For picture uploads (ie. "two words.jpg") there is inconsistency between serveradd and "Add Photos". On the server "Add Photos" renames picture to "two_words.jpg" and serveradd leaves the space. This inconsistent naming will surely cause future frustrations and confusion. -Adding pictures with "Add Photos" works with spaces and gallery permission=deny for "Everyone". Thus it is perfect, so serveradd just needs to do the same and rename to "two_words.jpeg".
	Login or register to post comments
nivekiam Joined: 2002-12-10 Posts: 9282	Posted: Tue, 2009-10-20 22:17
	If you are using git, you have the latest code. The bug hasn't been fixed yet. It will (I hope) before RC1 or before final release. Thanks for coming up with the inconsistency between Server Add and Add Photos. I'll create a ticket for that. ____________________________________________ Like Gallery? Like the support? Donate now!!! See G2 live here
	Login or register to post comments
floridave Joined: 2003-12-22 Posts: 16315	Posted: Wed, 2009-10-21 03:37
	http://sourceforge.net/apps/trac/gallery/ticket/853 Dave _____________________________________________ Blog & G2 \|\| floridave - Gallery Team
	Login or register to post comments
floridave Joined: 2003-12-22 Posts: 16315	Posted: Thu, 2009-11-05 05:09
	Fixed: http://github.com/gallery/gallery3/commit/baca223e1d5a5d495b41b0232d2528a776bbc49c Dave _____________________________________________ Blog & G2 \|\| floridave - Gallery Team
	Login or register to post comments

serveradd module does not support spaces in filename

XUser login