Kohana 2.4 is coming! Get your code into gallery3-contrib on github!

bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Thu, 2009-11-26 19:40

Just a heads up that I'm moving us from Kohana 2.3 to Kohana 2.4 which has substantial changes to APIs. I'm fixing up all of the core code in my branch, and I'll cut the official code over soon. I will also fix up any code that is in the gallery3-contrib repo to match the new standards to make it easier on the developer community. If you get your modules and themes into the gallery3-contrib repo now, I'll fix it up for you and save you some hassle. :-)

No ETA yet. Based on the amount of changes, I'd say it'll take me a week or so.

A very terse list of the changes is here. More info to come:
http://docs.google.com/View?docID=0AZqVUZgKJhwmZGZxanI3NThfMmtkMzVoY2Y4&revision=_latest
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
tieguy

Joined: 2007-01-30
Posts: 32
Posted: Fri, 2009-11-27 03:41

Is the idea to release beta4 after this change?

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Sat, 2009-11-28 06:03

Ok, there is no themes folder in gallery3-contrib

a) should I create one and put theme in there
b) should I create my own git like Joe's?

From instruction above I would think I need to go with option a)
I guess I would need to follow last section from http://codex.gallery2.org/Gallery:Using_Git
Please advise

<:( I hate DOS days...

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Sun, 2009-11-29 07:58

@tieguy: We're torn between putting out B4 or RC1. Right now we're still aiming at RC1, but it's taking so long that we're thinking that Beta 4 for the holidays is a good idea.

@Serge D: There is a themes folder in gallery3-contrib, see: http://github.com/gallery/gallery3-contrib -- if you're having trouble getting to it let me know and I'll do my best to help.

You should create your own git fork. There are docs for it here:
http://help.github.com/forking/

With your own fork, you can commit changes to it early and often, and then at regular intervals we'll pull all your changes into the gallery3-contrib repository. If you mostly make changes only to your theme then we'll just pull all your changes in. If you're making changes to a lot of stuff, we'll try to make sure that what you're doing isn't going to cause problems (mainly from a spirit of guiding multiple to keep them from stepping on each other).

Let me know if yuo have problems.

---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Mon, 2009-11-30 05:26

RRRRRRRRR... I cannot comprehend this Git stuff. Neither CMD or GUI is any close to be intuitive. Call me stupid, but this is worse SCS I've ever seen. Why on earth we are using it?... kills any desire to do anything here... will step away from it for today...

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Mon, 2009-11-30 05:35

Give me a copy of your theme in a zip file and I'll check it into gallery3-contrib for you.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Mon, 2009-11-30 06:32

I may not be current with git. About a week old...
Theme is available from Codex - http://codex.gallery2.org/Gallery3:Themes:greydragon

I may have found something interesting : http://code.google.com/p/gitextensions/
More or less decent GUI for Git... will see how it goes

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Mon, 2009-11-30 06:58

Uh my bad, I forgot to push some of my code up to the main repo. I just did it now-- please try again! Sorry!
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Mon, 2009-11-30 07:13

@bharat: Ok, using app above I have pushed my theme into my fork http://github.com/SergeD/gallery3-contrib/
I hope it is how it is suppose to be done.
Please check.

PS. How to sync fork from main branch?

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Mon, 2009-11-30 08:29

Awesome. I've pulled it into the gallery-contrib repo.. thanks!

You can sync the fork from the main by pulling changes from the "origin". It depends on how you've got Git set up, but basically you want to set up the main codebase as a remote repository, and then just pull from it on a regular basis and commit what you've pulled to your local repo. Look for "Pull changes" on the http://code.google.com/p/gitextensions/ site. Let me know if you have problems.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Tue, 2009-12-01 04:05

Ok, found this http://help.github.com/forking/
Not exactly related to gitextensions, but gives an idea of where to look and how it is reflected in the UI. To answer my own question about fork - section is called "Pulling in upstream changes". Still need to check a few things though

 
Glooper

Joined: 2005-09-21
Posts: 225
Posted: Thu, 2009-12-10 06:52

I've done a fair amount of changes to the basket one... but won't be ready to update for a while... but will be happy doing the changes myself when beta4 /rc1 is close to release. The other few modules I have in your fine to update... :)

I noticed that they've taken Forge out of Kohana. Are you sticking with Forge.. or moving on to one of the other Form libraries?

Ben

Benjamin Albert Smith - Photography

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Wed, 2009-12-23 06:12

Heads up: I've done a full pass over the core code and all the contrib modules and themes and ported it all up to Kohana 2.4. Currently all of this code is in my branch, not yet in the main line.

Here's a commit that sums up the changes that happened in the contrib modules:
http://github.com/gallery/gallery3-contrib/commit/1a0dc96e77fa00b4ae39b804155ef3786e425fd4

Unfortunately, the Kohana documentation website has not yet caught up with Kohana 2.4, so the docs on the new APIs are still a little sketchy. I'm going to continue testing all of the code for the next few days before cutting it over to the mainline.

If you'd like to test out the new code, just do:

git checkout -b bharat_dev origin/bharat_dev

You can do that in both the gallery3 and gallery3-contrib repos. When you're done playing with the code, you can do "git checkout master" to return to the main line. Let me know if you find any issues!

---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Fri, 2009-12-25 21:30

Ok, I've checked every link that I can find. I've probably missed some stuff, but I'm guessing that I'm ready to cut us over to Kohana 2.4. If notice anything wrong -- now's the time to tell me!

PS: Merry Christmas!
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7934
Posted: Sat, 2009-12-26 05:06

DONE. We're now using Kohana 2.4 -- yay! See the link in my above post for a summary of the changes that may affect module/theme developers.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git

 
Serge D
Serge D's picture

Joined: 2009-06-11
Posts: 2138
Posted: Tue, 2009-12-29 14:27

Updated to latest git. Works fine for me.

Note: I think it is important to actually increment a version of the gallery core... it is still 21