Module: ModuleUpdates (v12 - 2012.11.17)
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Sun, 2010-06-20 18:17
|
|
ModuleUpdates http://codex.gallery2.org/Gallery3:Modules:moduleupdates INSTALLATION USAGE SUPPORTED VERSIONS
KNOWN ISSUES
CHANGE LOG
|
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Thu, 2011-06-23 14:39
|
|
Image of v8 is attached below. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-06-25 15:10
|
|
I've uploaded a new copy to my GitHub for approval to the Contrib section. v1.2 - 2010.06.23
|
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Sun, 2010-06-27 01:14
|
|
Oh man this is awesome. I love it! A couple of suggestions: 1) If you choose, you could replace the existing "Modules" entry in the Admin menu with your own with this code in your $menu->get("modules")->url = url::site("admin/moduleupdates");
2) You might consider using the Cache API to store data in the database for performance. Look at modules/gallery/controllers/combined.php for an example of getting/putting cache data. --- |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Tue, 2010-06-29 17:57
|
|
Oh sweet, the Cache API stuff will be great. I'll focus on that for a v2 release. That way I can just add an option to check for updates instead of pulling data each time. I'm not sure if I want to get on the level of replacing the entire modules page but I have contemplated adding my code to the modules page itself. Once I get the cache stuff worked out I will start looking into doing that. |
|
|
mamouneyya
Joined: 2009-11-02
Posts: 337 |
Posted: Thu, 2010-07-01 23:32
|
|
Issue: Suggestion: Thanks |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-07-02 12:55
|
|
mamouneyya wrote:
Issue: I'll have to look into the t("string") thing, I'm not exactly sure how that all works yet. Are there any good examples of what I should do for that? |
|
|
mamouneyya
Joined: 2009-11-02
Posts: 337 |
Posted: Fri, 2010-07-02 13:04
|
|
brentil wrote:
I'll have to look into the t("string") thing, I'm not exactly sure how that all works yet. Are there any good examples of what I should do for that? To make any string translatable via Gallery translation system, it must be passed to the translation function so it is being replaced by the translation of the selected language if exists. Take a look at the original module administration view page: t("Gallery Modules")
t("Installed")
t("Name")
t("Version")
t("Description")
... etc
|
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-07-02 13:46
|
|
Ok, gotcha. How do I know what words support being translated, or can I just t("") entire sentences and then it auto translates words in it? ::EDIT:: |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-07-02 14:04
|
|
bharat wrote:
2) You might consider using the Cache API to store data in the database for performance. Look at modules/gallery/controllers/combined.php for an example of getting/putting cache data. Does the Cache system just store my variable + value in temp db location that I can call to see if it exists or not? |
|
|
mamouneyya
Joined: 2009-11-02
Posts: 337 |
Posted: Fri, 2010-07-02 14:11
|
|
brentil wrote:
Ok, gotcha. How do I know what words support being translated, or can I just t("") entire sentences and then it auto translates words in it? Even if the string has no translation yet, it will be added to the translatable strings database so anyone can translate it to his language via Gallery 3 translation interface. |
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Sat, 2010-07-03 04:54
|
|
brentil wrote:
Does the Cache system just store my variable + value in temp db location that I can call to see if it exists or not? Yep. It's pretty easy. Check out http://docs.kohanaphp.com/libraries/cache for docs. --- |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Thu, 2010-07-08 17:48
|
|
bharat wrote:
Yep. It's pretty easy. Check out http://docs.kohanaphp.com/libraries/cache for docs. Ok, I've implemented a working cache system so now it only triggers once every 30 days or when a user manually runs it. However does the cache system natively provide SQL injection protection like from mysql_real_escape_string() or do I need to implement something myself? I tried using mysql_real_escape_string() but it fails I'm guessing because I don't have an active connection on my pages themselves. |
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Fri, 2010-07-09 15:10
|
|
Hm. Can you explain a bit more about the SQL injection? I suspect that the cache system is resilient to SQL injection but if you can give me an example I can verify it. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-07-09 23:11
|
|
bharat wrote:
Hm. Can you explain a bit more about the SQL injection? I suspect that the cache system is resilient to SQL injection but if you can give me an example I can verify it. The MySQL page has some good info on it. In respect to my module and SQL Injection attacks, if someone specifically crafted a module description with an attack string in the name or description when I store it into the cache it could trigger. Also if someone manually manipulated that data from the local system the next time it's read back in it could also be vulnerable. The mysql_real_escape_string command protects from this by safely escaping SQL characters that are not usually caught by html escaping. |
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Sat, 2010-07-10 05:38
|
|
I'm very familiar with SQL injection Under the covers we're using the ORM library to do the Cache updates in the database so you should be fully protected from SQL injection. I'm glad you're looking out for these issues, though! |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Sat, 2010-07-10 17:07
|
|
hehehe sorry, I misunderstood what you meant. :D |
|
|
Serge D
Joined: 2009-06-11
Posts: 2466 |
Posted: Wed, 2010-08-25 18:29
|
|
Is this module alive? I have downloaded the version but it does not show git state |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-08-25 18:39
|
|
Serge D wrote:
Is this module alive? I have downloaded the version but it does not show git state Yup it sure is, I've been working on v2 in my spare time. What exactly is going wrong? How is the output of what you are seeing differing from what I have in the image above? |
|
|
Serge D
Joined: 2009-06-11
Posts: 2466 |
Posted: Wed, 2010-08-25 19:02
|
|
there |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-08-25 19:18
|
|
It shows DNE if it is not located in the GIT (which Akismet & Comments are in the GIT for sure) or if it cannot make an outbound call to the GIT server. Does your server permit outbound HTTP calls? If not that would block it. |
|
|
Serge D
Joined: 2009-06-11
Posts: 2466 |
Posted: Wed, 2010-08-25 19:24
|
|
I could not imagine why not, what would not permit it? .htaccess? |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Thu, 2010-08-26 17:41
|
|
Serge D wrote:
I could not imagine why not, what would not permit it? .htaccess? If your host blocks outbound calls via their firewall. This still allows return data from inbound HTTP but not outbound calls originating from the code. The URLs being called are; http://github.com/gallery/gallery3/raw/master/modules/ + module_name + /module.info |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Thu, 2010-08-26 17:48
|
|
I'm almost done with v2, I'll add in a communication test at the top of the page to see if the system has the ability to make outbound calls to the GIT servers and the web in general. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-08-27 14:02
|
|
woo-hoo, version 2.0 is now up in my GitHub for evaluation to add to the main GitHub! I've added a new screenshot in the 2nd post above.
|
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Sun, 2010-08-29 04:20
|
|
Pulled! Great work, brentil! |
|
|
dmolavi
Joined: 2002-12-05
Posts: 573 |
Posted: Tue, 2010-10-26 17:58
|
|
Please update your module to reflect the new git repo structure: //Check the Gallery3 Community Contributions GitHub
if ($file == null) {
try {
$file = fopen ("http://github.com/gallery/gallery3-contrib/raw/master/modules/".$module_name."/module.info", "r");replace the "$file = fopen..." line with:
-- |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Tue, 2010-10-26 18:12
|
|
Thanks for the information. I had to rebuild my machine so as soon as I get my dev tools back installed I'll get the update in place. |
|
|
crackers
Joined: 2002-10-24
Posts: 67 |
Posted: Sun, 2010-11-07 16:05
|
|
I can't seem to enable this module anymore, says there was an error installing it. It was running fine then I disabled it... now it won't enable again... Any thoughts or is there something I can look at? |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Sun, 2010-11-07 17:10
|
|
crackers wrote:
I can't seem to enable this module anymore, says there was an error installing it. It was running fine then I disabled it... now it won't enable again... Hmmm I've done a lot of install/uninstall tests. The maintenance tab might have some more info if there's an error. Also I haven't installed and tested against the official 3.0 release yet either since I have to figure out how to re-sync my GitHub against the main account. |
|
|
crackers
Joined: 2002-10-24
Posts: 67 |
Posted: Tue, 2010-11-09 12:50
|
|
I don't see anything in the maintenance tab regarding any errors... or that an attempt was made to active a module. I only see a log on a success for activate/deactivate... |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Mon, 2010-11-15 14:54
|
|
crackers wrote:
I don't see anything in the maintenance tab regarding any errors... or that an attempt was made to active a module. I only see a log on a success for activate/deactivate... Cause the issue to happen and then go into your folder structure /gallery/var/logs and download the log for the day you made the error happen. That should hopefully contain error data you can post here. |
|
|
crackers
Joined: 2002-10-24
Posts: 67 |
Posted: Mon, 2010-11-15 15:29
|
|
2010-11-15 07:21:53 -08:00 --- error: exception 'Exception' with message '@todo MODULE_FAILED_TO_UPGRADE' in /var/g3/modules/gallery/helpers/module.php:243 |
|
|
MarkRH
Joined: 2007-05-25
Posts: 241 |
Posted: Mon, 2010-11-15 21:46
|
|
I was going to try this out but I already know it will fail because allow_url_fopen is set to Off at my host. Any thoughts about adding an alternative Curl connection method if fopen fails? I could probably install it and create my own connection routine using Curl or Fsockopen which is what I use to grab website and RSS feeds from other sites. Hmmmm... Thanks, Using Gallery 3.0+(git) - gallery.markheadrick.com |
|
|
Dar2
Joined: 2010-11-17
Posts: 20 |
Posted: Wed, 2010-11-17 13:46
|
|
I'm having the same issue with moduleupdates (same log) as "crackers". I was able to activate before, but when I tried to disable and enable again - got this error: An error occurred while installing the Module Updates module |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-11-17 13:59
|
|
Dar2 wrote:
I'm having the same issue with moduleupdates (same log) as "crackers". I was able to activate before, but when I tried to disable and enable again - got this error: An error occurred while installing the Module Updates module This might be an issue with the final version of Gallery 3 since I developed against the RC versions. I need to upgrade my Gallery still and once I do I'll begin fixing these issues. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Tue, 2010-11-23 21:21
|
|
Hmmm, I just upgraded to v3.0 final release and uninstalled and reinstalled the module and I'm not having any issues. The quick solution will be to manually delete the database entries inserted by the application and try again. I'd suggest deleting the files from the system and uploading a new copy as well from the official page. DELETE FROM modules WHERE name='moduleupdates' DELETE FROM caches WHERE tags LIKE '%ModuleUpdates%' If your tables have unique names you will have to modify them. I just performed these steps on my install and then proceeded to successfully install it afterwards. |
|
|
crackers
Joined: 2002-10-24
Posts: 67 |
Posted: Wed, 2010-11-24 01:32
|
|
That worked I s'pose. But now ModuleUpdates (downloaded from gallery3modules.com) says it isn't updated, and fails to update. Says I have version 2 installed and wants version 3. But AFAIK, I downloaded 3: server:/var/gallery3/modules/moduleupdates# cat module.info ah well... |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-11-24 01:52
|
|
Looks like when someone updated my code to handle the new correct git structure they didn't update the part of the code that injects the version number into the modules table. So it's version 3 now from the updates but the system thinks it's 2. I'll work on getting a fresh git copy and updating the update. The errors also probably come from this newer version someone else worked on, since I'm still working on my last copy I made. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-11-24 03:03
|
|
Where oh where can I get the current version from in the system??? The modules.info file and modules table both have the 41 version number and doing gallery::VERSION gives me "3.0 (Santa Fe)." All I want is the version number like it corresponds to the value in the git hub (3.0 or 3.1) so I can have my program dynamically lookup the location based on what version your running instead of needing to upgrade the module every time. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2010-11-24 05:06
|
|
Ok, I made a little hack for now to get the data I want from gallery::VERSION for now. Version 4.0 of ModuleUpdates is now in my git waiting to be pulled. [*]Fixed: version information during upgrade fixed with v3 |
|
|
bharat
Joined: 2002-05-21
Posts: 7994 |
Posted: Thu, 2010-11-25 22:23
|
|
I pulled your changes. But I noticed that Alex Schomburg (alexschomb here in the forums) made some changes on top of yours and I'm having difficulty merging those because there are conflicts. Can you guys put your heads together and get your forks clean so that I can merge in all the goodness? That'd be great, thanks! |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Thu, 2010-11-25 22:50
|
|
Yup, sure will. |
|
|
alexschomb
Joined: 2010-10-24
Posts: 19 |
Posted: Thu, 2010-11-25 23:22
|
|
Oh, I didn't even know there is a place like this. Thanks to bharat for redirecting me to this topic. In the past month I did commit some changes to your update without asking you, sorry for that, I hope you don't mind. bharat mentioned there is a conflict error that might result in our both versions. Actually I don't know how to directly solve that problem. Actually I just changed your script a little bit to work with the new GalleryModules.com interface done by dmolavi. But for getting this done I kept it real simple and removed all your GitHub checks as GalleryModules.com does this itself. I also asked dmolavi to check for the modules of the main repo (gallery3, not gallery3-contrib) so we can get some results for these modules too. He agreed to implement it, but I don't think it's ready yet. With best regards, |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Fri, 2010-11-26 02:10
|
|
What I was thinking of doing was one of 2 things. 1 - Check the Git & GM and show both values with an indication as to which ones have versions different than what you have with links to both 2 - Give the user the choice of what place to check and then give them that information I'll look at both and see which one will be the most robust to implement. |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2011-01-05 03:41
|
|
Version 5 is now in my GitHub for both 3.0 and 3.1. This merges Alex's code with mine along with some extras.
|
|
|
alexschomb
Joined: 2010-10-24
Posts: 19 |
Posted: Wed, 2011-01-05 13:25
|
|
Great job. Thank you very much! The check against GalleryModules.com and gallery3.git seems to work correctly. But in the column for gallery3-contrib are no version entries shown at all. Two little suggestions on the side: |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2011-01-05 15:01
|
|
I'll add the verbiage clarifications in the next version. Hmm, mine is showing updates for the Contrib versions. I'll pull from the git and test that just to make sure I didn't miss uploading something. |
|
|
dmolavi
Joined: 2002-12-05
Posts: 573 |
Posted: Wed, 2011-01-05 15:25
|
|
You need to update your download links in Codex and at the top of this post, they point to the gallery3/gallery3-contrib repo, which doesn't have version 5 yet, or submit a pull request so it gets pulled into the main repo. -- |
|
|
brentil
Joined: 2007-04-11
Posts: 124 |
Posted: Wed, 2011-01-05 15:55
|
|
dmolavi wrote:
You need to update your download links in Codex and at the top of this post, they point to the gallery3/gallery3-contrib repo, which doesn't have version 5 yet, or submit a pull request so it gets pulled into the main repo. I saw the pull request info but I don't know how to do it. Is there git documentation that will show me how to do that? |
|
|
dmolavi
Joined: 2002-12-05
Posts: 573 |
Posted: Wed, 2011-01-05 16:01
|
|
Just click the pull request button on your repo page. it will send a request to the g3 admins to pull into the main repo. But, before you do that, i noticed that you don't check the 3.1 repo on GalleryModules.com properly. The correct version URLs are as follows: Gallery 3.0.x: Gallery 3.1.x: -- |
|
!
