Gallery 3.0 Beta 2 Feedback

Thank you.
-=SM=-

We pulled Polar Rose from the official distro, so you can either delete it from your modules dir, or grab the latest copy from the gallery3-contrib repo.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

What was the reason to combine JS/CSS?
Now it is almost impossible to design/track theme changes
Is there a way to disable it?

The upgrade process was perfect - well done, and thanks!

However:

Is it no longer possible to Add from Server a whole directory?
So now I have to click on each of the dozens of files in the folders?

I have tried shift-clicking but no luck, I have tried double-clicking the folder, but this ends up with no images in that folder selected.

BTW - just done what it says, and works for me

Weird. The .htaccess file didn't get replaced when copying over the Beta2 stuff to my Beta1 directory.

Anyway, now works fine; thanks.

If I turn off the Organize module, the missing images will show up when using Internet Explorer. Safari/Firefox/Google Chrome continue to not display the images regardless.

Additionally, if I turn on Notification, the root album (gallery3/index.php) will not load when logged in as a "normal" user, although sub album's continue to load fine. It will load fine when logged in as admin or not logged in at all though.

I know it's not supported in Windows, but the fact that it works fine in one browser but not another is making me wonder if the problem I'm seeing is on the server end or the web browser end :/

That line of code fixes the image display problem in Safari. Internet explorer works properly for me regardless of that line. Firefox and Google Chrome continue to not work. I also deleted everything from the gallery3 caches table, just to make sure everything was refreshing properly.

@rWatcher: What you're seeing is that URLs that are mangled in a Windows specific way work fine on a Windows based browser. But even though we don't support Windows, we don't want to cut it off at the knees either. nivekiam and I are discussing a fix here:
http://github.com/nivekiam/gallery3/commit/a2930cfa613ef12e91909a9351d2a01019f53937#comment_25489 -- when we get that right I'll pull it in.

@SergeD: browser connections to load JS and CSS are a huge source of end-user latency. By combining the files, we make the site *much* faster. There's no way to turn it off currently, but we can add a means to do that in the future if it's really getting in your way.

@jezmck: you can still an entire directory hierarchy in server_add. Directories are selectale, just use single-click to select the one you want. For the unusually large thumbnail you've got there.. that's weird. Can you share the url to your site here?
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Oh right, I forgot about the browser cache That does fix it, thanks It also fixes the issue where the Organize module was messing up IE.

Ah, thanks. IE being the only browser to work makes sense now

@SergeD: I'm not going to get into a long discussion about this, but suffice it to say that this particular issue is my area of expertise as it's what I do in my day job. Read up on this via the links here http://www.google.com/search?q=high+performance+websites
Install Google Page Speed (or YSlow!) and profile both approaches and you'll see a substantial improvement with the current approach. Don't count on your bare intuition here. Nothing is being obscured, optimized or compiled here-- we're just combining requests. I would at some point like to loop JSMin and CSSMin into this though and actually optimize our JS and CSS to reduce bytes over the wire and remove unnecessary CSS.

@jezmck: there is a spinner when it's loading folders. I'm not sure why it's not appearing for you.
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

Upgrader went fine. Nice

Just a small thing i noticed as far. When exif-module is activated i get a "view more information" button in the sidebar. It's a bit confusing there, especially when you have the image-block-module. So my first thought was it's the exif of the random image ^^ Besides this "theme-issue" when i click on the button, a nice popup with the exif-tags comes up... but how to close it? There is no "x" or "close" or anything like that ;-)

bharat will have a better longer more professional answer, but here is mine albeit short answer:
One http request is 2 times faster than 2.
But to quote a book author on the subject:
"...the server only makes one HTTP request per page instead of several. All this shaves valuable milliseconds off delivery time."
from a different book on the subject:
'Rule 1 - Make Fewer HTTP Requests' as we already have to make a lot because each image is a request in itself being a photo album and all.

I agree with you that there needs to be a 'switch' to turn it off for development.

Dave

_____________________________________________
Blog & G2 || floridave - Gallery Team

@Bigda: check your var/logs output and your apache logs output. Anything in there?

@van_Gogh: there's a little [x] in the top right hand corner that you can use to close that, and all other dialogs. We have http://sourceforge.net/apps/trac/gallery/ticket/214 to figure out where to put the exif data.

@SergeD: At this point, I'm pretty overloaded with making the product work so that we can release it. I'm comfortable with what we have. If you feel that we've gone the wrong direction with combining CSS, please make a compelling case why it should be changed with reproducible benchmarks and I'll seriously consider it. But without data, I'm going to leave it as it is.

@chrismc: can you delete var/modules/g2_import and try again and see if you still get the problem? If you do, can you zip up your var/modules/g2_import and share it with us?
---
Problems? Check gallery3/var/logs
bugs/feature req's | upgrade to the latest code | use git | help! vote!

suprsidr, SWEET!!!!
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

There is a gzip mod for htaccess file which makes firebug happier

<IfModule mod_deflate.c>
# compress the files
AddOutputFilterByType DEFLATE text/html text/plain text/xml text/css text/javascript application/x-javascript

# removes some bugs
BrowserMatch ^Mozilla/4 gzip-only-text/html
BrowserMatch ^Mozilla/4\.0[678] no-gzip
BrowserMatch \bMSIE !no-gzip !gzip-only-text/html
BrowserMatch \bMSI[E] !no-gzip !gzip-only-text/html
SetEnvIfNoCase Request_URI \
\.(?:gif|jpe?g|png)$ no-gzip dont-vary

Header append Vary User-Agent env=!dont-vary
</IfModule>

@bharat: D'oh. It was there, but i didn't see it because of the css-bug under windows. With nivekiam fix i see it now ;) Sorry for complaining.

@bharat: logic of forcing combined CSS/JS is not optional
If I am to create a file without any CSS or JS registered using $theme->css or $theme->script, code still trying to put combined files and therefore failing since there is none

Another thing, there is no minimal theme based just page.html.php.
Code requires album.html.php also being present

Comments...

1-Upgrader went well. ya!
2-Oups, still no EXIT rotation? ok ok, I'll wait (Yes I know it is in the bug database)
3-Yes, some % radio of JPG!

Easyness of use (bug or feature request?)

10-When looking at the full image size, it there any plan to do a "next" when clicking at the right part of the image, "previous" on the left side, and close anywhere else? Like that the "X" in the up-right corner could disapear.
11-When clicking on "start translating", nothing really happens... there is no hints about anything.
12-"Start translating" is not translated by the way ;)
13-I added some photos with the "add from local folder" and after the "Found 30 pictures" is seems to stop and do nothing. I did not know if I needed to clic somewhere or not. After waiting for a while, it did show adding 1 of 30...

Real bugs

20-The slideshow module does not work with album that contain accents ("é").
21-The slideshow does not seems to load PNG files.
22-Looking at a single photo and loading the slideshow does not work. The slideshow say: "There are no items, Please try another link"

Alexandre Racine
http://www.salsamontreal.com - Évènement, photos et beaucoup plus!

> > 12-"Start translating" is not translated by the way ;)
> 12-> please file a bug on this.

please don't file a bug. the "start translating" message is internationalized already. all that is missing is a translation to your language (French?).
you can translate it yourself and you can share the translation with the community.

see:
http://codex.gallery2.org/Gallery3:Localization

@floridave:
in the translation UI, click on "show all", then you'll see a list of all messages, including "start translating."

this might sound like a hack, but there's a reason for that. there's a whole list of messages that you might never see when you're translating. e.g. the "login" message, since you're logged in already. or any other message that is shown only to guest users. or messages that are only shown under certain conditions. that's why we have this "show all" mode.

@floridave @valiant
12-> "Show all" does not show all. It only display all strings currently active on the page. Since "Start translating" is only available when the translator is not active, it will never show in the "show all" list. https://sourceforge.net/apps/trac/gallery/ticket/567

@floridave
20-> Done. https://sourceforge.net/apps/trac/gallery/ticket/569
22->no no, start from here http://www.langleycom.com/gallery3/index.php/ONe_item/53front.jpg https://sourceforge.net/apps/trac/gallery/ticket/568

I'll wait for the next version for the other stuff.

Alexandre Racine
http://www.salsamontreal.com - Évènement, photos et beaucoup plus!

Search for conversations on this, but in summary it's not going to happen in the core product, period. We've learned our lesson from G2 Someone may create a plugin for this, but the decision was made to keep things simple and for performance reasons. Having permissions being able to be set by user and on individual items can really hurt performance.

____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here

I would like to propose improved version of bb2html function used in import
Also can we make it a core function available from anywhere, may be as part of HTML purifier

a) added support for o, img with alt text, mail, center, class, list
b) added nl2br normalization
c) <, > replaced with &lt;, &gt;
d) &amp;quot; replaced with &quot;
e) removed use of <font>, <span> is used instead
f) added "alt" to image declaration for W3C validation
g) fixed bug in {color}, and {ul} definitions
e) stops slashing, useful when pulling from db

function bb2html($text)	{

  static $bbcode_mappings = array(
    "#\\[b\\](.*?)\\[/b\\]#" => "<strong>$1</strong>",
    "#\\[i\\](.*?)\\[/i\\]#" => "<em>$1</em>",
    "#\\[u\\](.*?)\\[/u\\]#" => "<u>$1</u>",
    "#\\[s\\](.*?)\\[/s\\]#" => "<strike>$1</strike>",
    "#\\[o\\](.*?)\\[/o\\]#" => "<overline>$1</overline>",
    "#\\[url\\](.*?)\[/url\\]#" => "<a href=\"$1\">$1</a>",
    "#\\[url=(.*?)\\](.*?)\[/url\\]#" => "<a href=\"$1\" target=\"_blank\">$2</a>",
    "#\\[mail=(.*?)\\](.*?)\[/mail\\]#" => "<a href=\"mailto:$1\" target=\"_blank\">$2</a>",
    "#\\[img\\](.*?)\\[/img\\]#" => "<img src=\"$1\" alt=\"\" />",
    "#\\[img=(.*?)\\](.*?)\[/img\\]#" => "<img src=\"$1\" alt=\"$2\" />",
    "#\\[quote\\](.*?)\\[/quote\\]#" => "<blockquote><p>$1</p></blockquote>",
    "#\\[code\\](.*?)\\[/code\\]#" => "<pre>$1</pre>",
    "#\\[ size=([^\\[]*)\\]([^\\[]*)\\[/size\\]#" => "<span style=\"font-size: $1;\">$2</span>",
    "#\\[ color=([^\\[]*)\\]([^\\[]*)\\[/color\\]#" => "<span style=\"color: $1;\">$2</span>",
    "#\\[class=([^\\[]*)\\]([^\\[]*)\\[/class\\]#" => "<span class=\"$1\">$2</span>",
    "#\\[center\\](.*?)\\[/center\\]#" => "<div style=\"text-align: center;\">$1</div>",
    "#\\[ list\\](.*?)\\[/list\\]#" => "<ul>$1</ul>",
    "#\\[ul\\](.*?)\\[/ul\\]#" => "<ul>$1</ul>",
    "#\\[li\\](.*?)\\[/li\\]#" => "<li>$1</li>",
  );

  // Replace any html brackets with HTML Entities to prevent executing HTML or script 
  // Don't use strip_tags here because it breaks [url] search by replacing & with amp 
  $newtext = str_replace("<", "&lt;", $text); 
  $newtext = str_replace(">", "&gt;", $newtext); 
  $newtext = str_replace("&amp;quot;", "&quot;", $newtext); 

  // Convert new line chars to html <br /> tags 
  $newtext = nl2br($newtext);  

  if (strpos($text, "[") !== false) {
    $newtext = preg_replace(array_keys($bbcode_mappings), array_values($bbcode_mappings), $newtext);
  }
  
  $newtext = stripslashes($newtext);  //stops slashing, useful when pulling from db
  return $newtext;
}

Note: extra spaces need to be removed in size, color, and list rule declaration as they are placed here for format only

Beta2 is great. Install is smooth. My G2.3 is integrated with phpbb. The import from g2 works great. My 3000 images in g2 were successfully imported to G3. A little issue : In g2, both image and album thumbs are square. After import to g3, image thumbs are still square while album thumbs changed to origin photo aspect ratio. Images thumbs in album page are square while image thumbs in image block are NOT square. Is it an issue related with square thumb or related import from g2?

I moved the gmaps module in g3 alpha2 version to beta2 and have a test. After that, when I tried to delete the module, I didn't find the delete function in module management panel. So I deleted the record in table [modules] and delete the files. It works but is it OK?

A similar case is that I didn't find how to delete an updated translation of a word (the word has been yellow-green highlighted already ). So I deleted in database. It works also but is it OK?