Zen Cart G2 Configuration error

Noted.

Been wrestling with fixing this bug and it works on my system.

I'll get back to you on this ... maybe I'll just disable the check.

--
dakanji.com

On with the files, bear in mind that we are talking about a bridge between two separate applications: ZC on one hand, and G2 on the other. To bridge them, some files have to be added to ZC and other files to G2.

Due to the fact that the files that should go into ZC need to be placed in a number of different folders within ZC, I was getting people getting mixed up and having installation issues so I decided to get a copy of ZC, place the files in the right locations and put it up for download so that people can get this and just put the G2 files in place and get going. So yes, you still need to have the files for G2 as the codex outlines.

On the error, thanks for posting the actual error message from the logs. I had just been getting complaints and never had the opportunity to check the logs. I had been as confused as hell since the code works just fine on my setup. Having seen the error message, it appears it is because you are not on PHP 5.3 (post link to phpinfo to confirm).

If this is the case, then wait for a while and check for v3.3.2a. You don't need to change the prepatched zencart files.

BTW, you must have nipped in within a short window as I only had 3.3.1c up for a little bit before updating it. Anyway, wait until the link on my site reads 3.3.2a and then download that set.

Maybe I'll ultimately make the module PHP 5.3 only and set it up to refuse to install otherwise. This particular issue is minor though if it is just a case of the '__DIR__' magic constant causing the problem.

Need the phpinfo to confirm.

--
dakanji.com

Thanks for the explanation.

Here is the phpinfo link.

phpinfo link = http://www.carlinosweb.com/gallery2/phpinfo.php

Looks like 1&1 is on version 4.4.9.

To test my understanding of my problem, G2 and ZC can run independently on PHP v4.4.9, but they can't talk to each other since the ZC integration module in G2 requires v5.3. Is this a correct? If correct, I either need to get 1&1 to upgrade to php 5.3, find a new web host, or find another gallery and/or cart solution.

I realy appreciate your help with this. Nice to see I had a basic understanding of what I was doing
John

I copied and pasted the new code and I am still getting the same error.

It does not appear that it is generating an error message in the EventLogMap table this time.

John

OK. A few things.

You should not be having the error as everything looks fine on your site (noticed you actually had v3.3.2 which I have changed to read v3.3.2a)
I uploaded a file to your zencart module folder and if you navigate to it at http://www.carlinosweb.com/gallery2/modules/zencart/pathtest.php, you will see that it confirms that your ZC's parent directory is that same as your G2 location. The code run by that file is the same as in AdminZenCart.inc where it does the checks.

So, the code looks perfectly fine to me and perhaps the error you saw the second time is from a cache. Try clearing your browser cache and have another go.

A few things of note:

• I forgot to remove the Mac resource files when I packed the ZC prepatched files so your ZC is full of "._xyz" files. You can go and delete the lot. The only files that should have a '.' in front of them are '.htaccess' files. Note that this are different to '._htaccess' which can be deleted. Sorry!
• You seem to have every G2 module going on the server. You might want to consider getting rid of those you don't use.
• I used the self destruct feature of the shell script to delete it. Please verify.
• Change your passwords stored in clear text e.g in config.php on G2 and similarly in ZC. I didn't look but I could have looked
• Ask 1&1 to move you to a server with PHP 5 as default (not one where you need to poodle about to get it working). Demand Apache2 while you are at it. There is no reason why they should be running such old software and you will be facing issues as careless coders like me start to only code based on 5.3 etc.

Back to the issue at hand, I am sorry but I can't figure out why you should be having those errors.

If all fails, you can disable the check by changing...

$error[] = 'form[error][path][badDir]';
GalleryCoreApi::removePluginParameter('module', 'zencart', 'path');

to

/* Disable folder consistency check */
//$error[] = 'form[error][path][badDir]';
//GalleryCoreApi::removePluginParameter('module', 'zencart', 'path');

... in AdminZenCart.inc.

--
dakanji.com

I cleared my cache but still no dice. Will try the disable option you suggested.

I am not sure if this has any bearing on the problem, but I cannot get to ZC's admin module with the current install. All that appears is a blank page. During one of my prior troubleshooting attempts, I did a clean install of ZC from their download and was able to get to the admin page.

I did confirm that the self destruct removed the file.
Other items appreciated and noted. I will be clean up once I work through this problem.

I will post the results of disabling the checks.

OK a few things.

On my site, I have just been able to create a test album and it was added to ZC as a category (where your install is falling down) without any issues. However, looking at the code in modules/zencart/classes/GalleryZenCart.class at line 865, I can see it doesn't make sense and will always crash (it is testing for a variable that has not been created before then).

So there are a few queries to answer.

I have gone back to the first version of the module as written by the original developer and that function has not changed from then. As it looks on the surface that the code should always crash at that point, I need to figure out why after several installations I have done over the years I have been working on this, I have yet to have a crash at that point.

I have however not installed for a while (been editing existing files) so I will do so and see what gives. However the same code should run when adding a new album and I just did that successfully.

Apart from this, you have an issue with you overall installation (blank page).

I suggest you do the following
1. delete the zc module from within your g2 admin
2. Drop the zc database, delete your zc folder, grab a copy of the prepatched fileset (sorry about the ._xyz files) and reinstall zencart. Once that is done, just leave it alone ... well you can busy yourself deleting the ._xyz files.
3. use the script attached here to search your G2 db for any references to zencart and delete them using phpmyadmin

Leave things alone at that while I look into this.

I am afraid I can't say when I will be done but will try to get to the bottom of it ... starting by installing fresh copies of g2 and zc and seeing if I hit any issues trying to install the module.

Gotta run. Good luck!

--
dakanji.com

Sounds like a good idea since you haven't yet put much on it.

Give it about an hour or so while I repackage the ZC files to exclude the Mac stuff.

--
dakanji.com

Will do. Thanks again.

Hi Dayo
I did a complete reinstall of both Gallery and ZC using the prepackaged files. All went perfectly until I reached the Activate Module step in Gallery Admin. Clicking activate does nothing. The following error is generated in the g2_EventLogMap table

Any ideas?

If that still crashes, then change your function makeThumbnailUrl to ...

    function makeThumbnailUrl($itemId) {
	global $gallery;

	list ($ret, $thumbnail) = GalleryCoreApi::fetchThumbnailsByItemIds(array($itemId));
	if ($ret) {
	    return array($ret, null);
	}
	if (isset($thumbnail[$itemId])) {
		/* use default image firewall process */
		$urlGenerator =& $gallery->getUrlGenerator();
		$url = $urlGenerator->generateUrl(
			array('view' => 'core.DownloadItem', 'itemId' => $thumbnail[$itemId]->getId()),
			array('forceFullUrl' => true, 'forceSessionId' => false));
	    $urlParts = parse_url($url);
	    $zenPath = trim($this->_zenCart->getZenConstant('DIR_FS_CATALOG') . $this->_zenCart->getZenConstant('DIR_WS_IMAGES'), '/');
	    $relativeUrl = '';
	    /* Take it back to the root... */
	    foreach (explode('/', $zenPath) as $part) {
		$relativeUrl .= '../';
	    }
	    /* ...and travel to the target from there. */
	    $url = rtrim($relativeUrl, '/') . $urlParts['path'];

	    /* Add query string if not using URL rewrite. */
	    if (!empty($urlParts['query'])) {
			$url .= '?' . $urlParts['query'];
	    }
	} else {
	    $url = '';
	}

	return array(null, $url);
    }

Let me know which one works out
--
dakanji.com

Nice.

Glad the first one worked as that was the preferred option.

Now, looking at your site, I see the thumbnails are not showing up on the ZC side. Are you sure you are using the prepatched Zencart 1.3.9h files? This should not be happening if the Zencart installation was from those files. Can you confirm?

***** EDIT****
There is a bug in the code fix which is breaking your thumbnails.

Please change the fix from ...

	if (isset($thumbnail[$itemId])) {
		list ($ret, $pluginStatus) = GalleryCoreApi::fetchPluginStatus('module');
		if ($ret) {
			return array($ret, null);
		}
		if (isset($pluginStatus['bypass']['active'])) {
			if ($pluginStatus['bypass']['active'] == 0) {
				/* use default image firewall process */
				$urlGenerator =& $gallery->getUrlGenerator();
				$url = $urlGenerator->generateUrl(
					array('view' => 'core.DownloadItem', 'itemId' => $thumbnail[$itemId]->getId()),
					array('forceFullUrl' => true, 'forceSessionId' => false));
			}
		}
		if (!isset($url)) {
			/* bypass image firewall process and return direct links to g2data */

to

	if (isset($thumbnail[$itemId])) {
		list ($ret, $pluginStatus) = GalleryCoreApi::fetchPluginStatus('module');
		if ($ret) {
			return array($ret, null);
		}
		if (isset($pluginStatus['bypass']['active'])) {
			if ($pluginStatus['bypass']['active'] == 0) {
				$firewall = true;
			}
		}
		if ($firewall) {
			/* use default image firewall process */
			$urlGenerator =& $gallery->getUrlGenerator();
			$url = $urlGenerator->generateUrl(
				array('view' => 'core.DownloadItem', 'itemId' => $thumbnail[$itemId]->getId()),
				array('forceFullUrl' => true, 'forceSessionId' => false));
		} else {
			/* bypass image firewall process and return direct links to g2data */

Deactivate and reactivate the module to rebuild the thumbnail links.

You may also want to go into module.inc and change $this->setVersion('3.3.3'); to $this->setVersion('3.3.3a'); afterwards

--
dakanji.com

Ignore the queries ... see bug notice above.
--
dakanji.com

This should finally sort it out ...

	if (isset($thumbnail[$itemId])) {
		list ($ret, $pluginStatus) = GalleryCoreApi::fetchPluginStatus('module');
		if ($ret) {
			return array($ret, null);
		}
		if (isset($pluginStatus['bypass']['active'])) {
			if ($pluginStatus['bypass']['active'] == 0) {
				$firewall = true;
			}
		} else {
			$firewall = true;
		}
		if ($firewall) {
			/* use default image firewall process */
			$urlGenerator =& $gallery->getUrlGenerator();
			$url = $urlGenerator->generateUrl(
				array('view' => 'core.DownloadItem', 'itemId' => $thumbnail[$itemId]->getId()),
				array('forceFullUrl' => true, 'forceSessionId' => false));
		} else {
			/* bypass image firewall process and return direct links to g2data */

Been a bit lax with following the logic through
--
dakanji.com

Can you please test this more succinct version and let me know if it works?

	if (isset($thumbnail[$itemId])) {
		list ($ret, $pluginStatus) = GalleryCoreApi::fetchPluginStatus('module');
		if ($ret) {
			return array($ret, null);
		} else if (isset($pluginStatus['bypass']['active'])) {
			$firewall = $pluginStatus['bypass']['active'];
		}
		if ($firewall) {
			/* use default image firewall process */
			$urlGenerator =& $gallery->getUrlGenerator();
			$url = $urlGenerator->generateUrl(
				array('view' => 'core.DownloadItem', 'itemId' => $thumbnail[$itemId]->getId()),
				array('forceFullUrl' => true, 'forceSessionId' => false));
		} else {
			/* bypass image firewall process and return direct links to g2data */

--
dakanji.com

OK. I would have expected the shorter one to also work but let's stick with the previous.

Now, remember to change the module.inc to 3.3.3a as outlined earlier and edit the ZC look. I put a big "Designed by Dayo Akanji" there to motivate people but it seems many can't be bothered lol.

Enjoy!

--
dakanji.com

Works fine.