help change code of jensperms module

Not really

I think I sort of understand what you want to do but the actual query is lost somewhere along the line.

Can you repeat what it is you want to do without the code example and gallery Info since these are now in the original post.

Just something along the lines of: I want to assign xyz type permissions to abc type users when def type action takes place.

--
dakanji.com

I don't know what the jensperms module is (guessing it is an earlier form of the useralbums module) but change the handle event function to ...

function handleEvent($event) {
	global $gallery;

	$entity = $event->getEntity();
	$entityId = $entity->getId();
	$userId = $gallery->getActiveUserId();
	list ($ret, $coreParams) = GalleryCoreApi::fetchAllPluginParameters('module', 'core');
	if ($ret) {
		return $ret;
	}
	$guestGroupId = $coreParams['id.everybodyGroup'];
	$registeredGroupId = $coreParams['id.allUserGroup'];

	switch ($event->getEventName()) {
		case 'GalleryEntity::save':
			if (GalleryUtilities::isA($entity, 'GalleryDataItem' && $entity->testPersistentFlag(STORAGE_FLAG_NEWLY_CREATED)) {
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.all');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $guestGroupId, 'core.viewResizes');
				if ($ret) {
					return array($ret, null);
				}
			} elseif (GalleryUtilities::isA($entity, 'GalleryAlbumItem' && $entity->testPersistentFlag(STORAGE_FLAG_NEWLY_CREATED)) { 
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.viewAll');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.addAlbumItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.addDataItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.edit');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $registeredGroupId, 'core.addDataItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $guestGroupId, 'core.view');
				if ($ret) {
					return array($ret, null);
				}
			}
			break;
		case 'GalleryEntity::delete':
		
			break
		case 'Gallery::Login':
		
			break
		default:
		
			break;
	}
	return array(null, null);
}

I changed it to a switch to allow adding other events later if you want.

You can play with the various permission types as listed below:

core.all				->		All access
core.view				->		View item
core.viewResizes			->		View resized
core.viewSource				->		View original version
core.viewAll				->		View all versions
core.addAlbumItem			->		Add sub-album
core.addDataItem			->		Add sub-item
core.edit				->		Edit item
core.changePermissions			->		Change item permissions
core.delete				->		Delete item

Let us know if it works.

--
dakanji.com

Try this instead ...

<?php
class JensPermsModule extends GalleryModule {
	function JensPermsModule() {
		global $gallery;
		
		$this->setId('jensperms'); /* this must match the directory name */
		$this->setName('Auto Permissions'); /* this is the module name */
		$this->setDescription($gallery->i18n('Auto permissions for new items'));
		$this->setVersion('0.9.1');
		$this->setGroup('gallery', $gallery->i18n('Gallery'));
		$this->setCallbacks('');
		$this->setRequiredCoreApi(array(7, 54));
		$this->setRequiredModuleApi(array(3, 9));
	}

	/**
	* @see GalleryModule::performFactoryRegistrations
	*/
	function performFactoryRegistrations() {
		$ret = GalleryCoreApi::registerFactoryImplementation(
			'GalleryEventListener', 'JensPermsModule', 'JensPermsModule', 
			'modules/jensperms/module.inc', 'jensperms', 
			array('GalleryEntity::save'));
		if ($ret) {
			return $ret;
		}
	}
	
	/**
	* Event handler for GalleryEntity::save event
	*
	* @param object GalleryEvent the event
	* @return object GalleryStatus a status code
	*/
	function handleEvent($event) {
		global $gallery;
		
		$entity = $event->getEntity();
		$entityId = $entity->getId();
		$newItemFlag = $entity->testPersistentFlag(STORAGE_FLAG_NEWLY_CREATED);
		$userId = $gallery->getActiveUserId();
		list ($ret, $coreParams) = GalleryCoreApi::fetchAllPluginParameters('module', 'core');
		if ($ret) {
			return $ret;
		}
		$guestGroupId = $coreParams['id.everybodyGroup'];
		$registeredGroupId = $coreParams['id.allUserGroup'];
		
		if ($event->getEventName() == 'GalleryEntity::save') {
			if (GalleryUtilities::isA($entity, 'GalleryDataItem' && $newItemFlag) {
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.all');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $guestGroupId, 'core.viewResizes');
				if ($ret) {
					return array($ret, null);
				}
			} elseif (GalleryUtilities::isA($entity, 'GalleryAlbumItem' && $newItemFlag) { 
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.viewAll');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.addAlbumItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.addDataItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addUserPermission($entityId, $userId, 'core.edit');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $registeredGroupId, 'core.addDataItem');
				if ($ret) {
					return array($ret, null);
				}
				$ret = GalleryCoreApi::addGroupPermission($entityId, $guestGroupId, 'core.view');
				if ($ret) {
					return array($ret, null);
				}
			}
		}
		return array(null, null);
	}
}
?>

You need to be on G2.3.x to use this code.

PS. You might need to remove the "core.edit" permission if you don't want the user to delete items as looking at how it works, it seems that there may be a bug as it seems to bypass some other permission settings and allows the user to change permissions. Just a cursory look at it though so needs testing on your part.
--
dakanji.com

"I am still getting error" is a bit vague. What error are you getting?

--
dakanji.com

So try a few simple tests.

1. Do you get the error even if you remove the module?
2. Do you get the error with the original module before making changes?

Basically, you do a few logical eliminations to try to figure out where the problem is coming from as the error may not be related to this code.
Removing and adding stuff into a test environment to try to get an idea where an issue is coming from doesn't need coding knowledge.

--
dakanji.com

PS: Have you looked at the userAlbum Module? http://codex.gallery2.org/Gallery2:Modules:useralbum

I don't think it does what you want out of the box but this can be amended as well and has other features.

--
dakanji.com

I copied the code you gave me. The module is consisting of only 1 file - module.inc. When I replace the original code with the modified the browser get's the error. I didn't change any names and I left the module as it should be (as much as possible).

I tried again with changes made and there is no change. I will try to change some of the code these days and tell you if something happens.

Thanks for the help!