Help for Module-Develpoment: Choose Videothumb

I'm having no such problem.
Are you using firebug or similar to view the response?

Besides a bit of dialog polishing and a refresh after the response this looks great.
Good job.
Maybe add an additional option to upload a custom thumb for those without ffmpeg.

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

I thought maybe the html purifier module would cause your issue, but I cannot reproduce the issue.
But I'm still on 3.0.1

here is my cleaned up videothumb_dialog.html.php

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

I'll upgrade to 3.0.2

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

try this:
/controllers/videothumb.php line~24

  function dialog($item_id) {
    $item = ORM::factory("item", $item_id);
    access::required("view", $item);
    access::required("edit", $item);
    $v = new View("videothumb_dialog.html");

    $v->item = $item;
    if($_POST['sent']) {
        $this->extract_frame_manual($item_id);
    }
    print json::reply(array("html" => (string)$v ));
  }

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

Only thing I see that would 'clean' it up a bit is:

- to remove it from the top menu selection (only show on context menu)
- don't show option if not a video

Other than those two nitpicking ideas, awesome.

What more can I say... perfect module!

I was doing this by hand, and it was a pain in the @&&.

Many thanks to you folks.

updated the above site_menu function to actually work this time ;)

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

Ahhmm this is stunning. What happend in this thread while I was away coding?

Now one can choose which version to prefer ;-)

I added the possibility to define thumb-dimensions. They are set on the basis of defined width in theme and assumes 4:3 aspect ratio. Also I included a field for minute.

Have a look. May be we can combine our work.

@floridave:
I had the same two points on my whishlist. Total-time is now added. (see attachement)

Point 2:
Since it immediately changes the thumb "Preview" is mistakeble. I thought of a "Ready" button, but every Submitbutton in the proper style leads to a Cancelbutton beside it. If someone can help me out with this javascript-thing ... to have a single "Ready"-Submitbutton.

Next question would be where to place the "Ready"? The right place would be between the "Send" an "Cancel". But that could be difficult since they come automatically together.

@mr.xy
Dealing with video duration in total seconds would probably be more fitting as some video formats set duration in total seconds not min:sec.
Not one of my videos showed a duration of more than 0:0 with your query. Here is my solution:

  static function get_duration_manual($item) {
    $ffmpeg = movie::find_ffmpeg();
    if (empty($ffmpeg)) {
      throw new Exception("@todo MISSING_FFMPEG");
    }
    
    $cmd = escapeshellcmd($ffmpeg) . " -i " . escapeshellarg($item->file_path()) . " 2>&1";
    $result = `$cmd`;
    if (preg_match("/Duration: (\d+)\d+)\d+\.\d+)/", $result, $regs)) {
      return 3600 * $regs[1] + 60 * $regs[2] + $regs[3];
    } else if (preg_match("/duration.*?:.*?(\d+)/", $result, $regs)) {
      return $regs[1];
    } else {
      return '00';
    }
  }

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

Thanks suprsidr for your duration-function. Had to change it a bit, cause it didnt work in my environment. Could you please test whether it still works with your videos. Can't test ist, cause mine all deliver hour:minute:second.

I added the "Done" button and it does makes better usability, I think.

On Thing remains: Translation in Dialog. Does this work. I didn't succeed

here is my working copy.
I have not adopted 4:3 thumbs as I believe that is a step backwards. Videos are predominately captured in widescreen formats these days and I'm not going to force 4:3 on my users.

As stated above I'm only dealing w/ seconds for the time.

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

Great collaboration guys. Keep up the great work.

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

Actually it should not be just for admins but if the user can edit the item:
access::can("edit", $item)

Dave
_____________________________________________
Blog & G2 || floridave - Gallery Team

I added a "working.gif" so you don't wonder what's going on while the thumb is being produced.
And now the thumb is being produced the same dimensions as the original thumb so if your theme is making odd size thumbs, this will keep the aspect - which should solve mr.xy's concerns.
And now vastly faster thumb creation.
Again updated my above archive.

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

fixed!

-s
FlashYourWeb and Your Gallery with The E2 XML Media Player for Gallery2

@suprsidr: Still can't say "Good bye" to my minutes and seconds, because players show it that way, when I look through the video for a good thumb.

Thats why I post another separate version that combines yours (suprsidr's) and my work.

We still have 4:3 videos beside 16:9. Thats why I added an option to choose ratio or freely custom the thumb measures.

The module is tested with admin, registered user and guest.

It shows total video-length (min:sec) and offers the possibility to enter time in min:sec.

Thanks suprsidr's small but very effective ffmpeg-call-modification thumb-generation is much more quick and a working.gif is shown in the short time to spend waiting because of that quick thumb-generation

working.gif and display:none = Cool! Nice little trick - thanks.

We are using module "Rectangle Thumbnails" with defined 4:3 ratio to standardize the look of the photo- and video- gallery-overviews. Videothumbs at 16:9 are therefore croped and thumbs unfortunately don't tell the original ratio.

I've build in detection of whether the "rectangle thumbs" module is active. If so: thumbs are croped to desired ratio and a info is displayed:
"Module "RectangleThumbs" active - Thumbs may be croped to defined aspect ratio."

This seemed to be usefull to me. We may be not the only G3 using uniformation of thumbs.

Beside this I've integrated a detection of the aspect-ratio of the video, to take this information from the uploaded stuff.

Existing thumb unfortunatley don't tell the right dimensions for sure, because via rectangle_thumbs they may be cropped. If you upload an 16:9 video and have defined a 4:3 rectangle_thumb, it will be cropped. This is our situation.

A Colleague here told me, that the usability of the module is better than the preceding in G2, cause he don't have to calculate min:sec (showed by player) to sec any more ;-)

Would like to put our work together and start a codex page to finish this project. What do you think (suprsidr)?

Already working on the next module: http://gallery.menalto.com/node/104516

Comments are now permitted for this topic.

Solution of jnash seems to fix my issue.

However, I have another issue - Videothumb does not work for me. I type in the seconds and the little picture does not change but still shows me the same thumb as before...
Log file is empty.

Any ideas?

I have the standard Ubuntu lucid version of it - video transcode module works fine without error
(please see my other post though - thumbnails of avi clips are not found by kohana proxy, others work fine...)

That any better?

Now seems to work. For anybody experiencing the same issue:

I used this great tutorial:

https://ffmpeg.org/trac/ffmpeg/wiki/UbuntuCompilationGuideLucid

Worked like a charm. Please note that I tried the some under Ubuntu version 8 instead of 10 - and it did not work. Under Lucid though everything works fine.