Search Module

fedak
fedak's picture

Joined: 2003-12-14
Posts: 80
Posted: Wed, 2004-04-28 06:23

Played with the search module a bit this evening. In general things are looking quite good- The new DB architecture is quite fast and the slideshow view of the results is a nice touch.

Some minor issues/comments:

1) Search results are not rendering bbcode

2) The highlighting of matching keywords are a bit hard to see. (Something like google's yellow background highlighting would be nice)

3) Navigate to: http://www.fedak.net/modules/gallery2/main.php
Search for "test", hit return
Press "Show all 15"
Press "Show all 15" again

Error (ERROR_MISSING_OBJECT):
in file c:\nuke\html\modules\gallery2\modules\search\SearchShowAll.inc at line 116 (gallerystatus::error)
in file c:\nuke\html\modules\gallery2\modules\core\classes\GalleryView.class at line 213 (searchshowallview::loadtemplate)
in file c:\nuke\html\modules\gallery2\main.php at line 260 (searchshowallview::doloadtemplate)
in file c:\nuke\html\modules\gallery2\main.php at line 24

4) If the thumbnail has not been cached, the search result is instead showing a small blue box.

5) Trailing/Leading whitespaces should probably be stripped from the search string.

6) The code seems to be stripping out the wildcard ('%'). It would be better if this were escaped rather than removed outright.

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Thu, 2004-04-29 20:49

Great feedback, thanks!

fedak wrote:
1) Search results are not rendering bbcode

Fixed.

fedak wrote:
2) The highlighting of matching keywords are a bit hard to see. (Something like google's yellow background highlighting would be nice)

We'll take care of this when we re-do the search ui (it's on Jon's to-do list)

fedak wrote:
3) Navigate to: http://www.fedak.net/modules/gallery2/main.php
Search for "test", hit return
Press "Show all 15"
Press "Show all 15" again

Error (ERROR_MISSING_OBJECT):
in file c:\nuke\html\modules\gallery2\modules\search\SearchShowAll.inc at line 116 (gallerystatus::error)
in file c:\nuke\html\modules\gallery2\modules\core\classes\GalleryView.class at line 213 (searchshowallview::loadtemplate)
in file c:\nuke\html\modules\gallery2\main.php at line 260 (searchshowallview::doloadtemplate)
in file c:\nuke\html\modules\gallery2\main.php at line 24

Oops, that button shouldn't have been there. I removed it.

fedak wrote:
4) If the thumbnail has not been cached, the search result is instead showing a small blue box.

fedak wrote:
5) Trailing/Leading whitespaces should probably be stripped from the search string.

6) The code seems to be stripping out the wildcard ('%'). It would be better if this were escaped rather than removed outright.

Both good ideas. Can you do me a favor and file bugs for both of these? I'll get somebody to work on them (don't have time at the moment).

 
fedak
fedak's picture

Joined: 2003-12-14
Posts: 80
Posted: Fri, 2004-04-30 01:43

Submitted a bug on the above item, per your request.

Two more:

1) Clicking on the home page "Search" link takes one to the search page, but it does not actually grab the keyword and do the search (like pressing return on from within the search box does)

2) Slightly Pathological:

Navigate to: http://www.fedak.net/modules/gallery2/main.php
Search for the "a" character
Press "Show all 47"
Press "Next >>" 3 times
Type "test" in the search keyword box
Press "Next >>" again

You will now be displaying Results 40-41 of 15, Page 5 of 2

-fedak

 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Fri, 2004-04-30 05:03

Fixed and fixed! Thanks!

 
sowmyabm

Joined: 2008-09-16
Posts: 1
Posted: Tue, 2008-09-16 14:38

please can u help me to know how search module in joomla works? thanks