albums.php valign
|
mbuna
Joined: 2002-12-26
Posts: 96 |
Posted: Wed, 2004-07-28 16:32
|
|
I'd like to suggest that the default vertical alignment of the tables be "TOP" instead of "MIDDLE". This is particularly annoying with the album image when there are lots of sub albums. In 1.4.3.pl2 I've changed line 270 to reflect "TOP" and it shows much better. |
|
Posts: 2322
What you're saying only occurs when you are using the albumTree...
I have to say that I prefer the look of 'middle' to 'top'. Using 'top' gives the page a skewed look while using 'middle' keeps the page uniform.
Posts: 96
Then the code should use TOP when using the album tree, and middle when not.
It's useless when middle and using the album tree as the image often shows up under the fold and you don't see it until you scroll down.
I also think that the width of the table cell that has the album description needs to be shrunk when using the album tree. By default it's too wide and the album tree is very narrow, causing most album names to word wrap.
I set the desc cell to 200 and it appears fairly well, while still leaving enough room to show most album names without wrapping to the next line.
You can see what I mean on my sites:
http://test.fishgeeks.com/modules.php?op=modload&name=gallery&file=index <==== default gallery settings. Note album highlight is down below and album tree is very tight.
http://fishgeeks.com/modules.php?op=modload&name=gallery&file=index <==== modified with valign=top and width=200. Note album highlight shows to left of desc, and album tree is more readable.
Posts: 2322
My opinion on the alignment doesn't change.. I use the albumTree on my site, and I find that setting valign=top is very visually unappealing because it widens the gaps between images.
If you have enough albums that the tree pushes things out of view, then you're losing a significant amount of performance just by having it enabled on the main page.