Some modules are missing from the installer step 8

mgrant

Joined: 2004-08-17
Posts: 100

Posted: Wed, 2004-09-15 18:24

During the installation on step 8 the following modules are not available to select.

Blocks
ImageBlock

Display
Square Thumbnails

Import
Nokia Image Upload

In the interest of being consistent with the "site admin"-> "modules" screen I suggest that these three modules be added to step 8 of the installer.

Thanks,

-mg

baschny

Joined: 2003-01-04
Posts: 328

Posted: Wed, 2004-09-15 19:18

mgrant, the modules-list is generated from the modules found with the distribution. A module can state if it "canBeAutoInstalled" and only those are displayed at install-time, as those are able to auto-configure themselves and we can be sure that they work "out-of-the-box".

Those three modules are currently marked as not "canBeAutoInstalled". The comment about that for Square Thumbnails is "We could autoinstall, but not everyone wants square thumbnails", I guess the same applies to the other two.

If I remember correctly this comes from the time when the installer didn't asked for modules to install, but simply installed everything that was possible using this mechanism. We might consider changing this now, since the user chooses the modules explicitly.

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Wed, 2004-09-15 22:32

Ernst, I think we can change those now... a while back (pre-installer) when you loaded up G2 for the first time it would actually install and activate modules it could auto-install.. that's why I set those to false. But now they will only get switched on if the user checks the checkbox, so that's ok.

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Wed, 2004-09-15 23:48

I set imageblock and squrethumbs to true. Nokiaupload always requires configure so we can't switch that one.... but this brings up a good point: this step of the installer gives the new site administrator their first picture of all the things G2 can do.. shouldn't we give them a more complete picture by listing all the modules? The ones that can't auto-configure can be listed but not available to select, with some note about going to Site Admin after install to configure/activate these modules.

baschny

Joined: 2003-01-04
Posts: 328

Posted: Thu, 2004-09-16 06:16

mindless, I think the "canBeAutoInstalled" module method isn't needed anymore. We could list all modules at install-time, the user selects the ones he wants, we then install those, run autoConfigure and then check if "needsConfiguration". We then display the results "Module xxx has been activated" (in green) and "Modull xxx was installed but still needs configuration" (yellow). "Go to Site Admin to configure those modules" bla bla.. Right?

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Thu, 2004-09-16 15:15

Sounds good to me.

bharat

Joined: 2002-05-21
Posts: 7994

Posted: Thu, 2004-09-16 19:54

That sounds good to me, also.

valiant

Joined: 2003-01-04
Posts: 32509

Posted: Thu, 2004-10-14 10:46

bump

note:
the " Unable to auto configure the Gd module " in red on the top is too near to the title, which is read too. you can easily overlook it.

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Thu, 2004-10-14 15:06

I agree the error/success messages should be grouped together, not separated by a large block of text as they are now.

baschny, can you make a task for this?

baschny

Joined: 2003-01-04
Posts: 328

Posted: Thu, 2004-10-14 15:42

mindless, valiant, as I spoke with valiant about this, I fixed it. Its already in CVS and more intuitive. Installed but not activated modules are (because of needsConfiguration() ) are now properly displayed with a hint to go to Site Admin for further configuration.

I just wanted to keep this topic "hot", because there are still other issues, which comes from the GalleryModule-API from a pre-installer era.

I would suggest a new module-method to substitute canBeAutoInstalled() called:

isWellBehaved()

A module that adds feature that might be considered "intrusive" (like squarethumb or debug) would tell "false", all others probably will tell "true". With this information the installer can provide a reasonable default on checked checkboxes (keeping the not-well-behaved unchecked at first), but still display them all. This way someone can safely click "Install and activate modules" right away without having to go through the list.

We then can get rid of canBeAutoInstalled(). All our current shipped modules provide a reasonable autoConfigure() and we can simply return false there if we cannot autoConfigure.

I am also tweaking in GalleryCoreApi::fetchPluginStatus to return a better array. Currently all modules that are present on disk return a "installed", which is not really correct. We are not using the "installed" anywhere yet, the Site Admin modules view does a check for installed on its own.

My changes introduce two new array elements to what fetchPluginStatus returns:

'present' = plugin files are present
'installed' = present and installed, and no version conflict (e.g. no need "re-install")
'versionMismatch' = the file on disk has a different version than the one that was last "installed" in this gallery. This could provide a new action at Site admin ("upgrade") or whenever...

Cheers,
Ernesto

PS: delaying phpunits and commiting to saturday/sunday...

mindless

Joined: 2004-01-04
Posts: 8601

Posted: Thu, 2004-10-14 15:58

cool, I like everything above except the name isWellBehaved.. how about isAutoInstallRecommended() ?

btw, when you make these changes please make sure the ReInitializeGallery test case still works..

baschny

Joined: 2003-01-04
Posts: 328

Posted: Thu, 2004-10-14 16:43

mindless, but we are not auto-installing it. The user is still choosing it at install time. My turn:

isRecommendedDuringInstall()

Heh!

mgrant Joined: 2004-08-17 Posts: 100	Posted: Wed, 2004-09-15 18:24
	During the installation on step 8 the following modules are not available to select. Blocks ImageBlock Display Square Thumbnails Import Nokia Image Upload In the interest of being consistent with the "site admin"-> "modules" screen I suggest that these three modules be added to step 8 of the installer. Thanks, -mg
	XUser login Username: * Password: * Create new account Request new password
baschny Joined: 2003-01-04 Posts: 328	Posted: Wed, 2004-09-15 19:18
	mgrant, the modules-list is generated from the modules found with the distribution. A module can state if it "canBeAutoInstalled" and only those are displayed at install-time, as those are able to auto-configure themselves and we can be sure that they work "out-of-the-box". Those three modules are currently marked as not "canBeAutoInstalled". The comment about that for Square Thumbnails is "We could autoinstall, but not everyone wants square thumbnails", I guess the same applies to the other two. If I remember correctly this comes from the time when the installer didn't asked for modules to install, but simply installed everything that was possible using this mechanism. We might consider changing this now, since the user chooses the modules explicitly.

mindless Joined: 2004-01-04 Posts: 8601	Posted: Wed, 2004-09-15 22:32
	Ernst, I think we can change those now... a while back (pre-installer) when you loaded up G2 for the first time it would actually install and activate modules it could auto-install.. that's why I set those to false. But now they will only get switched on if the user checks the checkbox, so that's ok.

mindless Joined: 2004-01-04 Posts: 8601	Posted: Wed, 2004-09-15 23:48
	I set imageblock and squrethumbs to true. Nokiaupload always requires configure so we can't switch that one.... but this brings up a good point: this step of the installer gives the new site administrator their first picture of all the things G2 can do.. shouldn't we give them a more complete picture by listing all the modules? The ones that can't auto-configure can be listed but not available to select, with some note about going to Site Admin after install to configure/activate these modules.

baschny Joined: 2003-01-04 Posts: 328	Posted: Thu, 2004-09-16 06:16
	mindless, I think the "canBeAutoInstalled" module method isn't needed anymore. We could list all modules at install-time, the user selects the ones he wants, we then install those, run autoConfigure and then check if "needsConfiguration". We then display the results "Module xxx has been activated" (in green) and "Modull xxx was installed but still needs configuration" (yellow). "Go to Site Admin to configure those modules" bla bla.. Right?

mindless Joined: 2004-01-04 Posts: 8601	Posted: Thu, 2004-09-16 15:15
	Sounds good to me.

bharat Joined: 2002-05-21 Posts: 7994	Posted: Thu, 2004-09-16 19:54
	That sounds good to me, also.

valiant Joined: 2003-01-04 Posts: 32509	Posted: Thu, 2004-10-14 10:46
	bump note: the " Unable to auto configure the Gd module " in red on the top is too near to the title, which is read too. you can easily overlook it.

mindless Joined: 2004-01-04 Posts: 8601	Posted: Thu, 2004-10-14 15:06
	I agree the error/success messages should be grouped together, not separated by a large block of text as they are now. baschny, can you make a task for this?

baschny Joined: 2003-01-04 Posts: 328	Posted: Thu, 2004-10-14 15:42
	mindless, valiant, as I spoke with valiant about this, I fixed it. Its already in CVS and more intuitive. Installed but not activated modules are (because of needsConfiguration() ) are now properly displayed with a hint to go to Site Admin for further configuration. I just wanted to keep this topic "hot", because there are still other issues, which comes from the GalleryModule-API from a pre-installer era. I would suggest a new module-method to substitute canBeAutoInstalled() called: isWellBehaved() A module that adds feature that might be considered "intrusive" (like squarethumb or debug) would tell "false", all others probably will tell "true". With this information the installer can provide a reasonable default on checked checkboxes (keeping the not-well-behaved unchecked at first), but still display them all. This way someone can safely click "Install and activate modules" right away without having to go through the list. We then can get rid of canBeAutoInstalled(). All our current shipped modules provide a reasonable autoConfigure() and we can simply return false there if we cannot autoConfigure. I am also tweaking in GalleryCoreApi::fetchPluginStatus to return a better array. Currently all modules that are present on disk return a "installed", which is not really correct. We are not using the "installed" anywhere yet, the Site Admin modules view does a check for installed on its own. My changes introduce two new array elements to what fetchPluginStatus returns: 'present' = plugin files are present 'installed' = present and installed, and no version conflict (e.g. no need "re-install") 'versionMismatch' = the file on disk has a different version than the one that was last "installed" in this gallery. This could provide a new action at Site admin ("upgrade") or whenever... Cheers, Ernesto PS: delaying phpunits and commiting to saturday/sunday...

mindless Joined: 2004-01-04 Posts: 8601	Posted: Thu, 2004-10-14 15:58
	cool, I like everything above except the name isWellBehaved.. how about isAutoInstallRecommended() ? btw, when you make these changes please make sure the ReInitializeGallery test case still works..

baschny Joined: 2003-01-04 Posts: 328	Posted: Thu, 2004-10-14 16:43
	mindless, but we are not auto-installing it. The user is still choosing it at install time. My turn: isRecommendedDuringInstall() Heh!

Some modules are missing from the installer step 8

XUser login