[SOLVED] [patch] fix for slideshow bug 1013420

treksler

Joined: 2004-10-18
Posts: 8
Posted: Wed, 2004-10-20 05:03

basically
IN ./modules/slideshow/Slideshow.inc

REPLACE
$this->sizeClasses = array(array(320,240),
array(640,480), array(800,600),
array(1024,768), array(1280,1024)
WITH
$this->sizeClasses = array(array(320,320),
array(640,640), array(800,800),
array(1024,1024), array(1280,1280)

this produces expected results

PS
also see http://gallery.menalto.com/index.php?name=PNphpBB2&file=viewtopic&p=100183&highlight=&sid=bf219c5c826486f0c9b65b7a3920fcf1#100183

AttachmentSize
Slideshow.inc.gz446 bytes
 
baschny
baschny's picture

Joined: 2003-01-04
Posts: 328
Posted: Wed, 2004-10-20 09:16

I like it. I've just commited it to CVS. Which closes that specific bug. Thanks for your help.
 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Wed, 2004-10-20 15:20

baschny, please check the unit test too...
 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2004-10-22 15:00

*bump
 
baschny
baschny's picture

Joined: 2003-01-04
Posts: 328
Posted: Fri, 2004-10-22 17:00

oops, fixed.
 
treksler

Joined: 2004-10-18
Posts: 8
Posted: Sat, 2004-10-23 01:29
mindless wrote:
*bump

Just curious.
What's that mean???
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Mon, 2004-10-25 23:17

treksler, when you post a new reply to a topic, it gets moved back up to the top of the forum. We call that "bumping" a topic. Yuo have to post *something* in the topic, so we sometimes just say the word "bump" to let people know that we're making sure it's still visible.