(#) Top Level Albums, (#) Nested Albums, Total of (###) Phot

dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Wed, 2002-12-11 13:52

I've been searching for like an hour, went through all of this forum ,and I know I saw something like that before but can't find it anymore. I wanted what you see above listed on my main gallery page and on another part of my website. I'm pretty sure I had used a hack before, but overwrote my files in an upgrade.

If anyone knows where this is, can you post the link here? Thanks.

 
rsq2

Joined: 2002-08-15
Posts: 2
Posted: Wed, 2002-12-11 21:05
 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Wed, 2002-12-11 23:53

Ahh, I totally forgot about the sourceforge patches.. almost got me insane. Thanks a bunch

 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Thu, 2002-12-12 00:10

Error, i'm thinking this isn't up to date with 1.3.2.
I'll see if I can go through this manually, but do any of the pros know how to fix this patch?
----------------------------
(Stripping trailing CRs from patch.)
patching file view_album.php
Hunk #1 succeeded at 197 (offset 6 lines).
(Stripping trailing CRs from patch.)
patching file albums.php
Hunk #1 FAILED at 37.
Hunk #2 FAILED at 95.
2 out of 2 hunks FAILED -- saving rejects to file albums.php.rej
(Stripping trailing CRs from patch.)
patching file classes/AlbumDB.php
Hunk #1 succeeded at 116 (offset 4 lines).
-----------------------------

 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Thu, 2002-12-12 00:21

Ok, did it manually and it works
http://www.goombalooza.com/gallery/

I don't really know why the patch didn't work, but it seemed simple enough for me to just follow the +/- . I only // out the - ones just in case I blew it all up

To anyone else using this patch for 1.3.2 (standalone for me), you just need to edit the 3 files listed in the patch by hand...

 
beckett
beckett's picture

Joined: 2002-08-16
Posts: 3474
Posted: Thu, 2002-12-12 00:47

Updated a new patch for v1.3.2:

<!-- BBCode Start --><A HREF="http://sourceforge.net/tracker/index.php?func=detail&amp;atid=307130&amp;aid=652409&amp;group_id=7130" TARGET="_blank">[ 652409 ] v1.3.2: Better desc for #albums and #pic</A><!-- BBCode End -->

 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Thu, 2002-12-12 00:55

cool, got a little time tonight for things huh? :wink:

I'll test it out on my other gallery and let you know what happens

 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Thu, 2002-12-12 01:02

my results from the patch
--------------------
missing header for unified diff at line 3 of patch
patching file view_album.php
Hunk #1 FAILED at 197.
1 out of 1 hunk FAILED -- saving rejects to file view_album.php.rej
patching file albums.php
Hunk #1 succeeded at 38 with fuzz 2.
Hunk #2 FAILED at 97.
1 out of 2 hunks FAILED -- saving rejects to file albums.php.rej
patching file classes/AlbumDB.php
patch unexpectedly ends in middle of line
patch unexpectedly ends in middle of line

question: do I just overwrite my .php files with the .php.orig when it messes up to return to normal?

 
beckett
beckett's picture

Joined: 2002-08-16
Posts: 3474
Posted: Thu, 2002-12-12 01:37

Hmm. Well it only works on a clean install of 1.3.2. It did work for me. Hmm. Oh well. Editing by hand works better anyhow.

Quote:
question: do I just overwrite my .php files with the .php.orig when it messes up to return to normal?

Yep.

Quote:
cool, got a little time tonight for things huh?

Yep. And the recently-uploaded pictures is on my list . :wink:
(not related to this post!)

 
dtdgoomba

Joined: 2002-11-04
Posts: 185
Posted: Thu, 2002-12-12 01:45

Yeah, I'll edit by hand, that's fine for me. I just comment the changes in case I mess up and need to go back so

Cool, and thanks for helping on the other topic, whenever you get a chance

 
vallimar

Joined: 2002-08-15
Posts: 487
Posted: Thu, 2002-12-12 18:46

I have a reworked version of this patch that cleans up a few things included
in my 00 patch at http://sexorcisto.net/gallery-patch/.

 
dodofreak
dodofreak's picture

Joined: 2002-12-09
Posts: 75
Posted: Thu, 2002-12-12 22:27

This looks great!! What are the chances that this patch will be included in gallery1.3.3? :smile:

Thanks!!!

 
vallimar

Joined: 2002-08-15
Posts: 487
Posted: Fri, 2002-12-13 03:07

Oh, and for those that want to see it in action, just peruse through my gallery
at http://sexorcisto.net/gallery/ You can't see the slightly changed admin
options obviously :wink:

 
Warren
Warren's picture

Joined: 2002-07-24
Posts: 794
Posted: Fri, 2002-12-13 03:42
Quote:
Oh, and for those that want to see it in action, just peruse through my gallery
at http://sexorcisto.net/gallery/ You can't see the slightly changed admin
options obviously :wink:

Very nice! :grin:
I did notice one problem; your slideshow displayed the first image then toggled through the rest without displaying anything but the image ticker going. Using the low-tech works great. Going back to the high-tech I see the images then but only due to caching, until I reach where I bailed in the low-tech and it would skip loading images again.

 
pbyjp
pbyjp's picture

Joined: 2002-11-12
Posts: 260
Posted: Mon, 2002-12-23 06:29

The modifs made by hand work perfectly in 1.3.3b5 in my case.
However, would it be possible to make these infos available within sub-albums as well as on the front gallery page?
Paul

 
Elric1966
Elric1966's picture

Joined: 2002-10-13
Posts: 24
Posted: Wed, 2002-12-25 15:05

I REALLY like the way the Albums are displayed on the Goombalooza Photo Gallery where it also lists the sub-albums and their links.

Is that part of this patch code also or is that extra?

ALso - HOW do you apply a .patch file or get into it to try the changes manually, I tried loading it into Wordpad and it looked a bit garbaggy. :/

Thanks!

 
bigTrainG
bigTrainG's picture

Joined: 2002-12-26
Posts: 33
Posted: Thu, 2002-12-26 00:14

<<===Noob here also, would like a walkthrough on how to apply the descupdate.patch

Good job Goombalooza!

headed to da station....

 
vallimar

Joined: 2002-08-15
Posts: 487
Posted: Thu, 2002-12-26 14:58

Thats a gallery feature. I believed it's called 'show tree' or something.
It was a configuration option that is off be default and you probably left
it that way. You can either edit your config.php file or re-run configuration
to enable the option. If you have many many sub-albums, don't bother turning it
on as it only makes things look awful then.

 
juhiblues
juhiblues's picture

Joined: 2002-12-24
Posts: 29
Posted: Thu, 2002-12-26 14:59

how to aplly this patch on v1.3.2 which is already installed

 
pbyjp
pbyjp's picture

Joined: 2002-11-12
Posts: 260
Posted: Thu, 2002-12-26 16:28

I am in my case talking about having the top line of the album page which (after the patch) says smth like: 2 top-level albums (15 total), 543 photos... on the nested albums' 1st lines as well...
You see that only on the front gallery page, and I want it inside every nested album as well.
cheers
Paul

 
bigTrainG
bigTrainG's picture

Joined: 2002-12-26
Posts: 33
Posted: Fri, 2002-12-27 01:25

I am looking for help on how to apply the patch that beckket linked and to make my albumn , subalbs be more descriptive.

Quote:
<!-- BBCode Start --><A HREF="http://sourceforge.net/tracker/index.php?func=detail&amp;atid=307130&amp;aid=652409&amp;group_id=7130" TARGET="_blank">[ 652409 ] v1.3.2: Better desc for #albums and #pic</A><!-- BBCode End -->

How to install and make the changes listed in the update.patch file.
Thanks
BigTrainG

Quote:
dtdgoomba
Ok, did it manually and it works
http://www.goombalooza.com/gallery/

I don't really know why the patch didn't work, but it seemed simple enough for me to just follow the +/- . I only // out the - ones just in case I blew it all up

To anyone else using this patch for 1.3.2 (standalone for me), you just need to edit the 3 files listed in the patch by hand...

:sad: How do I go about editing these files by hand?

 
pbyjp
pbyjp's picture

Joined: 2002-11-12
Posts: 260
Posted: Fri, 2002-12-27 10:21

ok let's see:
here s one part of the patch...:

>>>>>next line gives you file name to edit. in this case: view_album.php
+++ view_album.php Wed Dec 11 19:22:38 2002
>>>>>here 197 gives you the line where you find the line after which to make the modifs.
>>>>>that s providing
@@ -197,13 +197,23 @@
echo "<option value='" . makeGalleryUrl($target, $args) . "'>$label</option>";
}
>>>>>the line above is the line after which you have to start applying the modifs...
>>>>>the lines starting with + have to be added and the ones with - have to go.
>>>>>of course you have to take out the + signs...
+for ($i = 1, $numAlbums = 0; $i <= $numPhotos; ++$i) {
+ if ($gallery->album->isAlbumName($i)) {
+ ++$numAlbums;
+ }
+}
>>>>>this next modif is still in the same file...
$adminText = "<span class="admin">";
-if ($numPhotos == 1) {
- $adminText .= "1 photo in this album";
-} else {
- $adminText .= "$numPhotos items in this album";
- if ($maxPages > 1) {
- $adminText .= " on " . pluralize($maxPages, "page");
- }
+if ($numAlbums) {
+ $adminText .= pluralize($numAlbums, "album", "no");
+}
+if ($numPhotos - $numAlbums) {
+ if ($numAlbums) {
+ $adminText .= " and ";
+ }
+ $adminText .= pluralize($numPhotos - $numAlbums, "photo", "no");
+}
+$adminText .= " in this album";
+if ($maxPages > 1) {
+ $adminText .= " on " . pluralize($maxPages, "page");
}
euh i don t have knowledge of php but managed easily... my explanation is not brilliant but I hope it helps you.
good luck.
Paul

 
dodofreak
dodofreak's picture

Joined: 2002-12-09
Posts: 75
Posted: Fri, 2002-12-27 19:45

As I have posted earlier, I would love to see this officially added to Gallery 1.3.3. It's not a major change, so I would hope that it woud be part of the next official gallery release.

Thanks!!!

 
dodofreak
dodofreak's picture

Joined: 2002-12-09
Posts: 75
Posted: Fri, 2002-12-27 19:47
Quote:
how to aplly this patch on v1.3.2 which is already installed

patch -p0 -b < counters.patch

If you need to, do a man patch to see which -p## you need.

 
dodofreak
dodofreak's picture

Joined: 2002-12-09
Posts: 75
Posted: Tue, 2003-01-07 17:19

Just out of curiosity, but did anyone else download counters.patch?

It looks like the counters.patch is truncated and not complete.
The patch seems to add some new functions and lines of code, and it seems
to work just fine. I wanted to do a sanity check and see if anyone else
agrees.

Anyone has the full version for download?

patch -p0 -b --dry-run < counters.patch
missing header for unified diff at line 3 of patch
patching file `view_album.php'
patching file `albums.php'
patching file `classes/AlbumDB.php'
patch unexpectedly ends in middle of line
patch unexpectedly ends in middle of line

2432 bytes counters.patch

tail counters.patch
+ ++$numAlbums;
+ }
+ }
+ return $numAlbums;
+ }
+
function numPhotos($user) {
$numPhotos = 0;
foreach ($this->albumList as $album) {

Thanks in advance.

 
bobob

Joined: 2003-07-12
Posts: 110
Posted: Thu, 2003-08-07 16:07

did anybody get this working for Gallery 1.3.4.?