Paypal checkout module (it's done!)

turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Fri, 2005-07-01 23:34

*** UPDATED ***
Took down the module files from this post as they are no longer supported. See the most recent versions here to work with Beta 4

*** UPDATED ***
14/7/05 Added notes on CVS versions to this post (added them to the other one, forgot to update this one!)
*** UPDATED ***
5/7/05 Fixed the bugs listed in posts on page 13 of this thread
*** UPDATED ***
4/7/05 Fixed the bugs listed in posts on page 12 of this thread
***

Another release of the modules for you all to play with. Changes this time round include:

  • Fixed most of the unassigned variables issues, so the number of PHP warnings should drop. I know there are more in there, but they're hard to tie down!
  • Moved PayPal specific information into its own persistent storage rather than wedging it into the core module's tables.
  • Extended the core module's schema to allow more delivery information to be captured (full address, etc). This is leading to the admin view soon...
  • Updated the Email module to insert the delivery information into the checkout transaction record.
  • Made the checkout module stand alone without the Gallery 'cart' for various reasons, but mainly to do with making it possible to bring in some new features in the future. The first such feature is already here:
  • Added a Gallery permission to enable/disable the use of the Checkout module on a per-item/per-user basis. Simply grant or revoke '[checkout] Purchase item' as required.

Because of the terminology in Checkout's cart - particularly the use of the phrase 'add to cart' in the item actions - I'd recommend not using this module at the same time as having Gallery's cart installed. I'm planning on working this issue out in coming releases, but I'm not quite sure how just yet.

UPDATE - important note on CVS versions:
There are indications that these modules will not work with some of the more recent CVS releases. I'd suggest downloading the 1st July release, as that is the one I tested against. Have a read of the CVS instructions here for an overview, but use the following command to actually check out the module:
cvs -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/gallery checkout -D 7/1/2005 -P gallery2

These versions will not work with Beta 3 (or any earlier beta) - they require a CVS version of Gallery 2 to install and function.[/]

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Fri, 2005-07-01 23:35

And the readme file (didn't realise there was a 3 file limit per post)

 
drhiii

Joined: 2003-04-27
Posts: 397
Posted: Sat, 2005-07-02 01:14

Very glad, that you are working on this. I made myself keep my trap shut recently because I did post a healthy feature wishlist a week ago. But I cannot contain myself when a new build shows up. I am stunned to see a 'item selectable' ability in this release. Man, is this cool or what....

Will tell ya why... I have given a glimpse of G2 to a couple of museums and collections. There are non-tech members, almost all beyond retired age. They have gone nuts over it. One local mom & pop museum has a collection of 30,000 images sitting in cold storage doing little to nothing. They like most museums at this level have little money to do anything so I donate my time to help them with their web presence. It is a grind. I teased G2 out a little, and they saw the commerce modules you have created, and they went nuts. They got it. They saw a purpose in learning how to scan images and place them on a web presence whereas before, they did not see see why they needed to do this because scanning had a cul-de-sac outcome. I mean, they *saw* it. One gent, into his 80s, and as low tech as they come, said he would learn how to accomplish this because of what he saw. He loves his collection, wants to present it, but wants nothing to do with the internet because it just gets placed out there and it's gone. When he saw G2, watermarking, the administration, and your commerce mods, well..... he reacted.

This stuff really matters because it can provide a minimal revenue possibility to these mom and pop museums, and I know many of them because it is an area of interest to me. And because they are nonprofits, run by volunteers, something has to be really obvious and compelling to get a museum culture interested. I cannot express to you Mr. Turnbulm the life I have seen this breath into ideas from just a couple of these people who have content always "doing nothing", and then they see the pieces that come together to place them online easily, protect them, all things that this fantastic G2 is providing... and then addyour great mods, and it breathes life into ideas. This is in my opinion, very cool.

I move slow on this stuff because I know developments must take place and the last thing anyone needs is to get ahead on themselves... but G2, and your mods breathe life into an unknown tunnel for some of these non profits and that can have a remarkable impact. You need to know that this does matter... and is very much appreciated.

Plus, the logic and elegance of your mods are spot on tops too.... it is pretty cool to see some very smart people do some very smart things like this.

I may get bold enough to float another feature request. But for now, I am just extremely grateful and sit quietly, because there is light at the end of a couple of museum tunnels, to surface otherwise unseen content, and that is bonus.

drhiii

turnbulm wrote:
drhiii- it's actually quite enjoyable when I get a chance to work on this. And, having worked something like 50 hours in the last 4 days, I get to take a day off tomorrow!! Which means a whole day of coding!

Here's hoping I can get a release out to fix the unassigned variables issue...

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Sat, 2005-07-02 08:08

Hmm, something is strange with the latest version. I suddenly have two "add photo to cart" lines in my image menue, one bringing me to the new purchase checkout (the first one), one to the 'old', classical checkout (the second one).
Additionally, the two are not aligned with the cart entry appearing on the sidebar. Going the 'buy' route, the sidebar still shows an empty 'cart' - but the purchase can be completed.
Using the classical checkout and selecting the cart action 'purchase photo' ends in a 'your cart is currently empty'. (Selecting the other actions works).

???

(even after clearing the template cache)

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sat, 2005-07-02 08:23

LFrank- this new version no longer needs the classic 'cart' module as it creates its own 'add to cart' links for items. I'd suggest you disable the cart module to see how this version was intended to look!

The main reason for doing this was to improve the workflow by taking control of all the steps the user sees. It mainly means that I can start to add some more features because I can now make decisions per-item before they are even added to the cart. The first example of this is the new permission I mentioned above.

I am thinking of how to make the Checkout and Cart modules sit together more nicely side-by-side, but I haven't quite cracked it yet. I'm also working on the assumption that people who sell using 'checkout' probably aren't also going to have Shutterfly etc also enabled at the same time - that would defeat the object of the checkout module.

Anyhow, deactivate the classic cart and have a look.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sat, 2005-07-02 08:26
drhiii wrote:
I made myself keep my trap shut recently because I did post a healthy feature wishlist a week ago. But I cannot contain myself when a new build shows up. I am stunned to see a 'item selectable' ability in this release.

Glad you like it :) Turns out that the permission thing wasn't that hard to do once I'd made the module standalone. All down to the amazing way G2 is put together!

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Sat, 2005-07-02 16:25

turnbulm,

Quote:
I am thinking of how to make the Checkout and Cart modules sit together more nicely side-by-side, but I haven't quite cracked it yet. I'm also working on the assumption that people who sell using 'checkout' probably aren't also going to have Shutterfly etc also enabled at the same time - that would defeat the object of the checkout module.

I agree for the Shutterfly - but disagree i.e. for the ZIP download which depends on the cart aswell. (And could be usefull to allow customers to download resized items before buying the 'real' thing).

Nevertheless - after deactivation of the old card I still see an issue regarding the template which somehow doesn't fit my Matrix style of my site (and my bloody thumb issue (which I could live - deactivating the thumbs)).

CU & Thanks for all your efforts

Lutz

 
drhiii

Joined: 2003-04-27
Posts: 397
Posted: Sat, 2005-07-02 16:43

Well, I like this very, very much. The combination of things, including your great work on the modules, have wonderful application towards these non-profit museums and collections. It gives them a purpose whereas before in my conversations with them, they just didn't have enough incentive to go out and get some hefty digital management engine. I can't tell you how promising your work is for these types of people who are left in the dust so to speak... hence my gushing. It really can make a big diff....

And am following the permissions exchange here too. I am hoping that the powers that be for G2 will apply a more granular permissions schema, so that turning off things like Shutterfly and the Zip download can also be applied to a per album and per item basis too. But you are solving that from your end as well. Man, is that cool or what?!?

Great job all around.

Glad you like it :) Turns out that the permission thing wasn't that hard to do once I'd made the module standalone. All down to the amazing way G2 is put together!

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sat, 2005-07-02 17:06

LFrank- I just realised one thing I missed in the upgrade routine, which was to unregister my cart plugin handler. That's not critical if you're not going to be using the cart as well, but if you are then it will mean that the 'purchase photos' link is still there but inoperative. The only way around that with the current version is to uninstall then reinstall the checkout module

Good point about the Zip Download plugin - I'll think about what could be done about that.

However, back to your issue. Please can you describe the problem you are seeing in a bit more detail for me, as I'm not sure I understand exactly what you are seeing?

 
drhiii

Joined: 2003-04-27
Posts: 397
Posted: Sat, 2005-07-02 17:19

The Zip download module is an interesting thing. Allowing people to acquire downsized, non printable images is interesting, but that would mean downsized images and not originals. Right now, this zips the highest res version of an image I believe. But I think this does have some pretty cool ramifications if it can be utilized towards a sized, and possibly watermarked image for downloading. Interesting possibility here....

turnbulm wrote:
LFrank- I just realised one thing I missed in the upgrade routine, which was to unregister my cart plugin handler. That's not critical if you're not going to be using the cart as well, but if you are then it will mean that the 'purchase photos' link is still there but inoperative. The only way around that with the current version is to uninstall then reinstall the checkout module

Good point about the Zip Download plugin - I'll think about what could be done about that.

However, back to your issue. Please can you describe the problem you are seeing in a bit more detail for me, as I'm not sure I understand exactly what you are seeing?

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sat, 2005-07-02 18:25

drhiii- I think the zip download actually gives you the highest resolution image you have permission to view - not necessarily the highest resolution there is. At least I hope it does...

All- Right now I need to have a good think about how to deal with this duality of the Cart and Checkout modules both providing a shopping cart. The reasons for changing the Checkout module to have cart funcitonality were:

  • Eliminates the 'null' first step of the previous cart, where users were invited to set quantities and so on before going to 'purchase photos' - but then there was no way for us to use those quantities because we had no idea what products to apply them to.
  • I had many users comment that finding the 'purchase photos' link was hard until they knew where to look - it certainly wasn't intuitive.
  • We can now make informed decisions about whether or not to allow a user to put an item in the cart. Take the example of pictureshow's problem earlier - he was trying to offer movie downloads using the PayPal module. Of course the Cart module allows movies to be added, but the PayPal module only accepted photos. So from the user's perspective they added a movie to their cart, and it appeared in there just fine. As soon as they went to 'purchase photos' the movie got removed. This was an example of logic being applied as early as was possible technically, but still too late to help the user experience.

But now of course, we have the problem of two shopping carts in G2 - which is even worse for the user experience. I started to think of a few ideas on how to handle this:

  • Reproduce the 'cart' plugin interface in 'checkout' so that the original cart modules would be able to plug in to our checkout easily. On the down side, this would require changes to those plugins (registering with the right module - cart or checkout) and it still leaves some elements of user experience that I don't like (particularly the fact that product selection doesn't apply to the cart plugins, but that is our first page).
  • Make it admin selectable to have checkout operate its own cart, or to plug in to the existing G2 one. This works just fine, and lets people choose their own logic, but it does mean that the newer features just aren't going to be available to those people who choose to plug in to the existing cart (permissions, for example)
  • Accept the fact that it will be hard to make these two work together, and stop trying to support the old cart. We could probably port any plugins across to checkout as payment processors - maybe the zip download, for example - but I don't see them sitting too well in the user experience (you select products, see prices, then complete your transaction by donwloading the JPEGs?)

I have to confess I am at a bit of a loss here - so this post is to see if any of you out there have any further ideas, or any preferences on how I go forward?[/]

[/]

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Sat, 2005-07-02 19:47
Quote:
drhiii - I think the zip download actually gives you the highest resolution image you have permission to view - not necessarily the highest resolution there is. At least I hope it does...

exactly this way - only the highest granted size is 'packed'.

I'll prepare some screenshots - I apologize for a delay - I'm currently to much live8 infected ;)

CU
Lutz

 
highpulse
highpulse's picture

Joined: 2004-05-15
Posts: 45
Posted: Sun, 2005-07-03 00:20

Well, I have been trying out the latest and greatest module upgrade! Thanks turnbulm, for the hard work you are doing and the email module is a great addition.

Now for my problem;

I cleaned out my database cache and template cache and deleted the old module folder. I installed the new folders and when I looked at them in the "Modules" in the "Admin Options, I get the following notice.

! Checkout 0.1.6 Shopping cart module supporting different products and payment
Incompatible module!
Core API Required: 6.3 (available: 5.8 )
Module API Required: 1.0 (available: 0.11)

! Checkout by Email 0.0.3 Complete checkout by email
Incompatible module!
Core API Required: 6.3 (available: 5.8 )
Module API Required: 1.0 (available: 0.11)

! Checkout by PayPal 0.1.3 Complete checkout by PayPal
Incompatible module!
Core API Required: 6.3 (available: 5.8 )
Module API Required: 1.0 (available: 0.11)

I uninstall and reinstalled the checkout module and I get the same thing. I deleted everything in my G2 site and downloaded and installed G2 all over again. Same exact problem. I did many searches in G2 forum and had no luck. I give up and have to ask for help. I am not very PHP literate, but I am learning.

Thanks for your help!

Gallery version = 2.0-beta-3 core 0.9.17
PHP version = 4.3.10 cgi
Webserver = Apache/1.3.29 (Unix)
Database = mysql 4.0.24-standard-log
Toolkits = ArchiveUpload, Exif, Gd, NetPBM, Thumbnail
Operating system = Linux infong 2.4 #1 SMP Mon Aug 9 10:21:08 CEST 2004 i686 unknown
Browser = Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8 ) Gecko/20050511 Firefox/1.0.4

 
littletechgirl
littletechgirl's picture

Joined: 2005-03-15
Posts: 53
Posted: Sun, 2005-07-03 02:52

The latest module is great. It just keeps getting better. I have a couple of requests.

1. The rest of my site (non-gallery) currently uses a Paypal shopping cart to purchase some other products besides photos. Would it be at all possible to merge the 2? To pass the contents of the gallery cart out to the other cart, so visitors could complete a mixed purchase?

2. The permissions addition starts my next request. Would it be possible to set different prices for different albums, or different logins? I think someone requested that before.

3. I would like to be able to set a "package" for a specific user, and then have them be able to go in and select the pictures in their package to send to the email module. The module would have to know when they reached their "limit" so to speak. A maybe simple work around for this because it seems like it would be a lot of coding would be maybe to display a different album page, or cart page (I am not sure which yet) when a certain user logs in. There would be a table or a few lines at the top of the page reminding them of the package that they chose, and how many pics they need to choose. It would then be up to them to keep track.

Thanks again for all of your hard work. I have put the last version in production as of earlier today!

Kris

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sun, 2005-07-03 06:42

highpulse- it looks like you're running Beta 3, and this module needs a CVS version to run. That's because mindless modified the email functions for me so we can send HTML emails, and that mod didn't happen until after Beta 3 was released.

If you'd like to try this version of the module, I'd suggest having a read of the CVS instructions.

littletechgirl- If you wanted to merge your two carts, the best way to do it would be to create a payment plugin to the checkout module that passes the cart contents to your other cart. I don't think there's going to be an easier way than that. Does your other cart have a suitable interface so that it can be populated en-masse?

Different prices are something I am planning on working in - and this module is the first step in that direction. I don't think it's going to be that easy so please bear with me, but it is on the list.

Packages are going to be a bit tricky to do neatly. The only way I can think of at the moment is based on price lists. One of the features I want to put in price lists is quantity discounting - the price of a product will change depending on how many are ordered. You could then create a price list for the package where the price for (say) 1-8 of a product is 0, then from 9 upwards there's a real price. That way a user can add up to 8 of that item at no cost.

 
fryfrog

Joined: 2002-10-30
Posts: 3236
Posted: Sun, 2005-07-03 07:59

I saw a suggestion somewhere that might make another good sub-plugin. Instead of emailing the cart to the admin or doing the checkout through paypal (or both?), it would be neat if you could at the end offer the selected files for download. I have your modules, but i haven't started playing with them yet... so maybe thats what one of them does?

I realize that the current cart module DOES this already, but it doesn't really have any method of payment. I think that would be the main goal, so I guess after submitting payment details to paypal or something it could just throw the stuff in the normal cart maybe?

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sun, 2005-07-03 11:52

fryfrog- that kind of fits in with a couple of comments earlier. At the moment, these modules do two of the three stages of purchase: Selection, and Payment. We don't (yet) touch the third - Fulfillment.

I am however thinking about how we could go about the fulfillment end. With the PayPal module we have IPN integrated, so we can tell when a transaction has been properly paid - and then use that to trigger the third phase. For the Email module that would have to be an admin action, but it would just be as simple as marking the transaction 'paid' in the admin interface (coming soon...)

One thing I will have to do before we can get to the third phase is store the complete order details in the database. The fulfillment modules will need that information to function. That should be pretty easy though, and it's something I was going to do to make the admin interface to transactions look better anyway.

Once that's done then I guess the best thing would be to create a fulfillment element to the checkout module. This would register an event listener to be informed of when transactions are paid, and would then run through the items line-by-line and hand them off to the appropriate fulfillment plugins (maybe 3 lines in an order were for download, and another 2 were for prints, for example). I'll have a think about the plugin interface for that.

I think the 'zip download' would be a great first plugin to create... but I think it may be a little way in the future just now ;)

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Sun, 2005-07-03 13:57

turnbulm,

Quote:
However, back to your issue. Please can you describe the problem you are seeing in a bit more detail for me, as I'm not sure I understand exactly what you are seeing?

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Sun, 2005-07-03 14:10

Whoa :o That's strange... I definitely haven't seen that happen before :-?

Please can you try flushing your template cache, and if that doesn't work maybe uninstall and reinstall the Checkout module?

 
highpulse
highpulse's picture

Joined: 2004-05-15
Posts: 45
Posted: Sun, 2005-07-03 17:33

turnbulm,

You were right on! I thought I had the latest build and didn't understand the CVS thingy. Like I said before, live and learn.

So I installed the "latest" G2 version and updated the install. Activated the modules, configured, and did limited testing of the email module, all works great!

Things are looking great!

Thanks for your great efforts!

G2 world loves you!

 
highpulse
highpulse's picture

Joined: 2004-05-15
Posts: 45
Posted: Sun, 2005-07-03 23:06

Been testing the checkout module some more and noticed that there are a couple of things that I feel need to be added.

1. After adding a picture to the cart, there is no button to "Update and Continue Shopping". When I add the quantity of each size, for it to take hold, I needed to click on the "Continue to checkout" for it to take hold. Then I can go back to photo to continue to look.

2. There is the box to check a photo to remove in the cart, but there is no button to "Remove Selected".

The modules are working great so far and loving it.

 
apadley

Joined: 2002-11-30
Posts: 8
Posted: Mon, 2005-07-04 01:10

I have been testing the new modules over the last 2 days as time permits. I absolutely love them and thank you for all your hard work. Here are some of the things I noticed:

1. In Step 1 using the drop down - When you select a paper type and click "Save Changes" the paper type is NOT saved. If you click "Continue to checkout" it IS saved.

2. With different sizes available from Select drop down, select anything but the first available size and the Product/Price/Quantity does not carry forward to Step 2. This doesn't seem to be an issue with the table design.

3. Same as #2, but select 2 or more different sizes and none of the Product/Price/Quantity info is carried forward to Step 2. However, if one of the items selected is the first item in the Select, then all items are carried forward to Step 2. This doesn't seem to be an issue with the table design.

4. If I select an item and add it to the cart and continue shopping and add the same item to the cart a second time, all the previous quantities and paper type is lost. See #5 for why this could be important.

5. You can only select one paper type for an item. You should be able to choose different paper types for each size. You should also be able to order the same size in more than one paper type.

6. In the table design, there is only one button "Continue to checkout". This is confusing. There should be at least another option to continue shopping. (This was mentioned by highpulse also.)

7. There needs to be a provision for Sales Tax especially when using the Email module. PayPal can be setup to automatically add the appropriate sales tax, but an overall solution is needed.

8. In the United States, "Postage and Packing" is typically called "Postage and Handling". Perhaps this should be an option.

9. In the Email module, the Order Complete page indicates that confirmation details will be emailed to the address provided. No such email confirmation is ever sent to the customer.

10. When returning from the PayPal Sandbox, I receive "An error has occurred. Here is the Error Detail:

Error (ERROR_BAD_PATH) :
• in modules/core/classes/GalleryUtilities.class at line 498 (gallerystatus::error)
• in modules/core/classes/helpers/GalleryPluginHelper_simple.class at line 74 (galleryutilities::requireonce)
• in modules/core/classes/helpers/GalleryPluginHelper_simple.class at line 90 (gallerypluginhelper_simple::loadplugin)
• in modules/core/classes/GalleryCoreApi.class at line 187 (gallerypluginhelper_simple::loadplugin)
• in modules/core/classes/GalleryView.class at line 129 (gallerycoreapi::loadplugin)
• in main.php at line 282 (galleryview::loadview)
• in main.php at line 87
• in main.php at line 78

I'm using the July 1 build.

Also, the cart has not been emptied upon return from PayPal Sandbox.

Thanks again.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 06:38

Wow - some excellent feedback - thanks very much! I'll work on these today and have a bug fix release out later on.

Regarding some of your points, apadley:

5 - This is a limitation of the module, and I can't see a nice way to handle multiple paper types in the UI. I had the same requirement for my site, so I turned off paper type and just created the combinations in the product list (eg 6x4 Gloss, 6x4 Matt, etc).

7 - Sales tax is something I'm planning on introducing in a later build, but at the moment I'm just starting to re-work the basis of the module to support it. If it turns out that I get this done then I'll add it in soon, but I need to get all the bugs fixed now before I introduce new features.

9 - The customer will receive a confirmation only if you specify 'customer@gallery' as one of the recipients in the email configuration page. I guess I need to make that text configurable so the site admin can say something appropriate.

 
apadley

Joined: 2002-11-30
Posts: 8
Posted: Mon, 2005-07-04 12:49

I'll be out all day, but will test further when I get in this evening. Thanks for the insight into # 5, 7 & 9. Looking forward to the next release.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 13:47

As promised, bugs are now (hopefully!) fixed. I've uploaded new versions into my post on the previous page (see here).

Sorry for the problems, and hopefully this will now sort them out. Please let me know if you find any more and I'll get them fixed.

I'd strongly recommend anyone running version 0.1.6 of the Checkout module, or version 0.1.3 of the PayPal plugin, to upgrade to these fixed versions as soon as possible.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 14:04

LFrank- I found the problem that was causing your strange layout. It appears to only have started happening since some CSS changes were made in a recent CVS. I've changed the templates slightly and the problem has gone away for me - please can you download the updated modules and let me know if it is still a problem for you?

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Mon, 2005-07-04 14:44

turnbulm,

Quote:
I found the problem that was causing your strange layout. It appears to only have started happening since some CSS changes were made in a recent CVS

I've tried to clear a lot of caches this morning ... not very succesfull... ;)

The new templates fix the CSS issue on Step1 of the checkout, slightly improve it on Step2 - but does not affect the last steps, 'Customer Details' and 'Order Complete'. Could there be a chance that you didn't touch those yet? Clearing caches doesn't help.

Thanks,
Lutz

Btw, my workaround for the two carts - I renamed the "add %s to cart" to "add %s to purchase" ;)

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 16:33

LFrank- ooops... I finished making the changes then forgot to update my module packages before I uploaded them :oops:

Try again now - I think I got all instances of the problem, but let me know if I missed any.

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Mon, 2005-07-04 17:11

turnbulm, hey - you've become 'Artiste' ... sigh :) (I'm still 'Adept')

serious - you've got it - the updated modules fixed the issue on step 2, customer details and confirmation still looks 'strange'

CU Lutz

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 17:17

LFrank- cool, I hadn't noticed I'd got promoted! Yet another case of quantity over quality...

I checked my install and all the pages look fine - did you update all 3 modules or just the 'checkout' one? The customer details and confirmation pages come from the 'email checkout' module, and there's also the 'Payment complete' page in the PayPal module that had the problem as well.

 
littletechgirl
littletechgirl's picture

Joined: 2005-03-15
Posts: 53
Posted: Mon, 2005-07-04 19:54

I installed the latest updates and the paper selection disappeared! See pic.

Also, is it possible to put an Empty Cart button? That was a little useful if only for testing from the cart module.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 21:02

I have no problems if I set some papers in the admin page - please can you let me know what you have set so I can see if I can reproduce the problem?

(Also, just checking you have re-downloaded the modules within the last half-day to fix all the bugs I let in...)

Rather than an 'empty basket' button, how about a 'check all' option above the remove column? I'm just not keen on putting another button down there in the user's main area of focus for an action that's probably not going to be that well utilised.

 
highpulse
highpulse's picture

Joined: 2004-05-15
Posts: 45
Posted: Mon, 2005-07-04 21:30

I updated the modules again and you took care of both of my requests with the one button. Great job!

I am going to try some more testing and let you know if I see anything else.

I compliment you on your programming skills.

Your patience too...

Thanks!

 
littletechgirl
littletechgirl's picture

Joined: 2005-03-15
Posts: 53
Posted: Mon, 2005-07-04 22:01

Check all and remove sounds good. I do have the latest installed, I just grabbed it earlier today. I was able to fix the paper problem by just adding a third type and then savings.

Thanks again for all of your hard work!

turnbulm wrote:
I have no problems if I set some papers in the admin page - please can you let me know what you have set so I can see if I can reproduce the problem?

(Also, just checking you have re-downloaded the modules within the last half-day to fix all the bugs I let in...)

Rather than an 'empty basket' button, how about a 'check all' option above the remove column? I'm just not keen on putting another button down there in the user's main area of focus for an action that's probably not going to be that well utilised.

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Mon, 2005-07-04 22:39

littletechgirl- you shouldn't need three papers set to make this work - in the screenshot above I only have two. If you delete the third does the problem come back? If not then it points to something in the upgrade not having worked properly. If it does come back then there is a bug in the current module that I'd like to track down and fix.

 
apadley

Joined: 2002-11-30
Posts: 8
Posted: Tue, 2005-07-05 03:58

The newest fixes seem to have addressed or explained 9 of the 10 items on my previous list. I haven't tested # 10, yet. However, I did discover another issue.

11. If I order 2 or more different sizes of a single item, the Email Order only lists the first size (although the subtotal and total amount due are correct). Using PayPal tracks this information correctly.

Overall, I am very pleased. The modules are useable as is. That means they will only get better as new features are added.

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 05:05

turnbulm,

Quote:
I checked my install and all the pages look fine - did you update all 3 modules or just the 'checkout' one? The customer details and confirmation pages come from the 'email checkout' module, and there's also the 'Payment complete' page in the PayPal module that had the problem as well.

'mea maxima culpa' - I've missed to update the e-mail module (only seeing the same version number...)

Thanks
Lutz

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Tue, 2005-07-05 09:25

apadley- thanks for pointing that out. I'd forgotten to fix the email template when I did the rest of them. I've done it now, and the fixed version is in the files on page 11 (still at v0.0.3).

I've also fixed an issue in the Email checkout module where links to the original images were always included regardless of the admin setting.

LFrank- I should have said I didn't increment the version, sorry. Glad it works now though. BTW - are you still seeing the issue with thumbnails in your email messages?

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 10:07
turnbulm wrote:
LFrank- I should have said I didn't increment the version, sorry. Glad it works now though. BTW - are you still seeing the issue with thumbnails in your email messages?

can't tell yet - the core upgrade .27->.28 triggered by the latest CVS killed my server - the upgrade step always times out, I'm currently trying to roll-back to a snapshot archive from July 3rd.

(Sometimes, using CVS can be a real headache)

CU (hopefully soon again)
Lutz

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Tue, 2005-07-05 10:26

LFrank- I have a degree of paranoia about CVS upgrades. I run the following script immediately before I do 'cvs update':

#!/bin/bash
/bin/tar cvfz /tmp/g2_backup.tgz /var/www/wwwroot/gallery /var/www/g2data
/usr/bin/mysqldump -u root -p --opt gallery2 > /tmp/g2_backup.sql

That way if everything goes bad I can just untar to get back to the point in time before the problem hit. I know it's not much help to you now, but maybe it'll save you the same problems some time in the future!

Matt.

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 12:26

turnbulm, looks like a good idea :)
will take that as a future pre-cautional step into my workflow
CU
Lutz

 
fatface

Joined: 2005-07-05
Posts: 2
Posted: Tue, 2005-07-05 16:09

Firstly, absolutly great work on this...first class.

Ive got it all working very nicely but there is one thing that is really baffling me. Im not very experienced in this so im hoping someone will be able to point something out very easy for me.

For some reason, the Add to Cart option doesnt appear unless the user is logged in. Is this a feature? cos i need it to be there all the time for guests too. Have i missed something?

 
littletechgirl
littletechgirl's picture

Joined: 2005-03-15
Posts: 53
Posted: Tue, 2005-07-05 16:11

turnbulm, that photo you posted is funny to me. My maiden name is "Hester". HA.

Removing that third option and saving the paper types, it still works correctly, so I guess like you said, something just did not take.

I still need to do more checking into merging or passing that data from one paypal shopping cart to the other like I asked a couple of pages back. Currently I just use the plain old paypal cart by putting "Add to Cart" buttons on my site, nothing special.

I would just like to pass the data from this gallery one to that, maybe not even all the data, that can submit like it already does, but maybe just the total of that order?? not really sure yet.

Thanks!

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 16:12

fatface, the new version allows to assign the permission to purchase. You need to add a "Everybody" "Purchase" permission to your album to allow this option to appear.
CU
Lutz

 
fatface

Joined: 2005-07-05
Posts: 2
Posted: Tue, 2005-07-05 16:27

Thanks LFrank, worked a treat.

Many thanks for the prompt comeback.

cheers

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 16:39

fatface, your welcome :)

turnbulm, still having my e-mail thumb issue.
The link http://localmail.dynip.com/GALLERY2/d/51241-1/CIMG0007.JPG?g2_navId=x0bbe752b as sent by the mail gives a

Quote:
You are not authorized to view this page
You might not have permission to view this directory or page using the credentials you supplied.

- removing the g2_navId, resulting in http://localmail.dynip.com/GALLERY2/d/51241-1/CIMG0007.JPG displays the thumb :(

Still no idea what's going on, short URL don't seem to be the cause...
Is there a possibillity to locally hack the module to remove the navId within the generation of the url? (Just to test?!)

Lutz

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 17:26

hmm, just thinking loud - could my permission error be caused by my Apache?
I store the images on a different drive - not known by Apache per default. Could that be a reason??

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Tue, 2005-07-05 17:35

LFrank, I can't get over the feeling that there is something going on in Apache before it gets to the Gallery PHP. I tried browsing to both those links you enclosed, and they both came back with http error 403 'You don't have permission to access /GALLERY2/main.php on this server.'

Do you have any .htaccess files or similar entries in httpd.conf?

 
LFrank

Joined: 2005-02-19
Posts: 1023
Posted: Tue, 2005-07-05 17:54
turnbulm wrote:
LFrank, I can't get over the feeling that there is something going on in Apache before it gets to the Gallery PHP. I tried browsing to both those links you enclosed, and they both came back with http error 403 'You don't have permission to access /GALLERY2/main.php on this server.'

Do you have any .htaccess files or similar entries in httpd.conf?

Only the standard - and only the .htaccess created by the short URL thing. I've removed it and disabled short URL completely - and guess what, the thumbs appear.
You're my hero ... testing now what happened to that .htaccess created...

Re-enabling Short-URL - and recreating the .htaccess file - still lets the thumbs appear. I assume something was wrong with my htaccess (btw. even the links above seem to work now)

Lutz

 
turnbulm

Joined: 2004-10-03
Posts: 431
Posted: Tue, 2005-07-05 18:03

LFrank- can I suggest you start a thread about this separately, as it appears there may be some kind of problem associated with the Short URL module? I use the standard g->url constructor in the template, so I would expect any interaction with sort URLs to have been handled by then.

I doubt this will be high on the G2 core team's agenda as I know they are all really busy at the moment, but then again it might be something that someone can answer easily. I'd also be interested if the answer says there is a better way of generating the URLs than the way I am doing it.