Simple image frame code?

stoffer
stoffer's picture

Joined: 2005-02-10
Posts: 75
Posted: Wed, 2005-03-30 08:10

In my on-going effort to customize my G2 install, I want to apply a simple white border around my pictures. In simple CSS something like this:

<style type="text/css">
p
{
border-style: solid;
border-color: white;
border-width: 8px
}
</style>

I have looked at the imageframe module, but couldn't find the 'solid frame' in order to modify it. I would prefer simple code (instead of .gif) so the pages load faster.

Is there anywhere I could paste in this code?
 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Wed, 2005-03-30 15:58

"dots" is an example of a css imageframe.. copy that one ("solid" is in the code..)
 
stoffer
stoffer's picture

Joined: 2005-02-10
Posts: 75
Posted: Wed, 2005-03-30 16:18
mindless wrote:
"dots" is an example of a css imageframe.. copy that one ("solid" is in the code..)

Thanks. It worked like a charm! G2 is indeed pretty awesome for customization... :)
 
nzseriocomic
nzseriocomic's picture

Joined: 2004-07-20
Posts: 15
Posted: Sun, 2005-04-03 23:34
mindless wrote:
... ("solid" is in the code..)...

which is a) stupid and b)annoying.
 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Mon, 2005-04-04 00:19

gee, thanks.
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Mon, 2005-04-04 04:51
nzseriocomic wrote:
which is a) stupid and b)annoying.

Mm. Ya gotta love gracious users.

nzseriocomic, please fix the problem and submit a patch. Thank you.

-Bharat
 
nzseriocomic
nzseriocomic's picture

Joined: 2004-07-20
Posts: 15
Posted: Mon, 2005-04-04 22:16

Um, firstly sorry. No excuse for the rude remarks other than frustration over spending several hours trying to find the code, then work out a way to fix it.

It does get to me however, when presented with this opportunity to redesign G2 that only partial effort is given to true seperation of style from content. In saying that, it's easy for me to say such things when I don't have to worry over millions of lines of other more important code.

I love G2 and really appreciate the work you developers do - so I retract the "stupid" comment (and will for now leave the "annoying" one in).

I shall start looking into fixing this rather than criticising it.
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Tue, 2005-04-05 03:25
nzseriocomic wrote:
It does get to me however, when presented with this opportunity to redesign G2 that only partial effort is given to true seperation of style from content. In saying that, it's easy for me to say such things when I don't have to worry over millions of lines of other more important code.

I can appreciate that you're frustrated (and apology accepted).

We do our best to separate code from content. However, we don't have much of a user interface team and it's been very hard to make a modular application with good separation of style and content. If you have any ideas on how to improve that, we'll gladly listen.
 
astralbaby

Joined: 2003-12-13
Posts: 35
Posted: Wed, 2005-04-20 02:49
mindless wrote:
"dots" is an example of a css imageframe.. copy that one ("solid" is in the code..)

excuse me.. but where in the code? is it hardcoded? if so.. where? I already looked in the template files...
 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Wed, 2005-04-20 03:51

# grep -rl solid modules/imageframe
modules/imageframe/classes/ImageFrameImpl.class
modules/imageframe/frames/README.html
 
sjlim

Joined: 2005-10-21
Posts: 4
Posted: Fri, 2005-10-21 13:49

'style' => 'border: 1px dashed black !important; padding:3px !important'

Sorry.. I am new.. how do I make the white border using the dots code exactly please? I am lost..
 
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 16504
Posted: Fri, 2005-10-21 13:57

Try changing black to white, if you don't want it to be dots, remove the dashed part. I'm no CSS guru though :)
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
 
saul11

Joined: 2005-10-04
Posts: 109
Posted: Tue, 2005-12-06 21:35

This works fine for IE, but in firefox the border 'pushes the image of the gallery plane' - I've posted this in a thread handling about the same. I don't want to be cross-posting here so I'll just link the this thread: http://gallery.menalto.com/node/31076
Thanks for any help!
 
schrecklich

Joined: 2008-01-03
Posts: 57
Posted: Sat, 2008-01-05 14:57

Can i give solid also other colors? Or is it just black and white?
 
nivekiam
nivekiam's picture

Joined: 2002-12-10
Posts: 16504
Posted: Sat, 2008-01-05 17:17

Yes, just put in a different color, like red or blue or use any other color code that's valid just search google for 'html color code' or 'css color code' and you should find the information you're looking for.
____________________________________________
Like Gallery? Like the support? Donate now!!! See G2 live here
 
schrecklich

Joined: 2008-01-03
Posts: 57
Posted: Sat, 2008-01-05 21:25

sounds good, didnt know about this color codes, thanks
 
kckal

Joined: 2008-09-12
Posts: 8
Posted: Fri, 2008-09-12 04:14

wow
this is the most civilized, intelligent, and productive conversation ive witnessed (all in one) in a while.

i ask you all to step back and pontificate this.
im looking at your thread, well down the road. yet its helped me tremendously.
you all are amazing, especially on the developer end that contributes to the publics' interest.
i agree with the "simpsons", gallery is fabulous at working with. its' programmers are reaching their efforts with much apprciation.
thank you so much!

ill post my site eventually, which is behind a firewall for now. ill make sure to repeat my appreciation in my post because the ability with g2 is amazingly helpful. i do not know much with programming but you help me get to where im going and im in debt to you. gallery rules!

much obliged to you all.
thanks
kc