[Embedding, Thumbnail Issue] G2 Post B2

There's nothing in the G2 architecture that would allow this behavior. More probably is that you assigned this mapped WP user to the G2 admin group or another group.
And if you manipulated the database manually, make sure to flush the db cache afterwoods.

"no thumbnail is displayed".. what IS displayed? text "no thumbnail", broken image icon, or actual broken image? what about full image? no link at all or something broken?

The thumbnail is broken.
It links to:

Security Violation

The action you attempted is not permitted.

Back to the Gallery

Error Detail -
Error (ERROR_BAD_PARAMETER, ERROR_UNKNOWN) :

* in modules/core/DownloadItem.inc at line 53 (DownloadItemView::error)
* in main.php at line 285 (DownloadItemView::renderImmediate)
* in main.php at line 79
* in main.php at line 70

So to reproduce, have an image/album in Gallery.
Remove "Everybody" from the permissions.
Add All Users to view all. (so only registered users have access to the item)
If you're in your embedded Gallery, it won't work you have the above error.
If you're in Galley2 it will work just fine if you're signed in.
If you're Logged in to your standalone Gallery, you'll then have access to both the Standalone image, and the embedded image. Cleare the cookie for Standalone G2 and the thumbnails break.

Its odd because The embedded app shows the info on the image, just a broken thumb. I caught this by originally allowing everyone only access to the thumbnail, and All Users could see the resized. In the embedded ap, they see the options for the resize, but no images.

Its like the embedded cookie isn't enough for G2 to get the image, but setting the g2 standalone cookie fixed the problem.

Now all of this was found in the WP-G2 plugin, so it might be something in our code. (the logout function suggested by the docs)

Its not a mapping or path problem, because logging in fixes it. Also if you have other images set for everybody, it works.

Also just logging out of Gallery2 doesn't seem to break the images, killing the cookie is needed.

Image ID is included, but I think I found it!
the embedded page has the correct hyper link urls, but the img src is wrong.

So the image URL is:
http://holosite.servepics.com/gallery2/main.php?g2_view=core:DownloadItem&g2_itemId=3606&g2_serialNumber=1

But it should be:
http://holosite.servepics.com/baby/wp-gallery2.php?g2_view=core:DownloadItem&g2_itemId=3606&g2_serialNumber=1

So it looks like embedding the image isn't using the embedded page.
All links on the embedded app work.

This is why when only logged into the embedded app (WordPress) it breaks, but when I'm also logged into Standalone it works, but all URIs for the src don't.

It helps if I use the same Item id in the examples. I've edited my post to correct the issue, but the second link I posted also shows you the BAD_PARAMETER error, and I can tell you if you had an account in my Gallery2 you'd see the image.

I can't tell you why it does it, only that it does.

So if I need to set my cookie path, how do I do that through the embed class?

When logged into just WP I don't see the image.
When I'm logged in to Gallery, I see the image in both WP and Gallery2
When logged into WP and I view the second link above, I do see the image.

If not logged in, you can't see the image on either (hence the error message anyone here gets with the links above).

My Embedded init is

$ret = GalleryEmbed::init(array(
			   'embedUri' => 'wp-gallery2.php', 'relativeG2Path' => $g2_option['g2_path'], 'loginRedirect' => $g2_options['g2_redirect'],
			   'activeUserId' => ('wp_'.$GalleryUser->ID)));

Where wp-gallery2.php is the page.
$g2_option['g2_path'] is "../gallery2/" but if gallery is in the WP directory, its gallery2/
and it still breaks. (Ozgreg tested this last night on his dev site)
and $GalleryUser->ID is the ID of the current WP User.

The above code is followed by

$gallerySessionId = GalleryEmbed::getSessionId();
	  $g2data = GalleryEmbed::handleRequest();

That seems to work because in the top part of the embedded gallery, its says Welcome, John W. Arnold Site Admin.

So where might I not be setting the right params, to have the cookie path be '/' and not '/baby/'?

I tried print_r'ing the cookie and I got nothing, so maybe I'm not setting the cookie.

Do I also need to include GalleryEmbed::login($extUserId)?

Thanks valiant sorry for being thick.
My WP set cookie for GALLERYSID is '/'
My gallery2 set cookie is '/gallery2/'

Ok heres the break-down:
Updated based on feedback from IRC logs:

*Deleted Cookies no GALLERYSID*
not logged into WP or G2 - Embed displays a login page
Cookie Path '/'
*Log into G2*
not logged into WP but Logged into G2 - Embed displays a login page, standalone I see images
Second Cookie Created, path '/gallery2/'
*Delete Cookies*
Logged into WP but not G2 - See album names, but broken or missing images.
Three GALLERYSID Cookies created : Cookie Path '/', '/gallery2/d/3477-5/', and '/gallery2/d/3683-1/'
Logged into WP and G2 - I see images in both embedded ap and standalone G2
Fourth Cookie created '/gallery2/'
*Log out of G2, didn't delete Cookies*
Logged into WP but logged out of G2 - I see image in Embedded Ap, but not visible in G2
No change to the 4 GALLERYSID Cookies.

Again the permission (because its been a while) to recreate the problem.
Add and image/album in G2.
Removed "Everyone" from the permissions.
Add "All Users" to the permission save view or View all versions.
have an embedded ap and login.

I'm not worried about loggin out of Gallery and still seeing the images. If they can login, its ok. What I want to avoid is requiring users to login twice to see the images.

My directory structure is both gallery and wordpress are at the same level in the directory, but I have tried this with Gallery living within the WordPress directory, and I get the same issue.

System is MacOSX 10.3
Apache 2
PHP 5
WP 1.5
Gallery2 the CVS from 3-4 days ago, after the cookie problem was fixed.
But Gallery2 beta 2 had the same problems, I hoped the cookie fix would fix the issue.
Browser: FireFox (Windows) but Safari and IE6 have the same problem.

Arnoldjw, weird results. And you could have mentioned that you use rewrite module a little bit earlier.
It would be interesting if you have the same results in the case "cleared cookies, login in WP, visit embedded G2" if you have the rewrite module disabled.

What goes wrong here:
- it should create 2 GALLERYSID cookies at max: obviously, the rewrite module leads to incorrects cookie paths, eg. '/gallery2/d/3477-5/'.
The question is: why does it create the '/gallery2/d/3477-5/' cookies / sessions, when it already should have received the '/' cookie.

if the rewrite module is really deactivated (and you deleted your cookies afterwards), then cookie paths like '/gallery2/d/3477-5/' can't be generated, can't be.

Arnoldjw, ozgreg, i need access to your boxes (one of them) to debug this.
1. at least WP / G2 accounts
2. ftp or ssh access to enter debug information in the code would make it a lot easier.

I'll take a look this evening.

I'll look at the xaraya integration and see what they do.
We do a
$ret = GalleryEmbed::init(....)
Followed later by
$gallerySessionId = GalleryEmbed::getSessionId();
$g2data = GalleryEmbed::handleRequest();

But I'll see how others handle it.

Thanks

Valiant, you should have a PM with the devtest board details..

Thanks for your Help...

My first short debug session on ozgregs site yields the following:
- There are several things wrong, let's start with things that WP does wrong, because G2/embedded is proven to work correctly with other CMS'.

- WPG2 sometimes sets activeUserId in the init call to '0' / anonymous, when it actually set it to Admin. Or something like that, because i can't explain it.

- The current WPG2 integration code isn't 100% correct.

current code:

	  //Include Gallery2's Embed Page to run Gallery Class if path exists

		  require_once(ABSPATH.$g2_option['g2_path'].'embed.php');

	  //Setup Gallery Information Pass to Gallery WordPress's CurrentUser

	  $ret = GalleryEmbed::init(array(

			   'embedUri' => 'wp-gallery2.php', 'relativeG2Path' => $g2_option['g2_path'], 'loginRedirect' => $g2_options['g2_redirect'],

			   'activeUserId' => ('wp_'.$GalleryUser->ID)));

	  if ($ret->isError()) { 

		//If no user match, then send the current user to gallery

		$ret = GalleryEmbed::createUser(('wp_'.$GalleryUser->ID), array ('username' => $GalleryUser->user_login, 'fullname' => $GalleryUser->fullname, 'email' => $GalleryUser->user_email, 'password' => 'test'));

		$ret = GalleryEmbed::init(array(

			   'embedUri' => 'wp-gallery2.php', 'relativeG2Path' => $g2_option['g2_path'], 'loginRedirect' => $g2_options['g2_redirect'],

			   'activeUserId' => 'wp_'.$GalleryUser->ID));

	  }

		

	  $gallerySessionId = GalleryEmbed::getSessionId();

	  $g2data = GalleryEmbed::handleRequest();

	  if ($g2data['isDone']) {

		exit; // G2 has already sent output (redirect or binary data)

	  }

	



	// Should we Disable the Header output and instead allow the g2wpheader to control the Output?

	  if ($g2_option['g2_externalheader']=="No") {

		  //Include WP Theme or basic html header

		  if ($g2_option['g2_themewrap']!="No") {

		  	//Include the WP Header

			get_header();

			//Include any plug-in header content set in the plugin options

			checkforsidebar ('g2_header');

		  }else{

		  	//No Theme, Include include standard html tags

			echo "<html>\n<head>";

		  }

	

		  if ($g2_option['g2_galleryhead']!="No") {

			 //Start Gallery Header

			 echo $g2data['headHtml'];    //Display the gallery header

		  }

	

		  //If theme for Gallery is missing include standard html tags

		  if ($g2_option['g2_themewrap']=="No") {

			echo "</head>\n<body>";

		  }

	  }

	  else if ( $g2_option['g2_externalheader']=="Yes" && file_exists( $current_stylesheet_dir.'/wpg2header.php') )

			include ($current_stylesheet_dir.'/wpg2header.php');



	  echo $g2data['bodyHtml'];	 //Display the gallery content

	  

	  //Close Gallery Connection

	  $ret = GalleryEmbed::logout();

  } else {

  	//We were not able to get gallery connected

	get_header();

	checkforsidebar ('g2_header');

  	if (!$isg2active){

	  echo "<h1>Sorry the Gallery Plug-in is not enabled.</h1>";

	}else{

	  echo "<h1>Sorry the Gallery Plug-in is not configured.</h1>";

	}

  }

corrected code:

	  //Include Gallery2's Embed Page to run Gallery Class if path exists

		  require_once(ABSPATH.$g2_option['g2_path'].'embed.php');

	  //Setup Gallery Information Pass to Gallery WordPress's CurrentUser

/* Why do you call this variable $GalleryUser ?
 * actually it's $WPUser ! and no wp_ prefix is needed! doesn't do harm though.  */
$uid = $GalleryUser->ID; 
// now check if the $uid == id of anonymous WP user
//  change this code...
if ($uid == _WP_ID_UNREGISTERED) {
      $uid = '';
}

/* added embedPath (more robust!) */
	  $ret = GalleryEmbed::init(array(
			   'embedUri' => 'wp-gallery2.php',
'embedPath' => $g2_option['embedPath'], 
                'relativeG2Path' => $g2_option['g2_path'], 'loginRedirect' => $g2_options['g2_redirect'],
			   'activeUserId' => $uid));

(see my changes in the above code)

Now you have to do more error checking, see my explanations in http://gallery.menalto.com/index.php?name=PNphpBB2&file=viewtopic&p=129275#129275

// check $ret from ::init
if ($ret->isError()) {
    if ($ret->getErrorCode() & ERROR_MISSING_OBJECT) {

        // check if the there's no G2 user mapped to the activeUserId
        $ret = GalleryEmbed::isExternalIdMapped($uid, 'GalleryUser');
        if ($ret->isError() && ($ret->getErrorCode() & ERROR_MISSING_OBJECT)) {
            // user not mapped, map and create G2 user now
            $ret = GalleryEmbed::createUser($uid, array ('username' => $GalleryUser->user_login, 'fullname' => $GalleryUser->fullname, 'email' => $GalleryUser->user_email, 'password' => 'test'));
            // check $ret error code
            if ($ret->isError()) {
                 print "couldn't create G2 user, here's the error from G2: " .$ret->getAsHtml();
                exit;
            }
            // login as the $uid user in G2 now that the user exists
            $ret = GalleryEmbed::checkActiveUser($activeUserId);
            if ($ret->isError()) {
                 print "couldn't login with new G2 user, here's the error from G2: " .$ret->getAsHtml();
                exit;
            }
        } else {
            // an unknown / strange error 
            print "unknown G2 error, here's the error from G2: " .$ret->getAsHtml();
                exit;
        }
    } else {
        // an unknown / strange error 
        print "unknown G2 error, here's the error from G2: " .$ret->getAsHtml();
        exit;
    }
}

$g2data = GalleryEmbed::handleRequest(); 

- $ret->isError() on ::init can be caused be various things. don't interpret too much in it. you have to call isexternalidmapped() as i do in the above code.
- don't reinit, just call checkactiveuser
- always check the $ret status codes

please implement the changes and then let's check the status again.

- G2 is supposed to create two cookies, one for embedded and one for standalone.
- The embedded cookie is set with a path that is also "visible" for the standalone G2, i.e. when using G2 in embedded only, G2 should always only create 1 cookie, the one with path / (or whatever path is set in the embedded cookie case).
- let's first focus on the urlrewrite module deactivated case, because it works for other embedded G2s (xaraya).

- setting the G2 standalone cookie path for embedded G2 is a bad hack. This way, embedded G2 doesn't see the cookie (in the general case) and a new session (+ cookie) is created on each request.

- but we are already working on a different cookie solution, see the cookie / auth topic. we will set the cookie path to "/" on all installations, embedded or not. this will guarantee that only a single GALLERYSID cookie exists per installation and thus fix all problems.

- don't change relativeG2Path, embedUri, embedPath to something else what they actually are please.

i don't think that we really identified the actual cause of the current WPG2 cookie problems (when url rewrite is deactivated).

with url rewrite deactivated, we have to analyze this case:

Sounds great.

So what does work and what not with the new code? No problems with url rewrite disabled?

From what you write, I have the impression that you set embedPath to the same value as relativeG2Path. But these are different things, see the examples in docs/EMBEDDING.

ps: trying to find out where you define function g2_login(), no luck yet.

Thank you for looking at the code.

Ozgreg and I have made a number of changes to the code, and most of the time seems to function as expected.

Thanks