Audio Module

Hi

I'm brand new to Gallery, but have decided to throw myself in at the deep end and have a go at an Audio Module.

Phase 1 of the module will simply:
1. register to take control of audio MIME types
2. Upload audio files
3. Provide an inline audio player for the 3 common audio types: MP3, WMA and RM

I had a head start in that I could base the module on the Movie module in core - but being a newb I've hit a few problems, which are probably to do with my understanding of how things work in G2.

Would someone with more experience mind taking a look please, and giving me some guidance on how to get this working?

Here's where I'm at:

1. I've attached the module files to this post so you can see the code.

2. I upload them to my gallery modules folder in their audio folder.

3. If I go to gallery admin, I can see the module, install it, and activate it, with no problems.

4. Then I go to upload an audio file and I get these errors

At least this means my module has succeeded in registering itself to handle the MIME types!! But what else is wrong here?

5. I then found out about gmake (something that is new to me) so went to my modules/audio/classes directory and typed 'gmake'. This is the output:

I'd really appreciate any help that you could give me to learn how to make this work.

Thanks
Steve

Thanks Valiant

Is there a guide anywhere on how to obtain and install rxp, saxon and gmake please?

Also is there a way to check which of those I have already, as I seem to have gmake because gmake --help seemed to work fine.

Cheers
steve

I'm using Red Hat Enterprise Linux 3, running under Plesk 7.5.3

Hi

Thanks for all help so far.

I've installed saxon 6.5.4 and rxp.

Now I'm getting this error message when I run gmake in the classes directory of my audio module:

cd interfaces && gmake -
gmake[1]: Entering directory `/home/httpd/vhosts/xxxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/interfaces'
gmake[1]: Nothing to be done for `inc'.
gmake[1]: Leaving directory `/home/httpd/vhosts/xxxxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/interfaces'
cd GalleryStorage/DatabaseStorage/schema && gmake -
gmake[1]: Entering directory `/home/httpd/vhosts/xxxxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/GalleryStorage/DatabaseStorage/schema'
cd xml-src && gmake -w xml
gmake[2]: Entering directory `/home/httpd/vhosts/xxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/GalleryStorage/DatabaseStorage/schema/xml-src'
gmake[2]: *** No rule to make target `xml'.  Stop.
gmake[2]: Leaving directory `/home/httpd/vhosts/xxxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/GalleryStorage/DatabaseStorage/schema/xml-src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/home/httpd/vhosts/xxxxxx.co.uk/httpdocs/mediastore/modules/audio/classes/GalleryStorage/DatabaseStorage/schema'
gmake: *** [all] Error 2

you forgot the GNUMakefile in the xml-src directory, that's why you got this error during gmake. copy it from any other module, e.g. from comments

here's your module after running gmake successfully, didn't fix anything else:
http://dev.nei.ch/audio.tar.gz

Hi

Thanks for all your help.

I've now got gmake working, and have already made a few corrections to my module to fix a few mistakes, but there is one error I just can't trace!!!

I can now upload audio using my module, but when I come to try to view a gallery with an AudioItem in it, or view an AudioItem page, I get this error:

Warning: assert(): Assertion failed in /home/httpd/vhosts/xxxxxx.co.uk/httpdocs/mediastore/modules/core/classes/GalleryEntity.class on line 536

I've attached the module, can anyone guide me in how to fix this error please?

Thanks a lot
steve

Hi mindless

thanks

i have this code in my 'galleryaudioitem.class' file:

    /**
     * @see GalleryEntity::itemTypeName
     */
    function itemTypeName($localized = true) {
	global $gallery;
	if ($localized) {
	    list ($ret, $core) = GalleryCoreApi::loadPlugin('module', 'core');
	    if (! $ret->isError()) {
		return array($core->translate('Audio'), $core->translate('audio'));
	    }
	}
	return array('Audio', 'audio');
    }

i thought this would cover it, but i can't find the error. Can you spot what i've done wrong please?

Thanks
Steve

Ok thanks valiant

Part of my challenge here is that all the other Item modules are only in core, so i can't compare with a non-core module to learn the code.
For much of the code I'm simply adapting the Movie module, and haven't been quite sure about whether to change all references to core, or whether some are necessary because they reference a required part of the core for any Item.

Thanks for the pointer about how the translation works.

I'm learning slowly, but I'll get there in the end!!

i don't have the g2 source code at hand, but generally, it's like that:
the assert(false); statements are added in functions of G2 which are meant to be overridden by classes that extend of the class where the function is defined in.

in your case, you created a GalleryAudioItem class which extend the GalleryDataItem, which extends .... which extend the GalleryEntity class.

GalleryEntity has a few functions which must be implemented / overridden by your GalleryAudioItemClass.

take a look at
modules/core/classes/GalleryEntity.class on line 536
because the assert is on that line. a few lines above 536 is the function line which tells you which function you need to define / implemente in your GalleryAudioItem class.

yep, looks fine.
i can't believe your php doesn't work correctly.
what's your exact php version? (see /lib/supporty/phpinfo.php).

so the problem must be somewhere else.

yep, should be fine. then the problem must be somewhere else in your code...

see these 2 lines at the bottom of GalleryAudioItem.class?
}
}

wonder why you added a 2nd one there? to compensate for a missing } somewhere else... function itemTypeName is not in your class, it is inside some other function. scan up from itemTypeName to find it.

I haven't had much time to work on it for a week or two - been tied up with other projects.

Here's how far I've got:

1. The audio uploads, and my module claims control of it instead of Unknown Items
2. The audio is saved to the filesystem, and the database tables are updated to include it
3. I have created a render function with instances of media players for popular file types (which work on a normal html page), but I just can't seem to get these to display in G2.

So my next challenge is to figure out how to get the players to display properly.

I can't seem to find how to attach a file in this new gallery forum, otherwise i'd attach a copy of the latest version of the module.

cheers
steve

hmmm...just tried editing the first post in this thread to add the latest version of the module, and it says 'invalid extension'
I'm trying to upload it as a zip file called 'audio_2005-09-22.zip'
??

Thanks Mindless - Drupal is great as a CMS isn't it? Very adapt-able.

Here's the audio module in its latest form. I still haven't had much time to do more work on it, so am still stuck on the rendering of the inline players. Upload seems to work fine now.

Thanks to you and the others for the help

Steve

Wow! I better spend some more time getting thos to work then!

I've got to finish my next book before the end of the month though, so won't be able to get to this before early Nov.

If anyone wants to help out I'd be very grateful.

So far the upload works, the audio module takes control of audio files, and the code for inline streaming players is there but doesn't work yet.

The latest code is still the version I uploaded above.

I'll be back to working on this in Nov, but will check the forums occaisionally before that.
cheers
steve

Well Steve,
You've taken this module a long way.
And I for one would like to see it finished - it would be a great addition to G2.
I only wish I had the experience to help you, and expedite the completion.
Happy coding

Hi

Valiant: I write books to help people start and run a business:
http://www.amazon.co.uk/exec/obidos/search-handle-url/index=books-uk&field-author=Parks%2C%20Steve/202-1993820-0911016

all:
I've been diverted away from development of this for a while - but have been learning a lot more about PHP in the meantime to help me finish this.

watch this space! (but please be patient...i'm very much learning the ropes as I go!)

steve

maybe you can successfully uninstall the module with a direct site admin link (if you can't access site admin anymore):

try the url from

http://codex.gallery2.org/index.php/Gallery2:faq#Images_don.27t_show_up_and_the_album_.2F_photo_links_don.27t_work.2C_what_can_I_do.3F

but change the module name to audio and change the operation from deactivate to uninstall

hi was this module ever completed

Hi,

no upgrade for gallery 2.1.2 ?

thanks in advance

Hi there,

Just wondered if you are going to working on an upgrade? Sounds like a brilliant project. Or anyone else keen to build such a module ?

Tim

Where can I find this upgrade, tried to down and installed the one I found in the list of modules, but it didn't work!

Sounds really good, and I really want to use it streaming my audio files!

Thanks!