Preview Watermark Behavior

ejolley

Joined: 2006-02-02
Posts: 5
Posted: Thu, 2006-02-02 10:28

Ok...I just upgraded from Gallery 1.5 to 1.5.2.

Before, when adding a watermark to a picture, you could select your watermark from the dropdown, click on "Preview" it, and if you liked the preview, you could click on "Save" to make it permanant.

Now, you can preview your watermark, but if you want to "Save" it after previewing it, you actually have to go into the dropdown and select the correct watermark again and then click on "Save". Otherwise it will watermark the picture with the first one in the dropdown, not the one you just previewed.

So it's an extra mouseclick... but it also is counterintuitive if I just previewed a watermark that I couldn't just click on Save... rather than selecting it from the dropdown again.

I'd like it to behave how it did before, and not have to reselect the correct watermark after previewing.

If this is not how 1.5.2 is behaving for others... please let me know.

Eric Jolley
 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Thu, 2006-02-02 12:42

Hello,

Good idea. I also found that the second selectbox also is resetted.

Fixed/Done in CVS for 1.5.3.

Its very easy.
open layout/watermarkform.inc

add:global $wmSelect;
this fixes the latter combobox.

then find $options[] = array('value' => $wmFile, 'text' => $wmFile);

change to:

if(!empty($wmName) && $wmName == $wmFile) {
                 $options[] = array('value' => $wmFile, 'text' => $wmFile, 'selected' => true);
            }
            else {
                 $options[] = array('value' => $wmFile, 'text' => $wmFile);
            }

Thanks,

Jens
--
Last Gallery v1 developer and translation manager.
 
ejolley

Joined: 2006-02-02
Posts: 5
Posted: Fri, 2006-02-03 04:50

Thanks!!!
 
Tim_j
Tim_j's picture

Joined: 2002-08-15
Posts: 6818
Posted: Fri, 2006-02-03 11:48

_i_ say thanks !

Keep on feedbacking and making g1 better ;)

Jens
--
Last Gallery v1 developer and translation manager.