AutoRotate Module: Need help bringing to production quality

hakk

Joined: 2006-03-31
Posts: 2
Posted: Fri, 2006-03-31 07:20

Hi all,

A while back I began development on a G2 module to enable auto-rotation of images based on EXIF data. Although I completed the module to my immediate satisfaction some time ago, it was never production ready. It's not kludgy or anything, but I never got around to polishing it for production and inclusion into the tree. The module itself is based on the old sizelimit module, but that was just an obvious starting point. It uses the proper gallery EXIF interface implementation for obtaining its data, and I have tested operation against a variety of cameras, images, etc. Here's the status:

- Was working in 2.0, now seems to be having problems in 2.1, not yet identified exactly what's going on, but I'm checking it out a bit now. I've only changed what I know are the necessary API changes for 2.1 which allows the module to install and co-exist in the system without error, but the image isn't getting rotated now and I'm not sure why. Probably some small fix somewhere, just needs some debugging.

- Module needs proper phpunit test cases (yeah, I know, test first code second, but I didn't). There's some half-assed attempts in there based on the sizelimit tests, but they are mostly useless.

- The module itself is not complex, but I had envisioned a couple of simple options (enabled/disabled per album for example), however I never got them right, although the skeleton is there.

- Ideally, there should be a keep-original option. Right now, the module replaces the original image with the rotated image, thus destroying the original. This was temporary. The module should use a keep-original option and simply make the rotated image a preferred derivative if the user selects this option.

- Don't have much time to dedicate to it now. I have attached literally a rough dump from my current version which has been modified a bit to at least install into 2.1. If someone wants to see the old working 2.0 version, let me know.

Consider this a call for help. This is a small but super important feature that many many people have requested, many have offered to write, but few seem to have got as far as this. Again, I have attached the 1.0.1 version that installs into 2.1 but doesn't operate properly.

Thanks,
Jon

AttachmentSize
autorotate_1.0.1.tar.gz19.33 KB
 
hakk

Joined: 2006-03-31
Posts: 2
Posted: Fri, 2006-03-31 07:25

Ok, after I posted that, I figured it was dumb to not include the original 1.0.0 (for G2.0) working version anyway. So here it is attached.

 
mindless
mindless's picture

Joined: 2004-01-04
Posts: 8601
Posted: Fri, 2006-03-31 15:37

cool, thanks!

 
KnightShade

Joined: 2004-03-22
Posts: 13
Posted: Sun, 2006-04-16 15:44

Very Cool!

Every time my wife uploads photos to Gallery I hear about how she misses this feature.

Not sure if my PHP skills will be up to the challenge... but I'll at least take a look at this :-).