Keyword Album ?

what's wrong with splitting on white space? flickr tags are split by white space as well - if you want to add more than one word in a tag you just use quotes

One question about the keyword albums: when does the keyword albums dropdown update? I edit a photo and change a keyword, but the keyword dropdown doesn't update. Thanks.

yes, sorry about the typo.

Splitting the keyword module in a keyword and a virtual albums module could be senseful:

• keyword module: Reads the IPTC keywords of the picture and saves them in a keyword table in the db
• virtual albums module: Create virtual albums based on a certain criteria (like a keyword from the keyword table or an username)
• tag module: Creates a tag cloud which uses the keyword table (see this post)

I think the keywords should be separated by semicolon by default, too. E.g. the common application PixVue writes IPTC and XMP metadata as well and separates the keywords by semicolon.

Useful hints how to handle with keywords (could be useful for the tag module):

• Ignore upper- and lower-case
• Offer partial matches (like keyword module already does),
• intelligence for matching like-sounding words, for instance
  ‘colour’ and ‘color’

because we don't think about plurals, case or ambiguity very carefully.

Full list with more hints on creating/searching keywords: http://www.thirdlight.com/downloads/Metadata_whitepaper.pdf (especially have a look at page 3)

(unfortunately IPTC and XMP keywords doesn't support taxonomy like Drupal does ;) )

What's IPTC? And are we still talking about mindless' module with my cloud patch or are we talking about an entirely new module?

here are the basic steps.. look at existing code as examples to help make sense of this:

1. classes/Maps.xml file to define your table(s)
2. do 'make' in classes directory to build GalleryStorage/schema.tpl file and Maps.inc file

Now when you install (or upgrade) your module it will create the table(s) in the db. You can use GalleryCoreApi::addMapEntry, updateMapEntry, removeMapEntry, getMapEntry to interact with the db/tables. There's also $gallery->search for writing your own queries (syntax for a column is [MyMap::myColumn] (G2 will then add the table/column prefixes).. but getMapEntry will be enough for basic queries on just your table. hope this helps..

yes, that's right.

looks great! I hope you'll continue to contribute

good job adding the tag cloud as a block option.. looks like we can add that in after a few changes:
looks like maxCloudFontEnlargement is hardcoded at 5.. maybe make that a block parameter that defaults to 5 (you don't have to add it in blocks.inc as a user-configurable param, but make it available as a g->block param).
in the tpl I think you could use keyword=`$keyword.name` instead of {assign var="keyword_name"
probably we'll need upgrade code to clear existing keywords module params.. otherwise you could get the new version and set the showCloud option but the extra data wouldn't be in the cached keyword list.
my remaining feedback is just to meet our style guidelines: var names are $camelCase so $keyword_count should be $keywordCount and $newkeyword should be $newKeyword. we also try to use descriptive names, so maybe $nk and $kw could be renamed, but not vital.

(btw, I only looked at the tag cloud patch so far)

Thanks for feedback . I'll post here reviewed versions of both patches in a few days.

czar, the feature-freeze date for 2.2 is coming up soon so I went ahead and added your patch for keyword cloud into svn, with the changes I suggested. thanks for the contribution!

Hi guys

I've just come across this thread and the keyword album sounds ideal.

I have been trying to put a similar module together too. In essence, I want Gallery to have a link by a picture (in the block maybe) which will send a search query based on the image's keywords in Gallery to Alamy Images to effectively search my account on their site and display the same / similar images in a new window.

Basically, it's linking to Alamy but keyword specific.

There's a thread about this with some ideas / code here: http://gallery.menalto.com/node/54882

Having seen your work already on the keyword idea, might this Alamy link be an easy addition?

Would love to know your thoughts.

Cheers
rob

---
Robert Hollingworth
www.roberthollingworth.co.uk

Oh! Another question: does this module let you automatically add a set of tags to all images in a particular Album? Either at upload time, or later? I can see that you can do it to an image one image at a time, but can you do it to all images in the Album?

And when you are adding tags, can you add more than one tag at a time, using some sort of delimited list, or must you add them one tag at a time?

Thanks!
David

Mindless:

Thanks! If I read the Flickr Tags thread that this one came out of correctly, the search against the keyword field uses like '%$keyword%'. If wondering if there is anyway to indicate in the URL, or through POST that multiple keywords are being passed, such that the query can be built.

Since keywords are stored in a delimited format (comma, space or semicolon), we could use the same character right in the URL to denote a multidimensional dynamic keyword album.

What would then be needed is to do a quick check to see if the keyword were delimited. If it is, we parse the compound keyword to extract individual keywords into an array and then...:

$keywords = array('David', 'Miami');
$where = 'WHERE ';
$likeclause = "keyword like '%".implode("%' AND like '%",$keywords)."%'";

$where .= $likeclause;

$where should now be

WHERE keyword like '%David%' AND keyword like '%Miami%'

That ought to yield the result of mutlidimensional keyword album. If $keywords is a single word like 'David' (i.e. the current method), it would yield:

WHERE keyword like '%David%'

I am guessing that this second type of WHERE is what is being generated now?

Thanks
David

Mindless:

Ok, sounds good. Will do.

I've downloaded the latest nightly build, and installed it. I think I know where in KeywordAlbum.inc I need to make my changes.

I've created a couple of standard albums, and applied keywords to them, as well as the images within them, so I'm ready to work.

Now all I need to know is something basic: how do I define a Keyword Album?

I'll submit my changes as soon as I can.

Thanks

Hi Mindless.

I had a chance to hack on the KeyAlbum a bit today, and was able to get it working. The changes were pretty simple, as I suspected.

I did it such that the keyword delimiter is the semicolon, since that is easy to parse. So, for example, to get a Key Album with all images labeled both David and John, you would go to main.php?g2_view=keyalbum.KeywordAlbum&g2_keyword=david;john

I didn't do anything about case-sensitivity, since that is already ahandled elsewhere, apparently.

The changes amount to adding six lines of code, and editing one, all within KeyAlbum.inc::getChildIds()

I would prefer NOT to publish the address of my test implementation gallery site, though, so I am PMing it to you here:

[[redacted URL]]

Please take a look and see what you think.

I've only got the one gallery up right now, but testing seems solid.

How do I submit my patch?

DS

Mindless:

Here you go. Let me know if there are any concerns.

Index: KeywordAlbum.inc
===================================================================
--- KeywordAlbum.inc	(revision 14750)
+++ KeywordAlbum.inc	(working copy)
@@ -162,17 +162,27 @@
 	    return array($ret, null);
 	}
 
-	list ($ret, $query, $data) = GalleryCoreApi::buildItemQuery(
-		'GalleryItem', 'id', '[GalleryItem::keywords] LIKE ?',
-		$params['orderBy'], $params['orderDirection'], null, 'core.view', false, $userId);
+	$keywords = explode(';', $keyword);
+	$liketerms = array();
+	foreach($keywords as $k){
+		$liketerms[] = '[GalleryItem::keywords] LIKE ?';
+		$liketerm = implode(' AND ', $liketerms);
+		list ($ret, $query, $data) = GalleryCoreApi::buildItemQuery(
+			'GalleryItem', 'id', $liketerm,
+			$params['orderBy'], $params['orderDirection'], null, 'core.view', false, $userId);
+	}
+
 	if ($ret) {
 	    return array($ret, null);
 	}
 	if (empty($query)) {
 	    return array(null, array());
 	}
-	array_unshift($data, '%' . $keyword . '%');
 
+	foreach($keywords as $k){
+		array_unshift($data, '%' . $k . '%');
+	}
+
 	list ($ret, $searchResults) = $gallery->search($query, $data);
 	if ($ret) {
 	    return array($ret, null);

Mindless:

Good catch, I shouldn't be calling buildItemQuery() repeatedly.

In fact, upon further reflection, the closing bracket should be even earlier. There is no more need to continually implode the array $liketerms into $liketerm than there was to repeatedly call GalleryCoreApi::buildItemQuery.

As far as the array_unshift() goes... For fun, I did some profiling of the differences between using array_unshift, array merge and array concatenation. I used the US Declaration of Independence as a source document for array strings, and built three identical target arrays and one addarray out of randomly selected words from the declaration.

Interestingly, given identical (VERY large) target arrays, using array_merge is approximately 800 times faster than repeated unshifts. However, unsurprisingly, using $result = $firstarray + $secondarray was roughly twice as fast as array_merge(). This is because array_merge is interested in more contraints than concatenation, and so can't run as quickly.

These performance differences don't really dissappear when you get to smaller arrays (size 50 or so). It just becomes less of a concern.

In any case, while it appears that, at least in the case of string arrays of the size we are talking about, that direct array concatenation is faster, I agree that array_merge() is a clearer, less confusing way to state the operation. For our purposes, we are talking about a loss of approximately 6 milliseconds or so.

That said, here is the newly tested version:

Index: KeywordAlbum.inc
===================================================================
--- KeywordAlbum.inc	(revision 14750)
+++ KeywordAlbum.inc	(working copy)
@@ -162,17 +162,26 @@
 	    return array($ret, null);
 	}
 
+	$keywords = explode(';', $keyword);
+	$liketerms = array();
+	foreach($keywords as $k){
+		$liketerms[] = '[GalleryItem::keywords] LIKE ?';
+	}
+	
+	$liketerm = implode(' AND ', $liketerms);
 	list ($ret, $query, $data) = GalleryCoreApi::buildItemQuery(
-		'GalleryItem', 'id', '[GalleryItem::keywords] LIKE ?',
+		'GalleryItem', 'id', $liketerm,
 		$params['orderBy'], $params['orderDirection'], null, 'core.view', false, $userId);
+
 	if ($ret) {
 	    return array($ret, null);
 	}
 	if (empty($query)) {
 	    return array(null, array());
 	}
-	array_unshift($data, '%' . $keyword . '%');
 
+	array_merge((array)$keywords, $data);
+
 	list ($ret, $searchResults) = $gallery->search($query, $data);
 	if ($ret) {
 	    return array($ret, null);

Thanks
David Serhienko

current svn working fine, afaik. not sure what the question has to do with keyword albums.

I think I found a bug in the keyword album module. I'm using svn 2.2 14966(maybe. I did an svn update on 10/24). See the following URL. There is two pics tagged with 'rachael' and 6 or so tagged with 'baltimore'. However, baltimore doesn't show up in the keyword album drop down or the cloud. The settings for both the list and the cloud are to display everything, not just the current.

http://thewilliaRE.MOVEmsfamily.com/gallery2/main.php?g2_itemId=2490 <--take out 'RE.MOVE'

-kevin

only the comma and semi-colon are selected. All my keywords are comma delimited.

i could have sworn i responded to this to confirm the 3600*24 code change to 0 worked but i guess it didnt go through. OK, so the code change worked. there was no max keywords set and there were no more rachael photos in existance.

no, G2 doesn't have the ability to write exif or iptc.

you can add keywords in "edit photo -> general", but that's not very tag-like, i know.
you probably want a AJAX interface on the album / photo page itself to add tags. or at least a "edit tags" / "add tag" action.

noone's working on this. you're welcome to file a feature request or submit a patch.
http://gallery.menalto.com/sfvote/help

This would also be a nice way of implementing ratings filtering (show me photos that are only G, PG, PG-13 or show me only photos that are work-safe). It would be nice to be able to set a filter on another album (either Dynamic or standard), so that, for example, if I created a gallery that was Allison+Soccer, I could add a filter on top of that to show only playoff games. Not positive how this looking from a UI standpoint.

/carmi

Hello, wonderful to see this module is getting into working order - one question though: does the Keyword Albums module in the recently released 2.2 rc work with keywords on individual images in the gallery? I can only seem to get it to assign keywords to entire albums (which I guess would make sense with the name) but that's not what I was expecting.. is there any way to get this most recent gallery release to act like MatthewT_01's example?