Custom Fields on Edit Captions page

(I hope I'm posting this to the right forum....)

I'm just getting started with Gallery2, and I'd really like to make it easier for my authors and editors to add/edit custom data. The best way to do that, it seems to me, would be to add the custom fields to the Edit Captions page.

I'm an experienced PHP developer, so I can probably figure out how to do this, but if it's a problem that's been solved already, or if there are places to read up on how that page is put together, or any hints at all that someone can give me, I'd love not to have to start from scratch. I haven't really been able to find anything useful in the poking around on here that I've done so far....

TIA.

Gallery version = 2.1.2 core 1.1.0.2
PHP version = 4.4.4 cgi
Webserver = Apache/1.3.37 (Unix) mod_fastcgi/2.4.2 mod_gzip/1.3.26.1a mod_auth_passthrough/1.8 mod_log_bytes/1.2 mod_bwlimited/1.4 FrontPage/5.0.2.2635.SR1.2 mod_ssl/2.8.28 OpenSSL/0.9.7a PHP-CGI/0.1b
Database = mysql 4.1.21-standard-log, lock.system=flock
Toolkits = ArchiveUpload, Exif, Getid3, ImageMagick, NetPBM, SquareThumb, Thumbnail, Gd
Acceleration = none, none
Operating system = Linux asclepius.site5.com 2.6.18-1-s5 #1 SMP Tue Oct 10 21:34:59 EDT 2006 i686
Default theme = matrix
Locale = en_US
Browser = Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7

Thanks for the quick response. I'll probably start by implementing it for just this site. Maybe down the line I'll turn it into an extension....

i'm moving this topic to the development forums.

@smarty:
well, there's the smarty website and gallery .tpl examples to learn from. but we don't really have docs for that.
http://codex.gallery2.org/index.php/Gallery2:Tpl_Reference and http://codex.gallery2.org/index.php/Gallery2:Themes don't really help in this case.

Ok, I've got it working, though I've been a bit kludgy with it, and am almost certainly not doing things in the most Galleryesqe fashion. I've modified two files:

modules/core/ItemEditCaptions.inc

For saving the data, around line 90, below:

$ret = $item->save();

add:

if (!$ret) {
     $ret = CustomFieldHelper::saveFieldValues($item, $form['customFields'][$id]['fields']);
}

----

For viewing the data,

Around 227, below "/* build peers table */", add:

        /* get Custom Field Names */
        list ($ret, $globalParam) = CustomFieldHelper::loadParameters();
        foreach ($globalParam['common'] as $field) {
            $albumFieldNames[] = $field['field'];
            $photoFieldNames[] = $field['field'];
        }
                
        foreach ($globalParam['photo'] as $field) {
            $photoFieldNames[] = $field['field'];
        }
                
        foreach ($globalParam['album'] as $field) {
            $albumFieldNames[] = $field['field'];
        }
        $form['photoFieldNames'] = $photoFieldNames;
        $form['albumFieldNames'] = $albumFieldNames;

and add this:

$child->customFields = $customFields[$child->getId()];

inside the foreach loop just below the above.

===========

modules/core/templates/ItemEditCaptions.tpl

around line 90, below the "Description" textarea, add:

	{* only dealing with photo (and common) custom fields at the moment *}
	{foreach name=itemLoop from=$form.photoFieldNames item=fieldName }

  <h4>{$fieldName}</h4>
  {include file="gallery:modules/core/templates/MarkupBar.tpl"
	   viewL10domain="modules_core"
	   element="summary_`$item.id`" firstMarkupBar=false}
  <input type="text" id="{$fieldName}_{$item.id}" size="60"
   name="{g->formVar var="form[customFields][`$item.id`][fields][`$fieldName`]"}" value="{$item.customFields[$fieldName]}" />

	{/foreach}

I think that's all I did. I know this doesn't handle the dropdown or album cases, but otherwise it seems to be working. Suggestions welcome, and if someone wants to tell me how to make this more upgrade-friendly, I'd love to hear about it.

Thanks again....

I am just about to embark on a similar customisation of the Edit Captions page (I prefer to think of it as Batch Edit). I am experimenting with Gallery2.2 and see that that already has the keywords field included here.

I just wanted to check if anyone has done anything more than is detailed in this thread? And has anyone tried to implement it for a drop-down?

I guess the answer to sergii's last post is 'yes', but I confess I know nothing as yet about factories. More homework ;-)

sergii, I tried a patch -l of ItemEditCaptions.inc using the editcaptions-factory.diff_.txt file and get the error

Assertion failed: hunk, file patch.c, line 321

I am using the win32 patch.exe in UnxUtils

This is all a bit new to me. Can you either suggest another way to run the patch, or perhaps supply an updated ItemEditCaptions.inc based on the current release with your patch applied?

On second thoughts, I wonder if that's where the problem lies - I am using Gallery2.2, and maybe your patch only works with the released versions?

Thanks again, James

May be trivial for someone of your obvious talent, but I'm swimming further and further out of my depth here. But it's always fun trying to learn new strokes ;-)

I'm afraid I barely know enough about how gallery works to implement what I wrote above, so I can't really help you.... (Sorry.) I guess I would start by doing a global search for the phrase "CustomFieldHelper", and see where that took me....

-Sprug.

you didn't get any "Chunk ... failed", so the patch was applied correctly. No idea what "missing header" warnings mean, but all chunks apparently were applied successfully.

The changes you should see:

1. On CustomFields admin page a checkbox "Multiple selections allowed"
(that's the first patch)

2. On Edit Captions page you should see custom fields for items.
(that's the second patch)

Try to reinstall the module or rebuild some caches from the Admin page - I'm far from my gallery now and cannot tell what exactly you need to rebuild. Seems that gallery remembers factories/implementations when a module is installed.

Is this still doable? I want to edit my custom fields for each photo, but I don't want to have to go to each photo's page and edit the custom fields there. So, I am guessing this module will help me...right?

So, what do I need to do? Do I just follow sprugman's tutorial? *Newbie alert*

Can someone convert Sergil's patches for Gallery 2.3? Or push me in the right direction?

I would really like to add my custom fields to the bulk edit captions page but can't get any of this code to work. Appreciate any help.