[Tags Module] New Version

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Sat, 2007-03-31 06:56

Hello All,

I have put version 1.1.1 of the Tags module in the gallery contrib so it can be downloaded from the plugin repository.

Changes:
- Added the rewrite rules
- Removed the Maintenance task to get rid of Tags duplicates, made it an upgrade path function

If you are upgrading from 1.0.0, 1.0.1 or 1.0.2, you should be good.
If you are updating from 1.1.0, I would recommend running the maintenance task "delete duplicate tags" at least once

See you !
-------------------------
The Termite - - http://www.termitenshort.com/

valiant

Joined: 2003-01-04
Posts: 32509

Posted: Sat, 2007-03-31 13:45

I've committed a style cleanup and some bugfixes for mdoule.inc.

The db table cleanup upgrade step will follow.

--------------
Documentation: Support / Troubleshooting | Installation, Upgrade, Configuration and Usage

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Sat, 2007-03-31 17:27

Thanks valiant !
-------------------------
The Termite - - http://www.termitenshort.com/

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Sat, 2007-03-31 17:35

Well I left a bug in the upgrade path (forgot to include the helper class ) so I updated SVN to 1.1.2 so people can download it from the repository ...

See you !
-------------------------
The Termite - - http://www.termitenshort.com/

valiant

Joined: 2003-01-04
Posts: 32509

Posted: Sat, 2007-03-31 17:39

The DB change has influence on pretty much all files.
Please stop committing changes for a day.

(I noticed your bugfix. I had it in my changes as well.)

--------------
Documentation: Support / Troubleshooting | Installation, Upgrade, Configuration and Usage

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Sat, 2007-03-31 17:45

Yep, I wasn't gonna and that's why I let you know so you get the latest files first

Thanks a lot !
-------------------------
The Termite - - http://www.termitenshort.com/

valiant

Joined: 2003-01-04
Posts: 32509

Posted: Sat, 2007-03-31 18:26

The change is up for review at:
http://reviews.gallery2.org/index.jsp?page=ReviewDisplay&reviewid=183

--------------
Documentation: Support / Troubleshooting | Installation, Upgrade, Configuration and Usage

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Sat, 2007-03-31 19:26

This tool is nice

I finished the review of the code I think, it's up to mindless now

Thanks !!
-------------------------
The Termite - - http://www.termitenshort.com/

valiant

Joined: 2003-01-04
Posts: 32509

Posted: Sun, 2007-04-01 20:20

Ok, I've committed the changes from review 183 in revision 979.

Some things that should be done in the near future:
- Change required core API to at least 7,10 and module API to 3,2 (since you require dynamic album support)
- I tried to test edit album -> tags -> extend tags to sub-items / sub-albums, but that didn't work at all.
- Change TagsItemEdit to send its AJAX add / remove / .. (all change) requests to a new AJAX callback (examples: core SimpleCallback / PluginCallback).
The view class must override isControllerLike() and isImmediate(). Maybe you can reuse it for the tagging interface in the item summary.

--------------
Documentation: Support / Troubleshooting | Installation, Upgrade, Configuration and Usage

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Mon, 2007-04-02 04:07

valiant wrote:

Ok, I've committed the changes from review 183 in revision 979.

nice !

valiant wrote:

Some things that should be done in the near future:
- Change required core API to at least 7,10 and module API to 3,2 (since you require dynamic album support)

Make sense

valiant wrote:

- I tried to test edit album -> tags -> extend tags to sub-items / sub-albums, but that didn't work at all.

I haven't tried the new code yet but before the changes (v1.1.1), this functionality works fine. I'll do a quick test with the new code and see what happens.

valiant wrote:

- Change TagsItemEdit to send its AJAX add / remove / .. (all change) requests to a new AJAX callback (examples: core SimpleCallback / PluginCallback).
The view class must override isControllerLike() and isImmediate(). Maybe you can reuse it for the tagging interface in the item summary.

yes I was planning on doing this in the next version to have the possibility of an Ajax-based interface all from under the thumbnails (summaries)

It'll be nice !

-------------------------
The Termite - - http://www.termitenshort.com/

MagaSoft

Joined: 2006-12-18
Posts: 1

Posted: Mon, 2007-04-09 14:20

Hello,
I have some troubles with Tags module 1.2.0
1. When I try to delete any element from my gallery, I see this error:

Quote:

Fatal error: Call to undefined method TagsHelper::removealltags() in /home/root/modules/tags/classes/TagsHelper.class on line 306

and can't do it.
2. When I add tag for element, I can't see current tags:
[img]http://img372.imageshack.us/img372/4409/currentjd6.jpg[/img]
but I can see popular tags:
[img]http://img53.imageshack.us/img53/3610/popularyj0.jpg[/img]
Can anyone help me?

Termitenshort

Joined: 2005-10-09
Posts: 1894

Posted: Mon, 2007-04-09 15:33

Please update to version 1.2.2, that should fix both issues.

Thanks!
-------------------------
The Termite - - http://www.termitenshort.com/

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Sat, 2007-03-31 06:56
	Hello All, I have put version 1.1.1 of the Tags module in the gallery contrib so it can be downloaded from the plugin repository. Changes: - Added the rewrite rules - Removed the Maintenance task to get rid of Tags duplicates, made it an upgrade path function If you are upgrading from 1.0.0, 1.0.1 or 1.0.2, you should be good. If you are updating from 1.1.0, I would recommend running the maintenance task "delete duplicate tags" at least once See you ! ------------------------- The Termite - - http://www.termitenshort.com/
	XUser login Username: * Password: * Create new account Request new password
valiant Joined: 2003-01-04 Posts: 32509	Posted: Sat, 2007-03-31 13:45
	I've committed a style cleanup and some bugfixes for mdoule.inc. The db table cleanup upgrade step will follow. -------------- Documentation: Support / Troubleshooting \| Installation, Upgrade, Configuration and Usage

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Sat, 2007-03-31 17:27
	Thanks valiant ! ------------------------- The Termite - - http://www.termitenshort.com/

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Sat, 2007-03-31 17:35
	Well I left a bug in the upgrade path (forgot to include the helper class ) so I updated SVN to 1.1.2 so people can download it from the repository ... See you ! ------------------------- The Termite - - http://www.termitenshort.com/

valiant Joined: 2003-01-04 Posts: 32509	Posted: Sat, 2007-03-31 17:39
	The DB change has influence on pretty much all files. Please stop committing changes for a day. (I noticed your bugfix. I had it in my changes as well.) -------------- Documentation: Support / Troubleshooting \| Installation, Upgrade, Configuration and Usage

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Sat, 2007-03-31 17:45
	Yep, I wasn't gonna and that's why I let you know so you get the latest files first Thanks a lot ! ------------------------- The Termite - - http://www.termitenshort.com/

valiant Joined: 2003-01-04 Posts: 32509	Posted: Sat, 2007-03-31 18:26
	The change is up for review at: http://reviews.gallery2.org/index.jsp?page=ReviewDisplay&reviewid=183 -------------- Documentation: Support / Troubleshooting \| Installation, Upgrade, Configuration and Usage

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Sat, 2007-03-31 19:26
	This tool is nice I finished the review of the code I think, it's up to mindless now Thanks !! ------------------------- The Termite - - http://www.termitenshort.com/

valiant Joined: 2003-01-04 Posts: 32509	Posted: Sun, 2007-04-01 20:20
	Ok, I've committed the changes from review 183 in revision 979. Some things that should be done in the near future: - Change required core API to at least 7,10 and module API to 3,2 (since you require dynamic album support) - I tried to test edit album -> tags -> extend tags to sub-items / sub-albums, but that didn't work at all. - Change TagsItemEdit to send its AJAX add / remove / .. (all change) requests to a new AJAX callback (examples: core SimpleCallback / PluginCallback). The view class must override isControllerLike() and isImmediate(). Maybe you can reuse it for the tagging interface in the item summary. -------------- Documentation: Support / Troubleshooting \| Installation, Upgrade, Configuration and Usage

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Mon, 2007-04-02 04:07
	valiant wrote: Ok, I've committed the changes from review 183 in revision 979. nice ! valiant wrote: Some things that should be done in the near future: - Change required core API to at least 7,10 and module API to 3,2 (since you require dynamic album support) Make sense valiant wrote: - I tried to test edit album -> tags -> extend tags to sub-items / sub-albums, but that didn't work at all. I haven't tried the new code yet but before the changes (v1.1.1), this functionality works fine. I'll do a quick test with the new code and see what happens. valiant wrote: - Change TagsItemEdit to send its AJAX add / remove / .. (all change) requests to a new AJAX callback (examples: core SimpleCallback / PluginCallback). The view class must override isControllerLike() and isImmediate(). Maybe you can reuse it for the tagging interface in the item summary. yes I was planning on doing this in the next version to have the possibility of an Ajax-based interface all from under the thumbnails (summaries) It'll be nice ! ------------------------- The Termite - - http://www.termitenshort.com/

MagaSoft Joined: 2006-12-18 Posts: 1	Posted: Mon, 2007-04-09 14:20
	Hello, I have some troubles with Tags module 1.2.0 1. When I try to delete any element from my gallery, I see this error: Quote: Fatal error: Call to undefined method TagsHelper::removealltags() in /home/root/modules/tags/classes/TagsHelper.class on line 306 and can't do it. 2. When I add tag for element, I can't see current tags: [img]http://img372.imageshack.us/img372/4409/currentjd6.jpg[/img] but I can see popular tags: [img]http://img53.imageshack.us/img53/3610/popularyj0.jpg[/img] Can anyone help me?

Termitenshort Joined: 2005-10-09 Posts: 1894	Posted: Mon, 2007-04-09 15:33
	Please update to version 1.2.2, that should fix both issues. Thanks! ------------------------- The Termite - - http://www.termitenshort.com/

[Tags Module] New Version

XUser login