Test g2image v3.0beta over Drupal 5.x+gallery2.2.2+gallery module.

thidalgo

Joined: 2007-08-26
Posts: 20
Posted: Wed, 2007-08-29 19:58

Hi,

I have tested the new g2image version, the new function "exactsize" works fine!!
g2image add the tag, for example [G2:37 exactsize=446 ] or [G2:37 exactsize=640] according to the data introduced in the new field "Drupal G2 Filter "exactsize" attribute ". When pressing in the button to insert, appears tag in the content of Drupal.

In tinyMCE, to press button "g2image" and launch the program, I have received the following minor errors:

[b]<--begin copy-->
Notice: Undefined variable: g2ic_default_alignmen in /webs/tomashidalgo.nom.es/modules/tinymce/tinymce/jscripts/tiny_mce/plugins/g2image/init.php on line 31

Notice: Use of undefined constant CachedFileReader - assumed 'CachedFileReader' in /webs/tomashidalgo.nom.es/modules/tinymce/tinymce/jscripts/tiny_mce/plugins/g2image/gettext.inc on line 26

Notice: Use of undefined constant gettext_reader - assumed 'gettext_reader' in /webs/tomashidalgo.nom.es/modules/tinymce/tinymce/jscripts/tiny_mce/plugins/g2image/gettext.inc on line 29

Notice: Use of undefined constant __ - assumed '__' in /webs/tomashidalgo.nom.es/modules/tinymce/tinymce/jscripts/tiny_mce/plugins/g2image/gettext.inc on line 175
<-end copy-->

The first "notice" about g2ic_default_alignmen is a syntactic error. I have modified in the file init.php line $g2ic_options['default_alignment'] = $g2ic_default_alignmen; by $g2ic_options['default_alignment'] = $g2ic_default_alignment;. The error has disappeared.

Respect the others errors, I didn't find solution :-(

Thanks you very much for you help.

Tomas Hidalgo
 
capt_kirk

Joined: 2006-01-24
Posts: 492
Posted: Wed, 2007-08-29 20:18

Tomas,

Thank you. I've fixed the typo you pointed out and it will be in the next update.

For the other two errors, I think I left out quotation marks. (I'm not sure why I'm not getting the PHP warnings on my test bed. I thought I had turned on full PHP error reporting. I need to check into that more.)

Anyway, please try changing lines 26-31 in gettext.inc to read

if (!class_exists('CachedFileReader')) {
	require('streams.php');
}
if (!class_exists('gettext_reader')){
	require('gettext.php');
}

Please let me know if that clears up the errors.

Cheers,
Kirk
 
thidalgo

Joined: 2007-08-26
Posts: 20
Posted: Wed, 2007-08-29 20:56

Kirk,

Thanks for reply!!

The three errors have disappeared using the quotation marks.

Quote:
26 if (!class_exists('CachedFileReader')) {
27 require('streams.php');
28 }
29 if (!class_exists('gettext_reader')){
30 require('gettext.php');
31 }
. . . .
. . . .
. . . .
172/**
173 * Alias for gettext.
174 */
175 if (!function_exists('__')) {
176 function __($msgid) {
177 return _gettext($msgid);
178 }
179}

Great job!!

Thanks!!!

Tomas Hidalgo.
 
capt_kirk

Joined: 2006-01-24
Posts: 492
Posted: Wed, 2007-08-29 21:43

I'll go back and get the one at line 175, too.

Thanks for helping crush the typos!

Kirk