What happened to square thumbs?

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Thu, 2007-10-11 06:14

Dang, these forums are much harder to find what you are looking for than the previous ones... forgive me if I have missed this answer...

After upgrading to the 3.x version, my grid images in the sidebar are no longer square thumbnails (cropped)... How do I get the sidebar grid to obey the g2 square thumbnail stuff?

And out of curiosity, why did the g2 admin url rewrite get broken in this version? I know you said it was a g2 issue, but it worked great in the wpg2 2.x series...

Thanks for the work guys!

Visit Mr Papa's World
Visit Cruise Talk Central

capt_kirk

Joined: 2006-01-24
Posts: 492

Posted: Thu, 2007-10-11 11:17

Yeah, I don't like the overall setup of these forums. phpBB is better than Drupal for a forum. (galleryembedded.com was using phpBB, but G2 Forums use Drupal.) But we get the advantage of having the G2 core devs getting more insight into integration issues.

WPG2 shouldn't have broken the thumbnails. I have noticed that Gallery2 itself broke my square thumbnails, but I thought it was a problem on my server, and I haven't done much troubleshooting. When you upgraded to WPG2 3.0, did you also upgrade G2?

The admin link problem is actually a WP internal rewrite issue. Specifically, I think WP is not emulating the QSA (query string attach) flag for mod_rewrite rules. I have the entire rewrite string going into the internal WP rewrite array, but it's just not working. I spent about 10 hours trying different workaround, but finally gave up for now, since the admin link only really gives pretty URLs to the admin and not to users/search engines.

Kirk
____________________________________
G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Thu, 2007-10-11 14:22

Yeah, no big deal on the g2 admin url stuff as you mention... just mentioned it as odd since it was working in wpg2 2.x... have turned it off and already forgotten about it...

no, I did not upgrade g2 at the same time... I was/am running 2.2.1. All I did was upgrade the wpg2 to 3.x. The thumbnails in the sidebar grid (or sidebar) used to be cropped to square just like in g2... now they show up nonsquare. You can see it at Mr Papa's World link below. Each sidebar grid image has a "hardcoded" non-square size styling the image tag... will get to 2.2.3 once I get this squared (no pun intended) away...

All of the the thumbnails within g2 itself are still getting squared properly...

btw... this is the 3.0.1 version... just noticed you released a 3.0.2 version... will get it tonight...

thanks!

Visit Mr Papa's World
Visit Cruise Talk Central

capt_kirk

Joined: 2006-01-24
Posts: 492

Posted: Thu, 2007-10-11 14:44

Ahh. Those aren't thumbnails, they're the actual image. If you look at the image source, it's the same as the full-sized image in the resulting link. So, somewhere between WPG2 and G2's ImageBlock module, it's putting out the full-sized image constrained to a smaller size within the browser by the hard-coded size attributes.

Your G2 thumbnails are 150x150. Please make sure that "Sidebar Grid Thumbnail Size:" is set to 150 in the WPG2 -> Sidebar Grid Block admin tab.

Kirk
____________________________________
G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Thu, 2007-10-11 15:47

Interesting... changing the size to 150 did indeed fix the issue... previously, the wpg2 sidebar image size didn't have to match the g2 thumbnail size... I went back to some other sites I haven't upgraded to wpg2 3.x yet and verified that I could modify the size in wpg2 and it would scale appropriately and still maintain the square thumbnail... any chance of getting this on the list to be looked at for fixing/improvement?

Thanks again!

Visit Mr Papa's World
Visit Cruise Talk Central

capt_kirk

Joined: 2006-01-24
Posts: 492

Posted: Thu, 2007-10-11 16:00

It's not a bug, it's a feature! If you select a size that is larger than the thumbnails for your sidebar, it will allow it. Since you could have multiple sidebar blocks with different sizes set in the variables used to call the gridblock, you could have one larger block showing a smaller resize that is still larger than the thumbnails.

The code behind this didn't change. What changed is that the "exactsize" attribute in the G2 ImageBlock module works correctly in G2 2.2. It wasn't working quite right before, so it didn't get the resizes.

To be honest, I hadn't thought about the implications in the sidebar, and I doubt Ozgreg did either (but he's on his honeymoon now, not thinking about this stuff...) We may want to somehow restrict the sidebar images to thumbnails, or at least allow that as a configurable option.

Kirk
____________________________________
G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Thu, 2007-10-11 16:21

Suspected as much, which is why I included the words "improvement" :wink:

If you were to add the option as you indicated, would that thumbnail still be able to be scaled? ie be different than the exact g2 thumbnail...

Let's hope he isn't thinking about this on his honeymoon!

Thanks for the prompt replies...

Visit Mr Papa's World
Visit Cruise Talk Central

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Sat, 2007-10-13 07:56

Just noticed something interesting... it does square the thumbs/images up if they are smaller than or equal to the g2 thumbnail size... if the wpg2 thumbnail size is set to larger than the g2 thumbnail size, it is not squared...

Visit Mr Papa's World
Visit Cruise Talk Central

ClimbingMonkey

Joined: 2005-03-18
Posts: 62

Posted: Sun, 2007-10-14 07:54

Yep this is by design..

When generating a wpg2 thumbnail the code assumes that the g2 thumbnail is the one you want. If you specify a wpg2 thumbnail bigger than your current g2thumbnail it then looks at either the resized image or the original (I can't remember which) to generate the "mid-sized" image. Midsized image support is a feature that was initially requested by ozgreg and the wpg2 team. This new feature is now part of gallery2... YEA!!!!

---------------------------------------------------
Wordpress / Gallery2 (WPG2) Developer
My Site: http://www.marcnjami.com/

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Sun, 2007-10-14 08:48

hmmm... still think it would have been better to use the thumbnail bigger or smaller... not just smaller or equal...

Visit Mr Papa's World
Visit Cruise Talk Central

capt_kirk

Joined: 2006-01-24
Posts: 492

Posted: Sun, 2007-10-14 17:35

Mr Papa wrote:

hmmm... still think it would have been better to use the thumbnail bigger or smaller... not just smaller or equal...

Visit Mr Papa's World
Visit Cruise Talk Central

Yeah. That's a design trade. Browsers don't do a good job of upsizing images. They look grainy. That's why the ImageBlock "exactsize" function gets the next biggest and then "downsizes" it by including height and width in the HTML.

In WPG2 3.1, we're going to get rid of the reliance on the ImageBlock module, so we'll be able to do it one way in the posts, and another way in the sidebar. We'll have to look at how we handle thumbnail sizes then.

Kirk
____________________________________
G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa

Joined: 2006-07-19
Posts: 14

Posted: Sun, 2007-10-14 22:14

Sounds good...

Visit Mr Papa's World
Visit Cruise Talk Central

iRob

Joined: 2006-02-12
Posts: 48

Posted: Sat, 2007-10-20 16:42

capt_kirk wrote:

Ahh. Those aren't thumbnails, they're the actual image... Please make sure that "Sidebar Grid Thumbnail Size:" is set to 150 in the WPG2

Thanks, Kirk. This fixed my question too. All my G2 inserted images in blog posts were the full size, shrunk down to the thumb size I had selected in WPG2 (150px), when G2 was set to 100px. Fixed now! I appreciate the faster load times if the G2 thumbs are used rather than full images.

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Thu, 2007-10-11 06:14
	Dang, these forums are much harder to find what you are looking for than the previous ones... forgive me if I have missed this answer... After upgrading to the 3.x version, my grid images in the sidebar are no longer square thumbnails (cropped)... How do I get the sidebar grid to obey the g2 square thumbnail stuff? And out of curiosity, why did the g2 admin url rewrite get broken in this version? I know you said it was a g2 issue, but it worked great in the wpg2 2.x series... Thanks for the work guys! Visit Mr Papa's World Visit Cruise Talk Central
	XUser login Username: * Password: * Create new account Request new password
capt_kirk Joined: 2006-01-24 Posts: 492	Posted: Thu, 2007-10-11 11:17
	Yeah, I don't like the overall setup of these forums. phpBB is better than Drupal for a forum. (galleryembedded.com was using phpBB, but G2 Forums use Drupal.) But we get the advantage of having the G2 core devs getting more insight into integration issues. WPG2 shouldn't have broken the thumbnails. I have noticed that Gallery2 itself broke my square thumbnails, but I thought it was a problem on my server, and I haven't done much troubleshooting. When you upgraded to WPG2 3.0, did you also upgrade G2? The admin link problem is actually a WP internal rewrite issue. Specifically, I think WP is not emulating the QSA (query string attach) flag for mod_rewrite rules. I have the entire rewrite string going into the internal WP rewrite array, but it's just not working. I spent about 10 hours trying different workaround, but finally gave up for now, since the admin link only really gives pretty URLs to the admin and not to users/search engines. Kirk ____________________________________ G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Thu, 2007-10-11 14:22
	Yeah, no big deal on the g2 admin url stuff as you mention... just mentioned it as odd since it was working in wpg2 2.x... have turned it off and already forgotten about it... no, I did not upgrade g2 at the same time... I was/am running 2.2.1. All I did was upgrade the wpg2 to 3.x. The thumbnails in the sidebar grid (or sidebar) used to be cropped to square just like in g2... now they show up nonsquare. You can see it at Mr Papa's World link below. Each sidebar grid image has a "hardcoded" non-square size styling the image tag... will get to 2.2.3 once I get this squared (no pun intended) away... All of the the thumbnails within g2 itself are still getting squared properly... btw... this is the 3.0.1 version... just noticed you released a 3.0.2 version... will get it tonight... thanks! Visit Mr Papa's World Visit Cruise Talk Central

capt_kirk Joined: 2006-01-24 Posts: 492	Posted: Thu, 2007-10-11 14:44
	Ahh. Those aren't thumbnails, they're the actual image. If you look at the image source, it's the same as the full-sized image in the resulting link. So, somewhere between WPG2 and G2's ImageBlock module, it's putting out the full-sized image constrained to a smaller size within the browser by the hard-coded size attributes. Your G2 thumbnails are 150x150. Please make sure that "Sidebar Grid Thumbnail Size:" is set to 150 in the WPG2 -> Sidebar Grid Block admin tab. Kirk ____________________________________ G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Thu, 2007-10-11 15:47
	Interesting... changing the size to 150 did indeed fix the issue... previously, the wpg2 sidebar image size didn't have to match the g2 thumbnail size... I went back to some other sites I haven't upgraded to wpg2 3.x yet and verified that I could modify the size in wpg2 and it would scale appropriately and still maintain the square thumbnail... any chance of getting this on the list to be looked at for fixing/improvement? Thanks again! Visit Mr Papa's World Visit Cruise Talk Central

capt_kirk Joined: 2006-01-24 Posts: 492	Posted: Thu, 2007-10-11 16:00
	It's not a bug, it's a feature! If you select a size that is larger than the thumbnails for your sidebar, it will allow it. Since you could have multiple sidebar blocks with different sizes set in the variables used to call the gridblock, you could have one larger block showing a smaller resize that is still larger than the thumbnails. The code behind this didn't change. What changed is that the "exactsize" attribute in the G2 ImageBlock module works correctly in G2 2.2. It wasn't working quite right before, so it didn't get the resizes. To be honest, I hadn't thought about the implications in the sidebar, and I doubt Ozgreg did either (but he's on his honeymoon now, not thinking about this stuff...) We may want to somehow restrict the sidebar images to thumbnails, or at least allow that as a configurable option. Kirk ____________________________________ G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Thu, 2007-10-11 16:21
	Suspected as much, which is why I included the words "improvement" :wink: If you were to add the option as you indicated, would that thumbnail still be able to be scaled? ie be different than the exact g2 thumbnail... Let's hope he isn't thinking about this on his honeymoon! Thanks for the prompt replies... Visit Mr Papa's World Visit Cruise Talk Central

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Sat, 2007-10-13 07:56
	Just noticed something interesting... it does square the thumbs/images up if they are smaller than or equal to the g2 thumbnail size... if the wpg2 thumbnail size is set to larger than the g2 thumbnail size, it is not squared... Visit Mr Papa's World Visit Cruise Talk Central

ClimbingMonkey Joined: 2005-03-18 Posts: 62	Posted: Sun, 2007-10-14 07:54
	Yep this is by design.. When generating a wpg2 thumbnail the code assumes that the g2 thumbnail is the one you want. If you specify a wpg2 thumbnail bigger than your current g2thumbnail it then looks at either the resized image or the original (I can't remember which) to generate the "mid-sized" image. Midsized image support is a feature that was initially requested by ozgreg and the wpg2 team. This new feature is now part of gallery2... YEA!!!! --------------------------------------------------- Wordpress / Gallery2 (WPG2) Developer My Site: http://www.marcnjami.com/

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Sun, 2007-10-14 08:48
	hmmm... still think it would have been better to use the thumbnail bigger or smaller... not just smaller or equal... Visit Mr Papa's World Visit Cruise Talk Central

capt_kirk Joined: 2006-01-24 Posts: 492	Posted: Sun, 2007-10-14 17:35
	Mr Papa wrote: hmmm... still think it would have been better to use the thumbnail bigger or smaller... not just smaller or equal... Visit Mr Papa's World Visit Cruise Talk Central Yeah. That's a design trade. Browsers don't do a good job of upsizing images. They look grainy. That's why the ImageBlock "exactsize" function gets the next biggest and then "downsizes" it by including height and width in the HTML. In WPG2 3.1, we're going to get rid of the reliance on the ImageBlock module, so we'll be able to do it one way in the posts, and another way in the sidebar. We'll have to look at how we handle thumbnail sizes then. Kirk ____________________________________ G2Image Documentation, G2Image Demo Page, My Family Website

Mr Papa Joined: 2006-07-19 Posts: 14	Posted: Sun, 2007-10-14 22:14
	Sounds good... Visit Mr Papa's World Visit Cruise Talk Central

iRob Joined: 2006-02-12 Posts: 48	Posted: Sat, 2007-10-20 16:42
	capt_kirk wrote: Ahh. Those aren't thumbnails, they're the actual image... Please make sure that "Sidebar Grid Thumbnail Size:" is set to 150 in the WPG2 Thanks, Kirk. This fixed my question too. All my G2 inserted images in blog posts were the full size, shrunk down to the thumb size I had selected in WPG2 (150px), when G2 was set to 100px. Fixed now! I appreciate the faster load times if the G2 thumbs are used rather than full images.

What happened to square thumbs?

XUser login