New Module: favourites

Thanks Alec for the favorites module. It brings a very usefull feature that many Gallery users were missing.
I installed version 2.2.4 and it fixed the issue Chris was experiencing:

For version 2.2.4, could you please release a new "module.inc" that prevents "Add to Favorites" from appearing on Album pages? Thank you, Alec!

I think you're asking for something similar to ckawalek was for the flashnifitiessource module I wrote, which, after a bit of discussion we decided was outside the simple scope of the gallery structure: in this case the "add/remove to favourites" is declared as an "itemLink", in module.inc - starting around line 120 - so it appears alongside all the other itemlinks wherever they appear. As far as I know there's no simple way to determine the context for the link at the time it is required to be declared by the gallery API, and so no basis exists for a decision on whether to withold its declaration.

Sorry!

(love the heart icon btw)

Alec:
Thanks for your removing the (mistaken) dependence on dynamicalbum module. I've got some another questions.

1. Is it possible to show just 4 items next to oneself in Fav. album? This is just because my website have got the strict width and if the fav album shows more than 4 items in one row, it's going to be disorder.

2. I can't see the new "top10 favourites block". Actually I don't understand what's going on. Can you explain me, where I can find this option? Thanks

3. I agree with reusta's questions and I think it could be good to have it:

Thank you Alec for your support! I really appreciate it.

Hello,

I need your help: I want to add a link for add (remove) to favourites in the photo.tpl. I used this code:
{if ($theme.itemLinks)}
{foreach from=$theme.itemLinks item=item}
{if $item.moduleId == "favourites"}
<a href="{g->url params=$item.params}">{$item.text}</a> &#124;
{/if}
{/foreach}
{/if}

The link should be below the microthumbs, above the additional blocks like exif, viewcomments, addcomment. But when I add the link, the blocks below aren´t shown any more...? What´s wrong with my code for favourites?

Thanks,
Guevara

Guevara666: I'm sorry, I'm not really sure what you're trying to do, or what the problem is. Maybe a screenshot would help? You haven't said what theme you're using, either.

Probably...

try changing the AddFavourite.inc file at line 72 from:
$results['redirect'] = array ('view' => 'favourites.AddFavourite', 'itemId' => $itemId);

to

$results['redirect'] = array ('view' => 'core.ShowItem', 'itemId' => $itemId);

Hey,

Thanks for the module, I've been looking for something like this for a long time. I have a feature suggestion. It would be cool if a user could optionally share their favorites with other users (perhaps a configurable list of users)?

Thanks for your efforts in developing this module...it's what I was looking for (the cart features, although useful, don't address this as easily as your module). One feature that would be desirable is the ability to remove all the photos in favorites with one operation. As it is now (but I might have missed it) you have to delete each photo one-by-one. This would be useful if someone has built a gallery of favorites for a specific set of photos. When they are ready to move on to a different set of photos, all the current images in favorites need to be removed. Thanks for considering this.

Sounds a bit complicated, but hopefully someone will come up with a solution. Thanks again for your efforts.

Agree it should only show when viewing the favorites album. I would think placing it at the right end of the row just above the thumbs (i.e., the one that starts with "Favorites:username") would make the most sense. I don't know much about the code behind Gallery...can you put a conditional block (or whatever its called) in that row? I assume trying to do that is what led to your question above. The other location would be placing a "clumsy, ugly" block in the sidebar, but I've noticed that item actions don't show up there when you are viewing a keyword album, or the favorites album, so that might not work either. If it did, it would then show up when viewing keyword albums as well. Wish I knew more about the coding so as to offer better suggestions.

Hi,
Just wanted to say thanks for this module. Been watching and testing this one for a while. My only issue was needing a method of returning to the last view when adding to favourites. I found this snippet of code which when added gives me the desired result. Hopefully it'll be useful to someone!

Note: I commented out the redirect on line 83 and added the two new lines shown.

/** $results['redirect'] = array ('view' => 'favourites.AddFavourite', 'itemId' => $itemId); */
$returnUrl = GalleryUtilities::getRequestVariables('return');
$results['redirect']['href'] = $returnUrl;

Hi everybody, This favorite module is great, However, one issue I can't figure how: If I'm on the favorite view, I can not go back to the album through the breadcrumb line, maybe I overlooked, but I don't find any info in the discussion? anyone can give me suggestion? Thanks

Hi

I'm not sure how you can expect to go back to anywhere on the breadcrumb line except the Root as the favourites album is not a sub-album of any other album. Therefore I believe the correct breadcrumb to display is <<Root Album Name>> / Favourites: <<user Name>> which is what is displayed.

Sorry, wrong quote marks on the last post. Ben

Alec, Sorry for the delay in responding. I was thinking of having a shared favorites link. When you press on the link it would allow you to maintain a list of user names (to share your favorites) and a list of user favorites that have been shared with you. Would you want a mock up as an image?

Also, a silly question...how do you remove an album from your favorites? On my server the link stays as add album to favorites and there doesn't seem to be any way to remove the album from favorites as either a user or administrator. The images work fine. Or as an alternative...how do you prevent users from adding albums to their favorites?

OK, just for the benefit of anyone following, it was a caching issue that was solved by reducing the Gallery acceleration level from partial to none.

I'm unlikely to add this feature because it's not one I want to use - but feel free to add it yourself and send me the modifications, and I'll have a look.

Sorry - no clue.

If you narrow it down a bit more (doing what, exactly, causes the load? What do you mean by "in favorites module"? how many favourite images are you displaying? how many people?) that would help.

It's a pretty basic db query to fetch the favourites list, and the table is correctly keyed, so I don't think I can be of much help.

MySQL has a facility for logging slow queries that you could investigate.

hey,

great feature! especially along with the blocks like the "top 10"!

after installing I can chose "add to favorites" and "favorites" appears in the admin-menu. but then trying to access the dynamic album via the "favorites"-link there I get an "internal server error".

are there any inconsistencies known? do I need url-rewrite to be activated? or is it a bug?

I use

favorites 0.2.4

and

Gallery version = 2.2.6 core 1.2.0.8
PHP version = 5.0.5 cgi
Webserver = Apache/1.3.33 (Unix) mod_ssl/2.8.22 OpenSSL/0.9.7d SE/0.5.2
Database = mysqlt 4.1.22-standard-log, lock.system=flock
Operating system = Linux hex14.freehostia.com 2.6.24.3-SE #6 SMP Sun Mar 9 09:58:43 GMT 2008 i686
Default theme = nature
gettext = enabled
Locale = en_GB
Browser = Mozilla/5.

thanks already for hints!

thanks for reply! – by now i assume the problem originally stems from a server with "safe mode" and outdated system features. I will check soon on an appropriate server. in case this really was the root-cause, sorry for the stir.
I will give feedback later to verify.

The usual answer for "is it possible..." type queries for Gallery: No, unless you rewrite the code, in which case anything is possible.

Not a stupid question.

There's no specific order, I think it probably works out to the order they were picked in, latest first.

To sort by date you will need to modify function fetchFavourites(...) in modules/favourites/classes/FavouritesMapHelper.class.

At present that function uses GalleryCoreApi::getMapEntry(...). To sort by date you'd need to rewrite that as a SQL query (see further down the same file, eg function fetchUsersWithFavourites() and fetchUsernamesWithFavouritesLike(...) for inspiration) because you'll need to JOIN the relevant table in the db that has the date and use an ORDER BY clause. You can put an ORDER BY clause in a call to getMapEntry but you can't join a second table - hence the need to build the query manually.

Here is the mod, if other people are interested:

--- FavouritesMapHelper.class.ori 2009-01-28 03:35:29.000000000 +0100
+++ FavouritesMapHelper.class 2009-01-28 03:33:08.000000000 +0100
@@ -36,9 +36,20 @@
function fetchFavourites ($userId) {
global $gallery;

- list ($ret, $searchResults) = GalleryCoreApi::getMapEntry('FavouritesMap',
- array('itemId'),
- array('userId' => $userId));
+// --- Hack to sort items by date ---
+// list ($ret, $searchResults) = GalleryCoreApi::getMapEntry('FavouritesMap',
+// array('itemId'),
+// array('userId' => $userId));
+ $query = 'SELECT
+ [GalleryFavouritesMap::itemId]
+ FROM [GalleryFavouritesMap]
+ INNER JOIN [GalleryItem]
+ ON [GalleryFavouritesMap::itemId] = [GalleryItem::id]
+ WHERE [GalleryFavouritesMap::userId] = ?
+ ORDER BY [GalleryItem::originationTimestamp]
+ ';
+ list($ret, $searchResults) = $gallery->search($query,array($userId));
+// --- / end of hack ---
if ($ret) {
return array($ret, null);
}

Great module - thanks!

A really minor thing... How can I remove the colon after the word 'Favorites' in the breadcrumb trail (ie. it shows up as "Favorites:")? I've tried looking at module.inc and can't find it anywhere there, unless I'm missing something.

Help appreciated