G3 b1: config.php missing closing ?>

morton

Joined: 2005-09-19
Posts: 52
Posted: Sun, 2009-06-07 20:36

Minor issue here, but I noticed that my config.php file is missing the closing ?> at the end. I checked the distribution version and it is also missing in it.

After adding I did not notice any change in operations.

Cheers!
Steve
 
bharat
bharat's picture

Joined: 2002-05-21
Posts: 7994
Posted: Tue, 2009-06-09 04:06

You'll notice that *all* of our PHP files are lacking the closing ?>. This is a good coding practice for PHP. Omitting the ?> prevents the accidental injection of trailing white space into the response which breaks session headers and the page layout.
---
Problems? Check gallery3/var/logs before you post! and file bugs here!
Latest zip: http://github.com/gallery/gallery3/zipball/master
Latest git: http://codex.gallery2.org/Gallery:Using_Git
 
morton

Joined: 2005-09-19
Posts: 52
Posted: Tue, 2009-06-09 19:01

I guess my inexperance in PHP coding showing.I had never seen anything on that, but will keep that in mind for the future codeing.