Hi
Found that the slideshow feature of 1.4-pl1 don't respect the no-frame around pictures as when viewed manually. It still show a frame :-?
Fixed the no border now in slideshow.php:
line 73 changed to zero:
if (!strcmp($borderwidth, "off")) { $borderwidth = 0; // <- 1 altered to 0 here }
line 585 and on test on borderwidth zero:
<?php if ($borderwidth > 0) { ?> <tr bgcolor="<?php echo $borderColor ?>"> <td colspan=3 height=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td> </tr> <?php } ?> <tr> <?php if ($borderwidth > 0) { ?> <td bgcolor="<?php echo $borderColor ?>" width=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td> <?php } ?> <script language="JavaScript"> firstPhotoURL = document.getElementById("photo_urls_" + 1).href; document.write("<td><img border=0 src=\""); document.write(firstPhotoURL); document.write("\" name=slide></td>"); </script> <?php if ($borderwidth > 0) { ?> <td bgcolor="<?php echo $borderColor ?>" width=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td> <?php } ?> </tr> <?php if ($borderwidth > 0) { ?> <tr bgcolor="<?php echo $borderColor ?>"> <td colspan=3 height=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td> </tr> <?php } ?>
Can you please submit this fix as a patch? http://sourceforge.net/tracker/?group_id=7130&atid=307130
-Beckett (
)
Posts: 2
Fixed the no border now in slideshow.php:
line 73 changed to zero:
if (!strcmp($borderwidth, "off")) {
$borderwidth = 0; // <- 1 altered to 0 here
}
line 585 and on test on borderwidth zero:
<?php
if ($borderwidth > 0) {
?>
<tr bgcolor="<?php echo $borderColor ?>">
<td colspan=3 height=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td>
</tr>
<?php
}
?>
<tr>
<?php
if ($borderwidth > 0) {
?>
<td bgcolor="<?php echo $borderColor ?>" width=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td>
<?php
}
?>
<script language="JavaScript">
firstPhotoURL = document.getElementById("photo_urls_" + 1).href;
document.write("<td><img border=0 src=\"");
document.write(firstPhotoURL);
document.write("\" name=slide></td>");
</script>
<?php
if ($borderwidth > 0) {
?>
<td bgcolor="<?php echo $borderColor ?>" width=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td>
<?php
}
?>
</tr>
<?php
if ($borderwidth > 0) {
?>
<tr bgcolor="<?php echo $borderColor ?>">
<td colspan=3 height=<?php echo $borderwidth ?>><?php echo $pixelImage ?></td>
</tr>
<?php
}
?>
Posts: 3474
Can you please submit this fix as a patch?
http://sourceforge.net/tracker/?group_id=7130&atid=307130
-Beckett (
)