Latest Images / Most Viewed Hack

It looks as though there's a photo in the ul_2004_05_irland album that's causing the problem. I've added more debug to try and diagnose it. Download the latest version (2.01) from here and specify debug=3

Regards,

Jeremy

www.tearoom.me.uk

Wow. A lot of work.
I have deleted pretty much pics.
I deleted those pics where the debug-script stops.

And now:

Fatal error: out of dynamic memory in yy_create_buffer() in /homepages/30/*********/htdocs/domain2/modules/gallery/util.php on line 1032

Line 1022-1033 from my util.php
----------------------------------------

function getImagePath($name, $skinname='') {
	global $gallery;

	if (!$skinname) {
		$skinname = $gallery->app->skinname;
	}

	if (isset($gallery->app->photoAlbumURL)) {
		$base = $gallery->app->photoAlbumURL;
	} else {
		$base = '.';
	}

I did a quick search but didn't come up with anything, so I'm going to ask...

I just downloaded your stats package and when i run it, no matter what type I use, I get:

Upload Date: 01/06/2004
Viewed:
Fatal error: Call to undefined function: pluralize_n() in f:\apache2\htdocs\gallery\stats.php on line 1722

I'm on a win2k server with Apache running.
I'm running Gallary 1.4.4-cvs-b165

http://waffull.com

http://waffull.com/gallery/stats.php?type=date

Your help is greatly appreciated. This looks like an awsome addon.. Thank you for all your hard work!!!

Thinking about this again I don't think the above is correct. I suspect what was happening before you deleted some photos was that it was exhausting the available memory earlier. This happened in code where there was no friendly error message. After deleting the photos it now successfully gets through that code, only to run out of memory later when it attempts to display the results.

Regards,

Jeremy

www.tearoom.me.uk

Kai,

I wondered when someone would ask that question. I've thought about doing oldest already but no one asked for it so currently it's not supported. The code changes required should be fairly straightforward so when I get some time I will add oldest.

Regards,

Jeremy

Is there a way to exclude certain Albums and/or Sub-Albums?

Thanks for a great hack.

Don't know if I'm missing something but at least for me if you click next after your at page 10 it will go to 11 (as indicative in the URL) but it still says page numbers 1 through 10 (as opposed to 11-20).

Another issue is that gallery reports that I have 1572, while when I use stats.php hack it only says 1557.

This hack should definitely be a standard Gallery feature, Keep up the great work.

Yes it should.

stats does NOT interfere with the existing gallery code. You can safely extract the files from the tar and they should have no effect on the existing gallery files. There are two gallery patches for voting but you can ignore those if you don't want to change the way voting works.

Regards,

Jeremy

www.tearoom.me.uk

Jeremy,

thank you for implementing my suggestion in your script. :D

Kai

Hey thanks for the easiest mod I've ever used! Really gracefully done. Excellent.

I am having a teeny problem though. When I list stats by viewed, the first is 157, then 1422 and downward from there. Could it be that the 157 is corrupted or something?

Actually, as I look at it again indepth, the numbers are all over the place. It goes up and down within a group. Maybe I missed a fix for it here?

The path is www.bayarearailfan.org/gallery/stats.php?type=viewed

Thanks
Sam

I have been testing out GalleryV1.4.4 and stats.phpV2.02 and have discovered that the frame around the images is not the correct height.
Gallery V1.4.4 fixes a issue where the height of a frame can't be a percentage (html compliance as well as fixing a Safari issue).-- From inline_imagewrap.inc,v 1.28

The value ($gallery->html_wrap['imageWidth'] & $gallery->html_wrap['imageHeight']) that stats.php sent the inline_gallerythumb.frame and ultimately inline_imagewrap.inc where not correct because it uses a scaled image of the thumb.

I think I have a work around for this:
in stats.php
Look for

                           $iHeight = 100;
                           /*begin backwards compatibility */

and remove the next 2 lines:

$gallery->html_wrap['imageWidth'] = $iWidth;
$gallery->html_wrap['imageHeight'] = $iHeight;

skip this line $gallery->html_wrap['imageTag'] = $statsAlbum->getThumbnailTag($photoIndex, $thumbSize); and add:

						   $imgTag = $gallery->html_wrap['imageTag'];
						   $gallery->html_wrap['imageWidth'] = widthValue($imgTag);
						   $gallery->html_wrap['imageHeight'] = heightValue($imgTag);

Then further down find where the functions are:
<?php
/*
* Functions
*/
and add these to new functions:

function heightValue($str)
{
$start = 'height="';
$end = '"  border';
$lenStr= strpos($str,$end) -strpos($str, $start);
return substr(substr($str, strpos($str,$start), $lenStr), 8); 
}
function widthValue($str)
{
$start = 'width="';
$end = '" height=';
$lenStr= strpos($str,$end) -strpos($str, $start);
return substr(substr($str, strpos($str,$start), $lenStr), 7); 
}

The last 2 functions strip out the proper values of the height and width from the image tag that is sent to the inline_imagewrap.inc.

I don't think that the width needed to be fiddled with but I did it anyway.

see it in action on my V1.4.4 test gallery:
http://langleycom.com/g1/stats.php?type=date

floridave - thanks for looking into the problem with frame height and the latest Gallery code. I will try to add it next time I do a release.

Jenny - try changing the final "?" to a "&" - eg. http://server/modules.php?op=modload&name=gallery&file=index&include=stats.php&type=cdate

itcheg - I knew about page 10 not going to 11... I didn't think anyone would ever get that far but as you've raised it, I will try and fix it for the next release. For the other issue you raised...

This is caused by gallery reporting the number of images + albums while stats reports the number of images.

Regards,

Jeremy

www.tearoom.me.uk

That is great. Thank you. I just have one question, when an album isn't a album number is actually named like Out-of-Order, do I put that where it says "Album 1"?

What controls that way that the stats.php display things? Is that controlled in stats.php or does it call upon the header/footer that the gallery uses? The reason I'm asking is because I want to use the random image but I want a smaller area for it to place in a certain spot on the website. If you go here you can see what I mean, I would like to cut it in half basically so it takes up less space.
http://www.protoculturex.com/artgallery/stats.php?type=random&total=1

In gallery ver 1.4.4 RC1 stats.php seems not to like the showview function it complains that it can't get the views

Fatal error: Call to undefined function: pluralize_n()

I don't know much php but I commented out the showview function and it works (except for the views function of course)

[edit] A quick look in the ChangeLog for gallery v1.4.4-RC2 reveald in 1.4.4-cvs-b112 "* Change: Complete replace of pluralize_n with n2" so I changed the stats.php code

if ( $showViews &&
              !($statsAlbum->fields["display_clicks"] == "no") && 
              !$gallery->session->offline)
         {

            echo "<tr><td width=\"105\"><span class=\"fineprint\">Viewed:</span></td>";
            echo "<td><span class=\"fineprint\">";
            echo pluralize_n($statsAlbum->getItemClicks($photoIndex), "1 time", "times" , "0 times");
            echo "</span></td></tr>";
         }

where pluralzie_n should be pluralize_n2

(I don't know if this is right, don't know much php but it now seems to work fine) [/edit]

There's a new version of stats (2.03) here This supports Gallery 1.4.4rc1 and includes floridave's workaround for the image height issues. Thanks floridave for that.

Moritz - I like the idea of showing stats by month. I might do something if I get some time. A quick workaround could be to save the html generated by stats using IE or whatever each month, then use the admin option to reset the views counter for each album.

Shadow_Wolf

Yes use Out-of-Order or whatever the album name is - I used Album1 as an example. I'm not exactly clear what you mean by your second question but stats uses stats.header.default (or stats.header) and stats.footer.default (or stats.footer). These inturn include wrapper.header and wrapper.footer.

Regards,

Jeremy

www.tearoom.me.uk

Hi,

I have installed the latest stats.php and Gallery v1.4.5-cvs-b13. I am using Postnuke.

When accessing stats.php through standalone gallery, everything works fine, but when I try to access it through postnuke it says:

Fatal error: Failed opening required './stats.config.default.php' (include_path='.:/usr/share/pear') in /var/www/html/modules/gallery/stats.php on line 73

Is this a known problem, and if so, what am I doing wrong?

/Jenny

It seems that GALLERY_BASEDIR has become GALLERY_BASE in the latest version of Gallery.

kai_tom's workaround should do for now. I will change stats sometime soon.

Jeremy

www.tearoom.me.uk

@Jeremy: You did (and hopefully will continue doing so) an excellent job.
I like your STATS mod and am looking forwarding finding it integrated into one of the next versions.

Congratulations again

RaVen

bificypdog - what has changed since it last worked and what is the url of your website so I can see it for myself?

Regards,

Jeremy

www.tearoom.me.uk

one more question: ;-)

Is it possible to localize "stats" in the future?
I will help you with the german translation (it is much more better than my englisch) ,-)

Thanks guys for all your support

Jens is looking to get stats into Gallery. As he's the team lead for the translation team it's probably best if I let him arrange the localizing - particular as my language skills are limited to basic French and I've never localized php code before.

Regards,

Jeremy

www.tearoom.me.uk

I got something working using your script and the random block generator. I didn't modify header/footer because I didn't want it on EVERY page, only the front page. You guys can see what I did at my gallery, and give me any suggestions on how to improve the look, etc... I've noticed that sometimes the random block generator doesn't work.. the image just doesn't appear.

Other question:
Is the current version of stats.php (2.03) working with gallery 1.4.4 ?
Or will there be a newer release in the future?

Gallery is installed in \modules\gallery.
So there are stats.php and the config-file, too.

I changed the line 73 as following:
/www/htdocs/xxxxx/modules/gallery/

And now it is working.

Thank you very much Jeremy.

Heya!

Great hack, works fine for me, though i have some serious problems.

When i open my website it shows the 3 latest photo's

I include stats.php and i edited stats.php with the line

$type = "date"; so that wouldn't gave the variable "type" away.

This way i could include stats.php in my code.
But my navigation goes like this:

http://website/?page=home

When i navigate i get an error in my stats.php:

Error: Cache update required. [Update]

How can i stop that ?

to see my problem visit http://213.84.84.88/rch4n/ (webserver which is up 24/7)

well i hope to hear from you