Latest Images / Most Viewed Hack

LoL i already know what the problem was! :D

Appearently stats.php didn't like my ?page variable

because of the lines:

$uid = $gallery->user->getUid();
if ( !isset($pagee) )
{
$pagee = 1;
}

i changed every $page into $pagee andd now it works fine :D

does anyone know, after reading this post, how i can post the gallery stats on my home page (mambo) i want to show the total number of images and albums and i want to use it via an include, any help would be welcome!

i stripped the stats.php page to a minimum and put that as an include in my stats module in mambo. i am sure you can do this with any cms package. anyone wanting the edited stats.php file that only shows the amount of photo's and albums (as can be seen on www.digitalfrontier.nl - top right hand corner) can send me a PM.

@FloridaDave:
Thanks for your solution. It works.

But now it appears a new (old) error:

Fatal error: Allowed memory size of 20971520 bytes exhausted (tried to allocate 65537 bytes) in /www/htdocs/xxxxxx/modules/gallery/util.php on line 372

What to do?

3400 pics
PHP 4.3.8
Apache/1.3.27
Provider: www.all-inkl.com

@FloridaDave.
Thanks again.
I changed my .htaccess.

Now it works. But is this a normal value? What about the other gallery-users?

slo-foto,
you have 1.4.5-cvs-b219 stats.php has not been updated for this version yet. I will look at it after work today if this does not work:
look for require_once(dirname(__FILE__) . '/init.php'); and add

// added list to get the url variables from the url
list($type, $sca, $sal, $sde, $scd, $sud, $svi, $svo, $sra, $sco, $sac, $sav, $sao, $sgr, $rev, $ppp, $rows, $cols, $total, $ty, $tm, $td, $showGrid) = getRequestVar(array('type', 'sca', 'sal', 'sde', 'scd', 'sud', 'svi', 'svo', 'sra', 'sco', 'sac', 'sav', 'sao', 'sgr', 'rev', 'ppp', 'rows', 'cols', 'total', 'ty', 'tm', 'td', 'showGrid'));

Dave

try this on your "bleeding edge" version:

// added list to get the url variables from the url 
list($debug, $page, $type, $sca, $sal, $sde, $scd, $sud, $svi, $svo, $sra, $sco, $sac, $sav, $sao, $sgr, $rev, $ppp, $rows, $cols, $total, $ty, $tm, $td, $showGrid) = getRequestVar(array('debug', 'page', 'type', 'sca', 'sal', 'sde', 'scd', 'sud', 'svi', 'svo', 'sra', 'sco', 'sac', 'sav', 'sao', 'sgr', 'rev', 'ppp', 'rows', 'cols', 'total', 'ty', 'tm', 'td', 'showGrid'));

floridave: THANKS! Now work.

Regards,

Marjan

ok

this is the code passage that takes ALL time:

// Retrieve all albums and store in list array.
// This can be done using new AlbumDB() but this doesn't work
// on all hosts.
$numTopAlbums = $albumDB->numAlbums($gallery->user);

for ($i = 1; $i<=$numTopAlbums; $i++)
{
   $topAlbum = $albumDB->getAlbum($gallery->user, $i);
   $list[] = $topAlbum;
   recurseAlbums( $topAlbum );
}

shouldn't this only be called when cache isn't available or when cache is created?

since this population takes ALL time, THIS data should be cached ;)

nevermind...here's a quick fix

problem was the $list array was HUGE for large Galleries and took several secs to generate...and this is not required once a cache exists...

Also, as soon as a cache exists you only have to allocate a few albums, reading from top of the cache file...

Here's the fix

FIND AND DELETE

// Retrieve all albums and store in list array.
// This can be done using new AlbumDB() but this doesn't work
// on all hosts.
$numTopAlbums = $albumDB->numAlbums($gallery->user);
for ($i = 1; $i<=$numTopAlbums; $i++)
{
   $topAlbum = $albumDB->getAlbum($gallery->user, $i);
   $list[] = $topAlbum;
   recurseAlbums( $topAlbum );
}

$numAlbums = count($list);
if ($debug)
{
   echo "Number Albums = ". $numAlbums . "<br>";
}

FIND

if ( !$useCache )
{

AFTER ADD

// Retrieve all albums and store in list array.
// This can be done using new AlbumDB() but this doesn't work
// on all hosts.
$numTopAlbums = $albumDB->numAlbums($gallery->user);
for ($i = 1; $i<=$numTopAlbums; $i++)
{
   $topAlbum = $albumDB->getAlbum($gallery->user, $i);
   $list[] = $topAlbum;
   recurseAlbums( $topAlbum );
}

$numAlbums = count($list);
if ($debug)
{
   echo "Number Albums = ". $numAlbums . "<br>";
}

FIND

if ( $showGrid )
{
   $imageCellWidth = floor(100 / $numCols) . "%";
   $statsAlbums = array();
   $photoInfos  = array();
   $numPhotos = 0;
   for ($j = $startPhoto; $j < $totalPhotosToDisplay && $j < $startPhoto + $photosPerPage; ++$j) 
   {

AFTER ADD

      $photoInfo = $arrPhotos[$j];

      $childAlbumName = $photoInfo['albumName'];
      $childAlbum = new Album();
      $childAlbum->load($childAlbumName);
	  
      $statsAlbums[$numPhotos] = $childAlbum;
      $photoInfos[$numPhotos]  = $photoInfo;
      ++$numPhotos;

/*

FIND

      if (!$foundAlbum)
         $cacheReloadRequired = true;

AFTER ADD

*/

FIND

   for ( $j = $startPhoto + $numPhotos; $j < $totalPhotosToDisplay && $j < $startPhoto + $photosPerPage; ++$j)
   {
      $statsAlbums[$j] = NULL;
   }

REPLACE WITH

/*
   for ( $j = $startPhoto + $numPhotos; $j < $totalPhotosToDisplay && $j < $startPhoto + $photosPerPage; ++$j)
   {
      $statsAlbums[$j] = NULL;
   }
*/

FIND

        $photoInfo = $arrPhotos[$j];
         for ( $i = 0; $i < $numAlbums; ++$i )
         {
            if ( !strcmp($photoInfo['albumName'], $list[$i]->fields['name']) )
            {
               $statsAlbum = $list[$i];
               break;
            }
         }

REPLACE WITH

      	$photoInfo = $arrPhotos[$j];

      	$childAlbumName = $photoInfo['albumName'];
      	$childAlbum = new Album();
      	$childAlbum->load($childAlbumName);
	  
      	$statsAlbum = $childAlbum;

		/*
         $photoInfo = $arrPhotos[$j];
         for ( $i = 0; $i < $numAlbums; ++$i )
         {
            if ( !strcmp($photoInfo['albumName'], $list[$i]->fields['name']) )
            {
               $statsAlbum = $list[$i];
               break;
            }
         }
		*/

I'm having a weird problem when I try to run this script. In fact, I've never quite seen this particular behaviour before...

I go to where I've uploaded the script:

http://snapshots.arwen.org/stats.php

(Gallery itself is here: http://snapshots.arwen.org/)

...and, nothing happens. Well, in Firefox, nothing happens. In IE, it gives me the default "Cannot find server" nonsense.

I'm perplexed. Not being a programmer, I don't even know where to begin. I don't have access to my error logs, although I've requested them -- hopefully, they'll show something useful.

In the meantime... any ideas?

Thanks,
Donna

Are you using myriagon version or are you usng the version that comes with V1.5-cvs? If you are using the one with V1.5-cvs then I suggest you start a new thread.

Try adding $cdate to the list and cdate to the array like all the others.

myriagon. excellent!!!
i cannot understand why gallery doesnt use this? e.g. a small table at left with clickable last images.. well well.

Version 1.5 will have this. It is only slighly different. test the latest bleeding edge version.

Dave

dbmathis,
I know the thread is 22 pages long but I have read them all..... Yes it can be done:
http://gallery.menalto.com/index.php?name=PNphpBB2&file=viewtopic&p=86408#86408
and the next couple of posts.
Try links like:
modules.php?set_albumName=&op=modload&name=gallery&file=index&include=stats.php&type=views

I figured it out. I had error reporting turned offf in my php.ini file for security purposes and could not figure out why i was getting a blank screen instead of errors..

My basedir in stats.php was set wrong for the config file.

Thanks guys and gals.

myriagon,

i noticed on your website when you viewed a picture there was a link at the bottom to vote for the pictures and the vote information. Can you give me some hints on how you did this?

thanks and great job very impressive.

JonHurtt,

so i have found out where to place the link... i just need the code to generate the link... i think i might have figured it out but

what are the variable names for the albums name, pic name and link?

that should put me on my way... i am also going to get it work embedded in PostNuke

Thanks Dave for all your help on this thread.

Jon - My Gallery implementation was heavily modded to add a new voting type "simple". I can select this type in admin mode in the same way that you can select "rank" or "critique" voting IIRC. My code is still based on an old Gallery version so the code may not look exactly as it is now. Anyway FWIW here's how my view_photo.php looks now:

if ( canVote() )
{
       echo makeFormIntro("view_photo.php", array("name" => "vote_form",
                                       "method" => "POST"));
   ?>
   <script language="javascript1.2" type="text/JavaScript">
 function chooseOnlyOne(i, form_pos, scale)
 {
   for(var j=0;j<scale;j++)
     {
         if(j != i)
           {
               eval("document.vote_form['votes["+j+"]'].checked=false");
           }
    }
    document.vote_form.submit("Vote");
 }
   </script>
       <?php
       print "<input type=hidden name=id value=$id>";
       addPolling("item.$id", -1, true, $index, $id);
       print '</form>';
}
if (  $gallery->album->getPollType() == "simple" &&
      $gallery->album->getItemSVotes($index) > 0 )
{
     echo "<span class=\"modcaption\">Votes: ". $gallery->album->getItemSVotes($index)."</span>";
}

I had to change the call to addPolling() to pass extra data in - not nice...

The code in my util.php to support this is:

function addPolling ($id, $form_pos=-1, $immediate=true, $index=-1, $realid=-1)
{
        global $gallery;

        if ( $gallery->album->getPollType() == "simple" && !$immediate )
        {
                return;
        }
        if ( !canVote())
        {
                return;
        }
        if (isset($gallery->album->fields["votes"][$id][getVotingID()])) {
                $current_vote =
                        $gallery->album->fields["votes"][$id][getVotingID()];
        } else {
                $current_vote = -1;
        }
        $nv_pairs=$gallery->album->getVoteNVPairs();
        if ( $gallery->album->getPollType() == "simple" )
        {
                if ( !$gallery->session->votedForItem[$gallery->session->albumName][$realid])

                {
                        $urlargs['set_albumName'] = $gallery->session->albumName;
                        $urlargs['id'] = $realid;
                        $urlargs['url'] = urlencode(makeGalleryUrl("view_photo.php", $urlargs));
                        echo "<a href=\"" . makeGalleryUrl("vote.php", $urlargs) . "\">";
                        print $gallery->album->getPollHint();
                        echo "</a><br>";
                }
        }
        else
        {
                print $gallery->album->getPollHint();
        }
        if ($gallery->album->getPollScale() == 1 && $gallery->album->getPollType() == "critique")
        {
...etc.....

I must admit that I wasn't very happy with this code and what I had to do to workaround the existing code. You might be better off following Dave's more straightforward approach.

Jeremy

Hi,

Great piece of code and it works fine.

I have it (alomst) running on my nuke site (uae-photo.com). To make it visible in the modules, I created a new folder and placed the php files in there, changed the reference to $GALLERY_BASEDIR, which now points to my gallery. So far so good.

However the appearance is not like it is embedded, but like the standard gallery page. Which (line of) code do I need to change to make it look embedded, like my gallery is?

Another question: no matter which variable I change the appearance remains the same. Which variables do I need to change to get the same pictures selected as shown in this link

Appreciate the input.

Henk

I'm installing Gallery on my Geeklog-driven site, and would love to try this mod, it sounds great.

Unfortunately I can't get to the tearoom web site at all, maybe it's down temporarily...all I see is the top-level directory tree, and going directly for the download is "not found".

So is there an alternate download site, or does anyone have the most recent stable tarball you could send?

Thanks for any help!

Tom in Colorado Springs, Colorado, USA

Oh man, that sucks! Sorry to hear it, sounds like the recovery has been painful...

I'm still not getting your index page or the download. I'm using the links given at the very start of this thread, maybe there's newer links? Or maybe there's some server caching the pages between here (Colorado, USA) and your server that hasn't flushed yet.

www.tearoom.me.uk - shows files & dirs in the top-level web directory
www.tearoom.me.uk/stats.tar.gz - gets 404 not found

I'll simply be patient, I'll check back either late tonight or tomorrow morning, these are USA "mountain zone" times.

Again, sorry about your loss there...

Tom

Hi, I hope this isn't something I'm not supposed to ask because I'm trying to do something embedded in another CMS...I'm using Gallery inside GeekLog, a fairly standard PHP CMS web application.

Love Gallery! Love this plugin!

However, I'm trying to use it to display 3 random photos inside a right-column set of block items. I've following the readme's instructions to call it with ?type=random&sca=0&sal=0&sde=0&sco=0... and all the rest of the options available on the URL call, ending with 120-pixels 3-photos 3-max-photos 3-rows 1-col.

(I could set all these in the config file, but that'd prevent other full-page calls to gallery/stats.php.)

That above call gets the thumbnails just fine, but stats.php "wraps" itself within the Gallery HTML, and I want just the 3 images.

Can stats be used to only output the 3 photo thumbnails, nothing else (without extensive customizaation)? Or am I really using the wrong mod to get a column of 3 thumbnails?

Maybe what I really want is instead of calling stats.php, to dissect the code and figure out what proc call it makes when it's ready to output the thumbnails...any hints appreciated.

Thanks for any help! Tom

It should. I doubt that there is any issues.....read the first post and try it out. It is very simple. and there is a README with the script.

Dave