Fair call. I have tried to contribute to the limit of my modest coding skills. I have made code and codex contributions where module owners seem to have vanished. In this case I would want to be sure that rWatcher was happy with me updating that page. I know it's a community resource, but there are certain protocols to be observed.
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Wed, 2011-05-18 17:40
undagiga wrote:
Fair call. I have tried to contribute to the limit of my modest coding skills. I have made code and codex contributions where module owners seem to have vanished. In this case I would want to be sure that rWatcher was happy with me updating that page. I know it's a community resource, but there are certain protocols to be observed.
U-G
I've made the requested updates to the forum topic and to the codex page.
In the future, please feel free to make whatever codex updates you feel would be helpful for this, or any of my other modules.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2011-05-26 01:49
I've got two new issues. The first is relatively minor. As you know, you assisted me to get the breadcrumbs trail right when using the All Tags module and also with a renamed All Tags module. Now I've started to use the other feature of Tag Albums, virtual albums that appear on regular thumbs pages. The problem is that the breadcrumbs trail says "All Tags" or "Renamed All Tags", rather than the virtual album that I clicked on. I can think of a kludge that would fix this for my site, but is there a more general fix that you can think of? (You should be aware that due to laziness on my part I'm still using my original kludge for the breadcrumbs rather than the more elegant one you pushed to GIT - I don't think that using yours would fix this particular problem, would it?)
A second and more serious problem is that there's some conflict between the latest version of Dave's Facebook Like module and Tag Albums when using Greydragon. If you go to my test site and click on the album named "Virtual" you will see a page with no thumbs. If you look at the source you will see that there's a large chunk of code missing. This is not a problem if I switch to the Wind theme, so I assume that there's an issue with the GD-specific elements. Can you give me some tips where to look?
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Thu, 2011-05-26 18:08
undagiga wrote:
I've got two new issues. The first is relatively minor. As you know, you assisted me to get the breadcrumbs trail right when using the All Tags module and also with a renamed All Tags module. Now I've started to use the other feature of Tag Albums, virtual albums that appear on regular thumbs pages. The problem is that the breadcrumbs trail says "All Tags" or "Renamed All Tags", rather than the virtual album that I clicked on. I can think of a kludge that would fix this for my site, but is there a more general fix that you can think of? (You should be aware that due to laziness on my part I'm still using my original kludge for the breadcrumbs rather than the more elegant one you pushed to GIT - I don't think that using yours would fix this particular problem, would it?)
This issue appears to be specific to using "3rd party" modules, Tag Albums "all tags albums" maintain correct breadcrumbs, but all that information is lost during the URL redirect to a seperate module's page. I've added a "?album=#" code onto the end of the URL redirect in the current experimental code, and updated my tag url generation modification to look for this code and use it to generate correct breadcrumbs, so this should now be fixed
undagiga wrote:
A second and more serious problem is that there's some conflict between the latest version of Dave's Facebook Like module and Tag Albums when using Greydragon. If you go to my test site and click on the album named "Virtual" you will see a page with no thumbs. If you look at the source you will see that there's a large chunk of code missing. This is not a problem if I switch to the Wind theme, so I assume that there's an issue with the GD-specific elements. Can you give me some tips where to look?
U-G
It's trying to check the view permission on the current item, which it can't do because tags and dynamic pages aren't Gallery items. This should now be fixed in the current experimental code, which I've attached to this post.
mrf00rk
Joined: 2005-06-02
Posts: 158
Posted: Thu, 2011-05-26 10:08
rWatcher wrote:
I think I've got everything working with Grey Dragon -- attached is an updated version of the module.
Installation:
Copy the contents of tag_albums/greydragon/views into themes/greydragon/views then remove the tag_albums/greydragon folder. Delete the current modules/tag_albums folder and then replace it with the one in this zip file (to make sure the old view files all get removed). Otherwise this module installs as normal..
Is this still relevant? I tried it now and got a "Dang.."
@ mrf00rk: working for me, subject to the comments below.
@ rWatcher: Yup, that fixes both those problems, but I have a new one. The paginator isn't working on the tag albums thumbs pages, in that it thinks that there aren't any more pages when in fact there are. You can see this on my test site - there is a virtual album on the front page called "rWatcher", and this album should have 193 thumbs, but there's only one page of them. The changes in the experimental version seem rather small, and I've spend some time trying to spot what causes this. I'm sad to say that I haven't. I suspect it's something to do with the setting of $album_id.
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Wed, 2011-09-14 21:32
undagiga wrote:
@ rWatcher: Yup, that fixes both those problems, but I have a new one. The paginator isn't working on the tag albums thumbs pages, in that it thinks that there aren't any more pages when in fact there are. You can see this on my test site - there is a virtual album on the front page called "rWatcher", and this album should have 193 thumbs, but there's only one page of them. The changes in the experimental version seem rather small, and I've spend some time trying to spot what causes this. I'm sad to say that I haven't. I suspect it's something to do with the setting of $album_id.
U-G
This is caused by my "fix" for facebook like. Upon further investigation, I believe this is actually a bug in the facebook like module, as I'm seeing the same issue on every other dynamic page (including gallery's built in tag pages), so I've reverted the change for the time being. I suggest not using the "Show on top of sidebar." / "Show on bottom of sidebar." options until this can be resolved.
Thanks very much. I suspected as much. It all seems to be working for me. It's a really great module, but I guess you already knew that I thought that!
U-G
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Tue, 2011-05-31 02:37
I had an idea. If it's a simple one then well and good but if it's too hard then don't worry about it.
Is there any way that Tag Albums could pick up the dynamic collections that your Dynamic module creates? I'm interested in a couple of virtual album thumbs on the home page for most recent and most popular.
Integrating the two together would potentially be a lot of work, as the database queries used are completely different. I'll have to think about if there's any easy way to do this, but this might be something that will have to wait until there's official support in Wind and GD for custom breadcrumbs and whatnot, so that I can write a more complex virtual albums module without all the theme overrides.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Tue, 2011-05-31 04:33
OK, thanks. Leave it for the moment.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sat, 2011-06-04 03:46
Can I ask yet another (dumb) question please?
How stable are the URLs generated by this module. If I add new tags, will some of these URLs change? If I add new virtual thumbs albums, will some of these URLs change? For example, if I click on a virtual album thumb, I get a page of thumbs with this URL:
Will numbers like 4, 594 & 0 change when new tags, images or albums are added? Similarly if I navigate to the same image using the All Tags module, I get:
And I have the same questions? The motivation for my question is partly about whether it's safe for people to link to these URLs, and partly about minimising 404s in search engines.
Thanks
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Sat, 2011-06-04 04:53
The numbers correspond to id numbers in the database. The only reason they would change would be if the corresponding record was deleted and then recreated (for example if you deleted and then re-uploaded a photo).
More detailed explanation: http://www.mysite.com/tag_albums/album/4/album-name.html
4 is the ID number that was assigned to the virtual album when you linked the real album to the dynamic page. If you converted it back to a regular album, "4" would be deleted, and converting it back to a virtual album again would assign it a new (higher) number. Otherwise that number won't change.
Thanks for the explanation, that's reassuring. I noticed that Google webmaster tools has some 404s for some tagged photos, but I think that's because before this module I had duplicates of some photos in special albums. Once I was able to create virtual albums using tags I was able to delete the duplicates and special albums. I *think* that Google's 404s are for these images, or perhaps for the original dynamic tag albums, or both.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sat, 2011-06-25 15:19
rWatcher
Can I ask for some advice please? I've been hacking the album tree module so that it is formatted normally on photo pages and differently on the rest. Of course this requires some code that tests whether or not the page is a photo page. Elsewhere I've used if ($theme->item->is_photo()) { but if I use that here for some reason it causes tag album pages to crash. After a lot of trial and error I've got it to work, but only after borrowing some code from Tag Albums to count if there are any tag albums or items on the current page and avoid the if test if there are. Why does this if test cause a crash and is there a more elegant way to deal with this problem?
Thanks for any advice.
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Sat, 2011-06-25 17:52
Without seeing the exact code, I can't be sure, but my guess would be that if you call $theme->item->is_photo() on a page that's not an item then the is_photo function won't exist, thus causing a crash. You probably need to do something like: if (($theme->item()) && ($theme->item->is_photo())) {
That way it'll check and make sure you're looking at an item before calling the is_photo function.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sun, 2011-06-26 12:02
I had the impression from looking at the Tag Albums code that you must have encountered the same problem and found workarounds. E.g. in some of the .html.php files there is the use of $title rather than $item->title with some associated comment. I.e. I thought you would know rather than be guessing.
The good news is that your guess worked, so I assume you did know. But I have to admit I don't understand why it did. I would have thought that both elements in that if statement would need to be valid, but it seems not, so I guess it just shows how little I understand PHP.
Thanks. Much appreciated.
U-G
sifaan
Joined: 2011-07-11
Posts: 3
Posted: Mon, 2011-07-11 02:32
Hi!
This is my first post here and I'm rather new to G3, although I did play around with G2 a while back, so apologies if I'm treading on toes or asking silly newbie questions.
Is there anyway (this module or otherwise) that can show dynamic albums with multiple tags - e.g. if I have a tag called face and a tag bw, I can see (even without this module) the images tagged with face (/index.php/tag/2/face)or the images tagged with bw (/index.php/tag/4/bw)) - but is there some way I can see pictures tagged with bw and face?
I was rather hoping that this module would let me to "drill down" through tags - e.g. if I view the face album, I see a bw subalbum (as well as for any other tags that have at least 1 picture in common with the face tag)
Thank you
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Mon, 2011-07-11 06:29
sifaan wrote:
Hi!
This is my first post here and I'm rather new to G3, although I did play around with G2 a while back, so apologies if I'm treading on toes or asking silly newbie questions.
Is there anyway (this module or otherwise) that can show dynamic albums with multiple tags - e.g. if I have a tag called face and a tag bw, I can see (even without this module) the images tagged with face (/index.php/tag/2/face)or the images tagged with bw (/index.php/tag/4/bw)) - but is there some way I can see pictures tagged with bw and face?
I was rather hoping that this module would let me to "drill down" through tags - e.g. if I view the face album, I see a bw subalbum (as well as for any other tags that have at least 1 picture in common with the face tag)
Thank you
You could use this module to create a custom "dynamic album" that would contain everything tagged with both face and bw, but there's no way to dynamically drill down as you're browsing photos.
sifaan
Joined: 2011-07-11
Posts: 3
Posted: Mon, 2011-07-11 11:28
rWatcher wrote:
You could use this module to create a custom "dynamic album" that would contain everything tagged with both face and bw, but there's no way to dynamically drill down as you're browsing photos.
Thanks for the clarification; am I correct to understand that while it's not possible to do what I am looking for with this module, it's only really a case of user interface? i.e. if I can create a dynamic album of tag (unions) as an admin, it means it is possible to query the database for photos that have all the required tags.
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Mon, 2011-07-11 16:00
sifaan wrote:
rWatcher wrote:
You could use this module to create a custom "dynamic album" that would contain everything tagged with both face and bw, but there's no way to dynamically drill down as you're browsing photos.
Thanks for the clarification; am I correct to understand that while it's not possible to do what I am looking for with this module, it's only really a case of user interface? i.e. if I can create a dynamic album of tag (unions) as an admin, it means it is possible to query the database for photos that have all the required tags.
Correct.
Basically, what this module lets you do is create an album, and then when you edit the album options you can specify one or more tags. Then when a user clicks on the album, they'll be directed to a page populated with photos that contain those tags. You don't actually need to be an admin to do this, any Gallery user with the ability to create a new album can take advantage of it.
sifaan
Joined: 2011-07-11
Posts: 3
Posted: Tue, 2011-07-12 14:27
hmmm... a workable solution for my needs (for people to be able to find pics by tags) would be if functionality was shown as a "search for pictures by tags" rather than as creating an album (and a one-step process where maybe it automatically calls the album "pictures tagged with X,Y, AND Z" or even "pictures tagged with X, Y OR Z"; although there can be a complication in automatically deleting the album - otherwise every search would create a new album and create a total mess)
would this be hard to do?
(it would perhaps be simpler if the search box did just that - but I can't seem to figure how to get it to combine tags with AND operator)
edit: just realized that I need to have the + as "xxx +yyy" or it doesn't work
zjohn13
Joined: 2010-12-01
Posts: 94
Posted: Tue, 2011-09-13 13:41
I'm trying to set up Tag Albums with the All Tags link but seem to be missing a trick.
I'm using the Clean Canvas theme.
Via Tag Albums Admin I've selected "All Tags module" as the "Tag Albums index"
Installed "Module order" module and moved "All tags" above tags.
When I click on "View Tag Albums" in the Sidebar, the "All Tags" page list of tags is displayed.
I click on a tag and the tagged photo thumbnails are displayed.
But, when I click on a thumbnail I enter the photo page in the photo's album sequence instead of the virtual tag album sequence.
As an aside, if "(default) Individual Tag Albums" is selected via Tag Albums admin I do get the virtual gallery of images to step through although all the pages are broken Gallery Wind theme pages.
Any suggestions as to what I've missed please.
Thanks
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Tue, 2011-09-13 17:59
zjohn13 wrote:
I'm trying to set up Tag Albums with the All Tags link but seem to be missing a trick.
I'm using the Clean Canvas theme.
Also, it sounds like you may have moved the wrong module via the Module order screen:
zjohn13 wrote:
Via Tag Albums Admin I've selected "All Tags module" as the "Tag Albums index"
Installed "Module order" module and moved "All tags" above tags.
rwatcher wrote:
To adjust tag links found elsewhere in the Gallery so that they point to the Tag Albums module, install / activate the "Module Order" module ( http://codex.gallery2.org/Gallery3:Modules:moduleorder ), then select Admin -> Settings -> Module order and move "Tag Albums" above Tags. This will cause all tag links (including the All Tags module) to point to Tag Album pages (Warning: Only tested with Gallery 3.0.1).
zjohn13
Joined: 2010-12-01
Posts: 94
Posted: Wed, 2011-09-14 09:24
Many thanks rWatcher, you are right on both counts.
Things are looking much better but I now have another issue.
As before, via Tag Albums Admin I've selected "All Tags module" as the "Tag Albums index"
When I click on a tag, only the first 12 tagged photo thumbnails are displayed.
The Previous and Next buttons are greyed out and "No photos" is display at foot of page.
See attached screen snip.
If I click on a thumbnail I do now enter the photo page in the virtual tag album sequence
and I can step via Next/Previous through all the tagged photos.
Also, if I'm viewing a photo that was not displayed in the first 12 thumbnails and I click the tag name in the breadcrumb line I get a different 12 thumbnails page, incuding one of the photo I was viewing, but still the same issue as above.
I hope I'm not becoming too high maintenance with this module.
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Thu, 2011-10-13 00:16
Here is the latest version of Tag Albums, which should fix all known issues.
It has been tested with Gallery 3.0.2 using Wind, Clean Canvas and GreyDragon (for clean canvas and grey dragon you will need to copy the contents of the theme files/THEMENAME/views folder to your themes/THEMENAME/views folder).
zjohn13
Joined: 2010-12-01
Posts: 94
Posted: Fri, 2011-09-16 09:34
Excellent rWatcher, everything is now working fine, a great module in combination with undagiga's All tags module.
Hopefully, for the benefit of future Gallery3 users these great tagging modules will one day be incorporated into the core Tag module.
All I need to do now is work out how to customise the thumbnail page to remove the Title display from below the thumbnails
palli
Joined: 2011-09-28
Posts: 1
Posted: Thu, 2011-10-06 18:13
Thanks for a very nice module!
I am using version 3.0.2 (Coollanta) of Gallery 3, "slide show ex" Version 1.5 and Shadowbox version 1.8
My problem is that the slide show begins with the first photo from the original album (the "home" album for that photo) and continue with that album.
Same problem with the bult-in slide show.
Pushing the "next" button in shadowbox shows the next photo in the original album.
The slide show is using the rss feed from the album and I guess that shadowbox is using it too.
My conclusion is some problems with the rss feed from Tag Albums.
Any idea?
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Mon, 2011-10-10 08:54
rWatcher
I'm sorry to say that I'm going to need help getting tag albums to work with Greydragon 3.1.0. I've looked at the modified view files that you ship with Tag Albums, and done my best to migrate the changes to 3.1.0. But alas, it doesn't work. I've attached my attempt.
U-G
mikeya
Joined: 2011-10-10
Posts: 2
Posted: Mon, 2011-10-10 19:07
I am trying to accomplish the following;
Only show pictures through tag albums.
I have a bunch of pictures with several tags added. I have also created new albums and then edited them to only show specific tags.
Now what I would like is that these albums are the ONLY way to see my pictures.
Currently people can still see all my pictures by simply going to /index.php . That lands them in the gallery root and thus shows all pictures/albums.
I don't care about security; eg I don't care people will still be able to see my pictures by using a direct link for example.
It is just that I don't want people to randomly browse through the gallery.
Perhaps a bit confusing, but I hope you catch my drift.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Tue, 2011-10-11 13:50
I've worked out the issue with Tag Albums in Greydragon 3.1.0, sort of. In addition to the mods in the zip in my above post, in the theme the parameter "thumb_topalign" is now "thumb_imgalign". If you make this change (one instance only) in tag_albums_album.html.php then Tag Albums will work, up to a point.
However, the alignment of the thumbs won't be right, unless you chose top alignment. There is a bunch of code that needs to be replaced that calculates the thumb placement based on "thumb_imgalign". I'm still working on this - not sure just how much new code to bring in.
rWatcher - I take it that you're not around at present?
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Wed, 2011-10-12 22:15
palli wrote:
Thanks for a very nice module!
I am using version 3.0.2 (Coollanta) of Gallery 3, "slide show ex" Version 1.5 and Shadowbox version 1.8
My problem is that the slide show begins with the first photo from the original album (the "home" album for that photo) and continue with that album.
Same problem with the bult-in slide show.
Pushing the "next" button in shadowbox shows the next photo in the original album.
The slide show is using the rss feed from the album and I guess that shadowbox is using it too.
My conclusion is some problems with the rss feed from Tag Albums.
Any idea?
Shadowbox should work fine if you're using the GreyDragon theme. The other sideshow's that use the RSS feed won't work properly as the RSS feed will refer to the actual album and not the virtual album.
undagiga wrote:
rWatcher
I'm sorry to say that I'm going to need help getting tag albums to work with Greydragon 3.1.0. I've looked at the modified view files that you ship with Tag Albums, and done my best to migrate the changes to 3.1.0. But alas, it doesn't work. I've attached my attempt.
U-G
Looking into it, will report back when it's fixed
mikeya wrote:
I am trying to accomplish the following;
Only show pictures through tag albums.
I have a bunch of pictures with several tags added. I have also created new albums and then edited them to only show specific tags.
Now what I would like is that these albums are the ONLY way to see my pictures.
Currently people can still see all my pictures by simply going to /index.php . That lands them in the gallery root and thus shows all pictures/albums.
I don't care about security; eg I don't care people will still be able to see my pictures by using a direct link for example.
It is just that I don't want people to randomly browse through the gallery.
Perhaps a bit confusing, but I hope you catch my drift.
Here's the updated Tag Albums module with GreyDragon 3.1.0 support. Everything seems to work fine for me, but if I missed something let me know.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2011-10-13 00:21
rWatcher wrote:
Looking into it, will report back when it's fixed
Thanks!!!! I thought perhaps you were away. I was going to set some time aside today to try and finish the job, as I decided that I needed to become more self-sufficient. It's a lot of work for you to upgrade these view files each time there's a release, and there are a lot of GD releases.
I think I'm fairly close with the above zip file. The breadcrumbs code is missing the " :: " separator but the main task seems to be to import a chunk of code from the get_thumb_element routine into tag_albums_album.html.php
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Thu, 2011-10-13 01:53
The breadcrumb code in the calpage.html.php file is just a slightly modified version of GD's breadcrumb function.
I reworked the GD version of tag_albums_album.html.php in the current .zip file so it has it's own get_thumb_element function at the end of the file. Hopefully this will make fixes for future GD releases easier.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2011-10-13 02:43
I think the breadcrumb has changed in 3.1.0 and it seems I didn't transfer all I needed to. Thanks for finishing this off - looking forward to the update.
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Thu, 2011-10-13 03:13
undagiga wrote:
I think the breadcrumb has changed in 3.1.0 and it seems I didn't transfer all I needed to. Thanks for finishing this off - looking forward to the update.
U-G
You're welcome
The update was before you're previous post:
rWatcher wrote:
Here's the updated Tag Albums module with GreyDragon 3.1.0 support. Everything seems to work fine for me, but if I missed something let me know.
Ahhhhh ... I see! I missed that post as our two posts were at almost the same time. Thanks again.
U-G
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Thu, 2011-10-13 07:16
Works like a charm - many thanks. Looks like I was close in a couple of files with my changes, but missed a few things in calpage.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sat, 2011-10-15 10:40
As part of a general round of upgrades I upgraded to the latest version of Tag Albums (core module files, not just the replacement theme files). I realise that it's been out for quite a while, but the old version seemed to work and testing takes time.
But in doing so I noticed something odd. I click on my All Tags module and click on TagA. I get taken to
Two things I notice. First I notice that "/0/" is now just "//". Not a big deal, but odd. Second, the "?page=1" code appears whether it's needed or not. Can anything be done about either of these?
As you know, I really appreciate this module - it's essential to my site. But it's a shame that the URLs couldn't be something like:
There's really nothing that can be done about this is there, without creating whole additional tables in the DB?
U-G
p.s. Given the hassle of this last round of upgrading, is it time to try again to get some additions to the G3 core such that these replacement theme files are not necessary?
Hiding albums was not an option. Because I do want people to see the actual pictures without logging in. I just did not want them to see the original albums that I upload the pictures to.
The item_links module does do exactly what I want.
Thank you for your quick help!
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Wed, 2011-11-09 22:54
undagiga wrote:
Two things I notice. First I notice that "/0/" is now just "//". Not a big deal, but odd. Second, the "?page=1" code appears whether it's needed or not. Can anything be done about either of these?
I recently when through the code and re-wrote the parts that create the URLs so that everything would be "standard" -- that's probably what caused those issues. It's now fixed.
undagiga wrote:
As you know, I really appreciate this module - it's essential to my site. But it's a shame that the URLs couldn't be something like:
There's really nothing that can be done about this is there, without creating whole additional tables in the DB?
U-G
p.s. Given the hassle of this last round of upgrading, is it time to try again to get some additions to the G3 core such that these replacement theme files are not necessary?
Even the default Gallery tag urls look like http://mydomain.com/tag/ID/TagName so I don't think there's much that can really be done about that even with adding more tables to the database.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sun, 2011-10-16 12:40
Once again, thank you.
What about the idea of raising a support ticket to get some additional hooks so that replacement theme files are no longer needed?
U-G
rWatcher
Joined: 2005-09-06
Posts: 722
Posted: Sun, 2011-10-16 17:39
Last I heard, it sounded like some of that might happen in Gallery 3.1.
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Sun, 2011-10-16 22:49
Well, that IS encouraging!! Hadn't seen any sign of that myself, so you must have good connections.
Thank you.
U-G
crystalgirl
Joined: 2011-09-27
Posts: 36
Posted: Mon, 2011-11-07 16:21
I installed this module....seems pretty neat. I have noticed a couple things I have questions about....
1. I can no longer "EDIT" the album once I assign the TAGS to match. So now, how do I edit the album? (I cannot change tags for the query or edit fields I use for the custom fields module). When in the Tagged Album, it is as if G3 thinks I'm not logged in as an admin.
2. I have 17 items assigned to a Tagged Album, however, only the 1st thumbnail displays on the screen. When I start navigating through the virtual album, the item count is correct. Why don't the remaining thumbnails display?
3. I'm using NavCarousel, and it is completely confused Is there a way to have it work with the Tag Album module with correct navigation within the virtual album? If not, is there a way that I can HIDE it (for the virtual album only) as to prevent confusion for my users? Or, is the HIDING question a question for the NavCarousel author?
I have the most current G3 and and using the clean-canvas theme.
Thanks!
CrystalGirl
crystalgirl
Joined: 2011-09-27
Posts: 36
Posted: Mon, 2011-11-07 16:51
Well, I just noticed something....the reason that it is only displaying 1 thumbnail is because the HTML file is incomplete. The footer and sidebar are also missing, which are further down in the HTML (for all other pages).
Following the image, and HREF for the image, this is the very last line of html (line 325)
<ul class="g-metadata">
I rechecked, and my download was from Oct 14. That's only 3 weeks ago, but has there been a release since?
Any suggestions?
Thanks,
CrystalGirl
undagiga
Joined: 2010-11-26
Posts: 693
Posted: Tue, 2011-11-08 01:15
I'm sure rWatcher will appear and answer your questions. He's not here every day.
Re editing a tag album, you can do this from the parent album using the little fly-out menu on the thumb for the tag album.
Re incompleteness, the most recent version is just a few posts above (16 Oct). Works for me. If you are using greydragon, have you remembered to copy the replacement view files into the right place?
Re NavCarousel, I suspect that you may need to use the module that controls the order in which modules are executed to have it operate after tag ablums, but that's just a hunch.
Posts: 693
Fair call. I have tried to contribute to the limit of my modest coding skills. I have made code and codex contributions where module owners seem to have vanished. In this case I would want to be sure that rWatcher was happy with me updating that page. I know it's a community resource, but there are certain protocols to be observed.
U-G
Posts: 722
I've made the requested updates to the forum topic and to the codex page.
In the future, please feel free to make whatever codex updates you feel would be helpful for this, or any of my other modules.
Posts: 693
I've got two new issues. The first is relatively minor. As you know, you assisted me to get the breadcrumbs trail right when using the All Tags module and also with a renamed All Tags module. Now I've started to use the other feature of Tag Albums, virtual albums that appear on regular thumbs pages. The problem is that the breadcrumbs trail says "All Tags" or "Renamed All Tags", rather than the virtual album that I clicked on. I can think of a kludge that would fix this for my site, but is there a more general fix that you can think of? (You should be aware that due to laziness on my part I'm still using my original kludge for the breadcrumbs rather than the more elegant one you pushed to GIT - I don't think that using yours would fix this particular problem, would it?)
A second and more serious problem is that there's some conflict between the latest version of Dave's Facebook Like module and Tag Albums when using Greydragon. If you go to my test site and click on the album named "Virtual" you will see a page with no thumbs. If you look at the source you will see that there's a large chunk of code missing. This is not a problem if I switch to the Wind theme, so I assume that there's an issue with the GD-specific elements. Can you give me some tips where to look?
U-G
Posts: 722
This issue appears to be specific to using "3rd party" modules, Tag Albums "all tags albums" maintain correct breadcrumbs, but all that information is lost during the URL redirect to a seperate module's page. I've added a "?album=#" code onto the end of the URL redirect in the current experimental code, and updated my tag url generation modification to look for this code and use it to generate correct breadcrumbs, so this should now be fixed
It's trying to check the view permission on the current item, which it can't do because tags and dynamic pages aren't Gallery items. This should now be fixed in the current experimental code, which I've attached to this post.
Posts: 158
Is this still relevant? I tried it now and got a "Dang.."
My other sandbox
Posts: 693
@ mrf00rk: working for me, subject to the comments below.
@ rWatcher: Yup, that fixes both those problems, but I have a new one. The paginator isn't working on the tag albums thumbs pages, in that it thinks that there aren't any more pages when in fact there are. You can see this on my test site - there is a virtual album on the front page called "rWatcher", and this album should have 193 thumbs, but there's only one page of them. The changes in the experimental version seem rather small, and I've spend some time trying to spot what causes this. I'm sad to say that I haven't. I suspect it's something to do with the setting of $album_id.
U-G
Posts: 722
This is caused by my "fix" for facebook like. Upon further investigation, I believe this is actually a bug in the facebook like module, as I'm seeing the same issue on every other dynamic page (including gallery's built in tag pages), so I've reverted the change for the time being. I suggest not using the "Show on top of sidebar." / "Show on bottom of sidebar." options until this can be resolved.
Posts: 722
I've worked out a fix for the facebook like module, and posted the modified code to it's thread if anyone's interested:
http://gallery.menalto.com/node/98752?page=1#comment-374915
Posts: 158
It's working for me as well now. Upgraded to the latest greydragon and latest G3
My other sandbox
Posts: 693
Thanks very much. I suspected as much. It all seems to be working for me. It's a really great module, but I guess you already knew that I thought that!
U-G
Posts: 693
I had an idea. If it's a simple one then well and good but if it's too hard then don't worry about it.
Is there any way that Tag Albums could pick up the dynamic collections that your Dynamic module creates? I'm interested in a couple of virtual album thumbs on the home page for most recent and most popular.
U-G
Posts: 722
Dynamic is actually not one of my modules, despite what the codex says. Best guess would be that talmdal wrote it, based on this:
http://github.com/gallery/gallery3-contrib/commit/fc671304fe3fc3e9bdf56872a6cbf777f3b9af5a
Integrating the two together would potentially be a lot of work, as the database queries used are completely different. I'll have to think about if there's any easy way to do this, but this might be something that will have to wait until there's official support in Wind and GD for custom breadcrumbs and whatnot, so that I can write a more complex virtual albums module without all the theme overrides.
Posts: 693
OK, thanks. Leave it for the moment.
Posts: 693
Can I ask yet another (dumb) question please?
How stable are the URLs generated by this module. If I add new tags, will some of these URLs change? If I add new virtual thumbs albums, will some of these URLs change? For example, if I click on a virtual album thumb, I get a page of thumbs with this URL:
http://www.mysite.com/tag_albums/album/4/album-name.html
which leads to resize image URLs like:
http://www.mysite.com/tag_albums/show/594/0/4/filename.jpg.html
Will numbers like 4, 594 & 0 change when new tags, images or albums are added? Similarly if I navigate to the same image using the All Tags module, I get:
http://www.mysite.com/tag_albums/tag/172/0/tag+name.html for a page of thumbs containing the image and
http://www.mysite.com/tag_albums/show/594/172//filename.jpg.html for the resize image
And I have the same questions? The motivation for my question is partly about whether it's safe for people to link to these URLs, and partly about minimising 404s in search engines.
Thanks
U-G
Posts: 722
The numbers correspond to id numbers in the database. The only reason they would change would be if the corresponding record was deleted and then recreated (for example if you deleted and then re-uploaded a photo).
More detailed explanation:
http://www.mysite.com/tag_albums/album/4/album-name.html
4 is the ID number that was assigned to the virtual album when you linked the real album to the dynamic page. If you converted it back to a regular album, "4" would be deleted, and converting it back to a virtual album again would assign it a new (higher) number. Otherwise that number won't change.
http://www.mysite.com/tag_albums/show/594/0/4/filename.jpg.html
http://www.mysite.com/tag_albums/show/594/172//filename.jpg.html
594 -- id number of the photo/video to display. Won't change unless you delete and reupload the file.
0 / 172 -- tag id number, won't change unless you delete or completely remove a tag from you're gallery and then re-create it later.
4 -- virtual album id number, explained above.
http://www.mysite.com/tag_albums/tag/172/0/tag+name.html
172 -- tag id number, see above
0 -- virtual album id number, see above.
Posts: 693
Thanks for the explanation, that's reassuring. I noticed that Google webmaster tools has some 404s for some tagged photos, but I think that's because before this module I had duplicates of some photos in special albums. Once I was able to create virtual albums using tags I was able to delete the duplicates and special albums. I *think* that Google's 404s are for these images, or perhaps for the original dynamic tag albums, or both.
Posts: 693
rWatcher
Can I ask for some advice please? I've been hacking the album tree module so that it is formatted normally on photo pages and differently on the rest. Of course this requires some code that tests whether or not the page is a photo page. Elsewhere I've used if ($theme->item->is_photo()) { but if I use that here for some reason it causes tag album pages to crash. After a lot of trial and error I've got it to work, but only after borrowing some code from Tag Albums to count if there are any tag albums or items on the current page and avoid the if test if there are. Why does this if test cause a crash and is there a more elegant way to deal with this problem?
Thanks for any advice.
U-G
Posts: 722
Without seeing the exact code, I can't be sure, but my guess would be that if you call $theme->item->is_photo() on a page that's not an item then the is_photo function won't exist, thus causing a crash. You probably need to do something like:
if (($theme->item()) && ($theme->item->is_photo())) {That way it'll check and make sure you're looking at an item before calling the is_photo function.
Posts: 693
I had the impression from looking at the Tag Albums code that you must have encountered the same problem and found workarounds. E.g. in some of the .html.php files there is the use of $title rather than $item->title with some associated comment. I.e. I thought you would know rather than be guessing.
The good news is that your guess worked, so I assume you did know. But I have to admit I don't understand why it did. I would have thought that both elements in that if statement would need to be valid, but it seems not, so I guess it just shows how little I understand PHP.
Thanks. Much appreciated.
U-G
Posts: 3
Hi!
This is my first post here and I'm rather new to G3, although I did play around with G2 a while back, so apologies if I'm treading on toes or asking silly newbie questions.
Is there anyway (this module or otherwise) that can show dynamic albums with multiple tags - e.g. if I have a tag called face and a tag bw, I can see (even without this module) the images tagged with face (/index.php/tag/2/face)or the images tagged with bw (/index.php/tag/4/bw)) - but is there some way I can see pictures tagged with bw and face?
I was rather hoping that this module would let me to "drill down" through tags - e.g. if I view the face album, I see a bw subalbum (as well as for any other tags that have at least 1 picture in common with the face tag)
Thank you
Posts: 722
You could use this module to create a custom "dynamic album" that would contain everything tagged with both face and bw, but there's no way to dynamically drill down as you're browsing photos.
Posts: 3
Thanks for the clarification; am I correct to understand that while it's not possible to do what I am looking for with this module, it's only really a case of user interface? i.e. if I can create a dynamic album of tag (unions) as an admin, it means it is possible to query the database for photos that have all the required tags.
Posts: 722
Correct.
Basically, what this module lets you do is create an album, and then when you edit the album options you can specify one or more tags. Then when a user clicks on the album, they'll be directed to a page populated with photos that contain those tags. You don't actually need to be an admin to do this, any Gallery user with the ability to create a new album can take advantage of it.
Posts: 3
hmmm... a workable solution for my needs (for people to be able to find pics by tags) would be if functionality was shown as a "search for pictures by tags" rather than as creating an album (and a one-step process where maybe it automatically calls the album "pictures tagged with X,Y, AND Z" or even "pictures tagged with X, Y OR Z"; although there can be a complication in automatically deleting the album - otherwise every search would create a new album and create a total mess)
would this be hard to do?
(it would perhaps be simpler if the search box did just that - but I can't seem to figure how to get it to combine tags with AND operator)
edit: just realized that I need to have the + as "xxx +yyy" or it doesn't work
Posts: 94
I'm trying to set up Tag Albums with the All Tags link but seem to be missing a trick.
I'm using the Clean Canvas theme.
Via Tag Albums Admin I've selected "All Tags module" as the "Tag Albums index"
Installed "Module order" module and moved "All tags" above tags.
When I click on "View Tag Albums" in the Sidebar, the "All Tags" page list of tags is displayed.
I click on a tag and the tagged photo thumbnails are displayed.
But, when I click on a thumbnail I enter the photo page in the photo's album sequence instead of the virtual tag album sequence.
As an aside, if "(default) Individual Tag Albums" is selected via Tag Albums admin I do get the virtual gallery of images to step through although all the pages are broken Gallery Wind theme pages.
Any suggestions as to what I've missed please.
Thanks
Posts: 722
Make sure you've copied the contents of "tag_albums/--Theme Files/clean_canvas/views" to your "themes/clean_canvas/views" folder:
http://github.com/rWatcher/gallery3-contrib/tree/master/3.0/modules/tag_albums/--%20Theme%20Files/clean_canvas/views
Also, it sounds like you may have moved the wrong module via the Module order screen:
Posts: 94
Many thanks rWatcher, you are right on both counts.
Things are looking much better but I now have another issue.
As before, via Tag Albums Admin I've selected "All Tags module" as the "Tag Albums index"
When I click on a tag, only the first 12 tagged photo thumbnails are displayed.
The Previous and Next buttons are greyed out and "No photos" is display at foot of page.
See attached screen snip.
[img]http://www.chilternphoto.org.uk/g3extras/tag_albums_snip.png[/img]
If I click on a thumbnail I do now enter the photo page in the virtual tag album sequence
and I can step via Next/Previous through all the tagged photos.
Also, if I'm viewing a photo that was not displayed in the first 12 thumbnails and I click the tag name in the breadcrumb line I get a different 12 thumbnails page, incuding one of the photo I was viewing, but still the same issue as above.
I hope I'm not becoming too high maintenance with this module.
Posts: 722
Here is the latest version of Tag Albums, which should fix all known issues.
It has been tested with Gallery 3.0.2 using Wind, Clean Canvas and GreyDragon (for clean canvas and grey dragon you will need to copy the contents of the theme files/THEMENAME/views folder to your themes/THEMENAME/views folder).
Posts: 94
Excellent rWatcher, everything is now working fine, a great module in combination with undagiga's All tags module.
Hopefully, for the benefit of future Gallery3 users these great tagging modules will one day be incorporated into the core Tag module.
All I need to do now is work out how to customise the thumbnail page to remove the Title display from below the thumbnails
Posts: 1
Thanks for a very nice module!
I am using version 3.0.2 (Coollanta) of Gallery 3, "slide show ex" Version 1.5 and Shadowbox version 1.8
My problem is that the slide show begins with the first photo from the original album (the "home" album for that photo) and continue with that album.
Same problem with the bult-in slide show.
Pushing the "next" button in shadowbox shows the next photo in the original album.
The slide show is using the rss feed from the album and I guess that shadowbox is using it too.
My conclusion is some problems with the rss feed from Tag Albums.
Any idea?
Posts: 693
rWatcher
I'm sorry to say that I'm going to need help getting tag albums to work with Greydragon 3.1.0. I've looked at the modified view files that you ship with Tag Albums, and done my best to migrate the changes to 3.1.0. But alas, it doesn't work. I've attached my attempt.
U-G
Posts: 2
I am trying to accomplish the following;
Only show pictures through tag albums.
I have a bunch of pictures with several tags added. I have also created new albums and then edited them to only show specific tags.
Now what I would like is that these albums are the ONLY way to see my pictures.
Currently people can still see all my pictures by simply going to /index.php . That lands them in the gallery root and thus shows all pictures/albums.
I don't care about security; eg I don't care people will still be able to see my pictures by using a direct link for example.
It is just that I don't want people to randomly browse through the gallery.
Perhaps a bit confusing, but I hope you catch my drift.
Posts: 693
I've worked out the issue with Tag Albums in Greydragon 3.1.0, sort of. In addition to the mods in the zip in my above post, in the theme the parameter "thumb_topalign" is now "thumb_imgalign". If you make this change (one instance only) in tag_albums_album.html.php then Tag Albums will work, up to a point.
However, the alignment of the thumbs won't be right, unless you chose top alignment. There is a bunch of code that needs to be replaced that calculates the thumb placement based on "thumb_imgalign". I'm still working on this - not sure just how much new code to bring in.
rWatcher - I take it that you're not around at present?
U-G
Posts: 722
Shadowbox should work fine if you're using the GreyDragon theme. The other sideshow's that use the RSS feed won't work properly as the RSS feed will refer to the actual album and not the virtual album.
Looking into it, will report back when it's fixed
Off the top of my head, you could use a module like "hide" to hide the albums you don't what users to see, or you could use a module like "item links" so that anyone that navigates to /index.php gets redirected to a different url (such as index.php/tag_albums).
http://codex.gallery2.org/Gallery3:Modules:hide
http://codex.gallery2.org/Gallery3:Modules:item_links
Posts: 722
Here's the updated Tag Albums module with GreyDragon 3.1.0 support. Everything seems to work fine for me, but if I missed something let me know.
Posts: 693
Thanks!!!! I thought perhaps you were away. I was going to set some time aside today to try and finish the job, as I decided that I needed to become more self-sufficient. It's a lot of work for you to upgrade these view files each time there's a release, and there are a lot of GD releases.
I think I'm fairly close with the above zip file. The breadcrumbs code is missing the " :: " separator but the main task seems to be to import a chunk of code from the get_thumb_element routine into tag_albums_album.html.php
U-G
Posts: 722
The breadcrumb code in the calpage.html.php file is just a slightly modified version of GD's breadcrumb function.
I reworked the GD version of tag_albums_album.html.php in the current .zip file so it has it's own get_thumb_element function at the end of the file. Hopefully this will make fixes for future GD releases easier.
Posts: 693
I think the breadcrumb has changed in 3.1.0 and it seems I didn't transfer all I needed to. Thanks for finishing this off - looking forward to the update.
U-G
Posts: 722
You're welcome
The update was before you're previous post:
http://gallery.menalto.com/files/tag_albums.zip
Posts: 693
Ahhhhh ... I see! I missed that post as our two posts were at almost the same time. Thanks again.
U-G
Posts: 693
Works like a charm - many thanks. Looks like I was close in a couple of files with my changes, but missed a few things in calpage.
Posts: 693
As part of a general round of upgrades I upgraded to the latest version of Tag Albums (core module files, not just the replacement theme files). I realise that it's been out for quite a while, but the old version seemed to work and testing takes time.
But in doing so I noticed something odd. I click on my All Tags module and click on TagA. I get taken to
http://mydomain.com/tag_albums/tag/68/0/TagA.html
I click on a thumb. I then click on TagA in the breadcrumb trail and I get taken back to
http://mydomain.com/tag_albums/tag/68//TagA.html?page=1
Two things I notice. First I notice that "/0/" is now just "//". Not a big deal, but odd. Second, the "?page=1" code appears whether it's needed or not. Can anything be done about either of these?
As you know, I really appreciate this module - it's essential to my site. But it's a shame that the URLs couldn't be something like:
http://mydomain.com/tag_albums/TagA.html
There's really nothing that can be done about this is there, without creating whole additional tables in the DB?
U-G
p.s. Given the hassle of this last round of upgrading, is it time to try again to get some additions to the G3 core such that these replacement theme files are not necessary?
Posts: 2
Hiding albums was not an option. Because I do want people to see the actual pictures without logging in. I just did not want them to see the original albums that I upload the pictures to.
The item_links module does do exactly what I want.
Thank you for your quick help!
Posts: 722
I recently when through the code and re-wrote the parts that create the URLs so that everything would be "standard" -- that's probably what caused those issues. It's now fixed.
Even the default Gallery tag urls look like http://mydomain.com/tag/ID/TagName so I don't think there's much that can really be done about that even with adding more tables to the database.
Posts: 693
Once again, thank you.
What about the idea of raising a support ticket to get some additional hooks so that replacement theme files are no longer needed?
U-G
Posts: 722
Last I heard, it sounded like some of that might happen in Gallery 3.1.
Posts: 693
Well, that IS encouraging!! Hadn't seen any sign of that myself, so you must have good connections.
Thank you.
U-G
Posts: 36
I installed this module....seems pretty neat. I have noticed a couple things I have questions about....
1. I can no longer "EDIT" the album once I assign the TAGS to match. So now, how do I edit the album? (I cannot change tags for the query or edit fields I use for the custom fields module). When in the Tagged Album, it is as if G3 thinks I'm not logged in as an admin.
Is there a way to have it work with the Tag Album module with correct navigation within the virtual album? If not, is there a way that I can HIDE it (for the virtual album only) as to prevent confusion for my users? Or, is the HIDING question a question for the NavCarousel author?
2. I have 17 items assigned to a Tagged Album, however, only the 1st thumbnail displays on the screen. When I start navigating through the virtual album, the item count is correct. Why don't the remaining thumbnails display?
3. I'm using NavCarousel, and it is completely confused
I have the most current G3 and and using the clean-canvas theme.
Thanks!
CrystalGirl
Posts: 36
Well, I just noticed something....the reason that it is only displaying 1 thumbnail is because the HTML file is incomplete. The footer and sidebar are also missing, which are further down in the HTML (for all other pages).
Following the image, and HREF for the image, this is the very last line of html (line 325)
<ul class="g-metadata">
I rechecked, and my download was from Oct 14. That's only 3 weeks ago, but has there been a release since?
Any suggestions?
Thanks,
CrystalGirl
Posts: 693
I'm sure rWatcher will appear and answer your questions. He's not here every day.
Re editing a tag album, you can do this from the parent album using the little fly-out menu on the thumb for the tag album.
Re incompleteness, the most recent version is just a few posts above (16 Oct). Works for me. If you are using greydragon, have you remembered to copy the replacement view files into the right place?
Re NavCarousel, I suspect that you may need to use the module that controls the order in which modules are executed to have it operate after tag ablums, but that's just a hunch.
U-G