Theme: Pear4gallery3
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Tue, 2012-01-31 12:16
|
|
can't reproduce the bug myself... and the carousel works fine... looks great ! ------ |
|
|
e-nando
Joined: 2012-01-31
Posts: 3 |
Posted: Tue, 2012-01-31 16:46
|
|
Super Gallery theme - Just setup Gallery3 with this theme as a replacement to MobileMe. With the latest Git the only bug I can see is that the "Download this photo" link doesn't work giving an error "'currentImg' is undefined". Also learning some of the quirks of Gallery - especially with IE! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Tue, 2012-01-31 18:42
|
|
e-nando wrote:
Super Gallery theme - Just setup Gallery3 with this theme as a replacement to MobileMe. With the latest Git the only bug I can see is that the "Download this photo" link doesn't work giving an error "'currentImg' is undefined". I'm glad you like it, my intention were to replace mobile me, and I actually started develop this theme when gallery.me were introduced. New changes that should fix the issues with "Download photo" from detailView. What specific quirks do you think of? Any more suggestions? |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Wed, 2012-02-01 04:06
|
|
Hi there, Still testing around and when in the image view, in grid mode or slideshow, there is the four/five icons at the bottom : - Is there a way to get rid of the download link (and icon) ? This could maybe a good option in the admin as some photographer don't like this feature. ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Wed, 2012-02-01 14:07
|
|
petri wrote:
Still testing around and when in the image view, in grid mode or slideshow, there is the four/five icons at the bottom : Thank you for your extensive testing! It's something that I've not found the time to do 'yet'. The view you are describing is what I'm calling 'detailView' (you can almost always see the name used in the url). Edit: Support for hiding the download link submitted to github. Let me know what you think (the controller needs to be resized and I'm working on it). |
|
|
xarope
Joined: 2012-01-26
Posts: 10 |
Posted: Thu, 2012-02-02 02:24
|
|
petri wrote:
- The show info is not working for me, it just keeps on loading without showing anything. What is shown in this box ? Description ? Exif ? Could it be a problem with my photos ? you need to enable the Exif Data module, and then in Maintenance run that task to update the database. |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Thu, 2012-02-02 02:59
|
|
Thank you xarope, Exif module was not activated indeed and it works, the layout is fine for me. Although my descriptions don't show up neither is there any way to add comments (don't know if erlis already tried to implement it) Personally I don't really care about the exif.....but the Facebook comments module...that would be great ! ;-) ------ |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Thu, 2012-02-02 03:07
|
|
I tested the tag_cloud module and it works great ! and looks great in the sidebar ! I also tried tag_cloud page and it show up fine in the sidebar but the page itself is too big for my screen, I guess the the flash file does not autoresize. ------ |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Thu, 2012-02-02 09:40
|
|
Quote:
Edit: Support for hiding the download link submitted to github. Let me know what you think (the controller needs to be resized and I'm working on it). works fine, when full size is not authorized, one cannot see the download icon... ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Wed, 2012-02-22 07:49
|
|
New version uploaded to github v3.2. Changes:
Hope you like it and once again thank you petri for bug reporting and new images. I've spent quite a lot of time developing this theme so if you like it I really would appreciate some contribution to my beer found. |
|
|
e-nando
Joined: 2012-01-31
Posts: 3 |
Posted: Thu, 2012-02-23 00:23
|
|
I just updated to the latest commits and there now appear to be some display issues (at least in IE and Firefox): (1) If the grid view is set as default and you go into an album you see a broken "mosiac" view The issues appear to be in the rewrite of album.html.php. To check there was no corruption I recloned the theme from github and the issues were still there. I've got a test gallery at http://www.e-nando.org where you can see the problems... Hope this helps! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Thu, 2012-02-23 20:01
|
|
e-nando wrote:
I just updated to the latest commits and there now appear to be some display issues (at least in IE and Firefox): Well, IE really sucks big time. I've managed to close most of the bugs in IE (found some additional ones), what do you mean with (2)? Just let me know how it goes, but there must be a limitation on wich versions I can support (tested with IE7-8, FF 10.0.2 and Chrome 17). |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Fri, 2012-02-24 03:00
|
|
Hi erlis, I have to say I have no bug around, just imported more than 11'000 pics from G2 into Pear in three hours and everything went fine. I am more than happy !! http://erlandssson.nu/~fer/gallery3/race_track# http://www.coquille.org/gallery3/index.php/reports/#img=3 Your text seems to be bolder on the top bar, and your menu seems to be higher, so much more readable...I don't know if you have any difference on Safari for PCas well, as I don't have any on Chrome and Firefox, just Safari. Please tell me where in the css I can change the text color and font in the menu and the height of the menu bar, I might want to try to fix the height a little higher to see if it does smth and also play will the font...I have been searching for a while but no success. Thank you in advance for your answer and thank you again for this great theme. ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Fri, 2012-02-24 06:38
|
|
petri wrote:
Just one little detail, I see a difference in the text on the top bar and the menu in your page and mine on Safari for mac : I can't see the difference.. When it comes to tweaking the theme try enabling the developer toolbar (http://osxdaily.com/2011/11/03/enable-the-develop-menu-in-safari/) and use the inspect element, from there you can play with the css in realtime. |
|
|
tosk137
Joined: 2012-01-03
Posts: 3 |
Posted: Tue, 2012-03-06 02:06
|
|
Thanks so much for the upgrades to the theme. The problems I have experienced are all gone, and it's one clean-looking, professional theme. Could you point me to where I could change the font size for the word "Login"? When I click on "Show Options" (in any browser) the login is so tiny, my mother can't see it. I'd like to make it bigger. Thanks again. |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Wed, 2012-03-07 08:30
|
|
tosk137 wrote:
Could you point me to where I could change the font size for the word "Login"? When I click on "Show Options" (in any browser) the login is so tiny, my mother can't see it. I'd like to make it bigger. Hi, Glad you like the theme. The line you need to modify is this: https://github.com/fredrike/pear4gallery3/blob/master/css/screen.css#L75 it is actually on my todo list to fix this kind of minor issues but I have not taken the time to do so. Please let me know how it works and I'll update the theme in the next commit. |
|
|
tosk137
Joined: 2012-01-03
Posts: 3 |
Posted: Sun, 2012-03-11 05:42
|
|
Thanks for the tip. I was able to change the font-size easily. |
|
|
LucidREM
Joined: 2012-03-11
Posts: 1 |
Posted: Sun, 2012-03-11 08:01
|
|
erlis wrote:
Well, IE really sucks big time. I've managed to close most of the bugs in IE (found some additional ones), what do you mean with (2)? i really like this simple theme to show photos without a lot of "fluff" .. i did however take some time locating the newest version as the front post shows version 3.0 (this one does not fully function .. from gallerymodules.com) .. perhaps the newer version could be placed prominently for all to see |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Mon, 2012-03-12 03:14
|
|
Awesome theme! So awesome that I'm gonna send you some beers through Paypal... Enjoy them and keep updating this great theme! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Thu, 2012-03-15 08:30
|
|
New version of the theme.. Fixes:
Download here. |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Tue, 2012-03-13 17:33
|
|
After updating I'm not seeing any of my albums... |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Tue, 2012-03-13 17:47
|
|
It loads the black background and then botton toolbar, but not the albums. I tried reinstalling the theme from scratch and no luck. |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Tue, 2012-03-13 18:55
|
|
Koramchad wrote:
It loads the black background and then botton toolbar, but not the albums. I tried reinstalling the theme from scratch and no luck. Do you see anything in the debug/log files http://codex.gallery2.org/Gallery3:FAQ#How_do_I_see_debug_information.3F ? Also, review the theme settings perhaps there are some conflicting options that I've forgot to migrate. (try setting the number of skimming thumbs in options) |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Tue, 2012-03-13 19:09
|
|
This is what I get every time I try to load the main page: |
|
|
e-nando
Joined: 2012-01-31
Posts: 3 |
Posted: Tue, 2012-03-13 20:16
|
|
It appears that the new helper helpers/pear4gallery3_event.php is not being loaded by default. It does work (at least for me) if you try and edit an album in the theme (as Admin). This then runs helpers/pear4gallery3_event.php which creates the pear_album_view table.... Hope this helps! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Tue, 2012-03-13 20:29
|
|
e-nando wrote:
It appears that the new helper helpers/pear4gallery3_event.php is not being loaded by default. It does work (at least for me) if you try and edit an album in the theme (as Admin). This then runs helpers/pear4gallery3_event.php which creates the pear_album_view table.... Yep, that it's the temporary solution. Or remove the changed lines from album.html.php in this commit https://github.com/fredrike/pear4gallery3/commit/734b8c97d6f6ff3e59b55e0d542e239c2e41e118#diff-3 I'll get back to you when I've found a permanent solution (it really sucks that gallery3 don't invoke the upgrade/install hook from themes). |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Tue, 2012-03-13 20:35
|
|
That trick works e-nando! Thanks! |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Tue, 2012-03-13 20:41
|
|
You can disable the box by unchecking the "Show comments on albums" on the Facebook comment setting module. You won't be able to comment on a whole album, but not a big deal. |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Wed, 2012-03-14 08:34
|
|
Koramchad wrote:
This is what I get every time I try to load the main page: Fixes committed to github. |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Thu, 2012-03-15 07:11
|
|
Erlis ! You rule in the world of G3 themes !!! Thank you soooo much for integrating the Facebook comments !! I just tested it, it works well and looks really good ! The only problem is the publication on FB : the picture is not showing up and the link back to G3 is wrong : http://www.facebook.com/gallery3/index.php/portfolio/portrait/color/_PDP2897 But I guess that this is more of a module problem.... or is it not ? ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Thu, 2012-03-15 13:40
|
|
petri wrote:
Thank you soooo much for integrating the Facebook comments !! Np, I needed it my self.. The thing now as you might have noticed I prioritize the Facebook Comments over "ordinary" comments, if I have an icon for facebook (just the f) I could support both g3's default comment system and FB-comments in parallell.. Yep, what you are referring to seems to be a bug in the facebook-module, test it without my theme and see if you get the same problem, if not I guess it's my fault (perhaps we need to include the full url not just the relative). |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Thu, 2012-03-15 17:10
|
|
Support for the search module committed to github, no version up yet, I hope to solve most of the issues later this week. |
|
|
Koramchad
Joined: 2012-03-11
Posts: 10 |
Posted: Thu, 2012-03-15 17:18
|
|
Awesome! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Fri, 2012-03-16 14:25
|
|
So, a new update (version 3.5)! Fixes
Download here. Let me know if you find any more bugs. |
|
|
yyymin
Joined: 2007-01-04
Posts: 5 |
Posted: Sat, 2012-03-17 14:03
|
|
upload half window show |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Thu, 2012-03-22 13:18
|
|
Hello Erlis, Sorry for my very late reply, I just got the time to install and test your 3.5. Tag Cloud module : the cloud is not showing at the proper size in the sidebar anymore, instead of being the small size for the sidebar, it is the full size for the page so it just makes the sidebar much bigger. Anyway thanks for the update and the great theme, can't wait to put it online (as soon I as get my new logo ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Thu, 2012-03-22 13:33
|
|
Hi, Version 3.5 currently have some major bugs that I've not have had time to investigate hence try version 3.4.2 that should be solid.. Plz, get back to me if you find any bugs in that release.. (We are still lacking some of the features in 3.5 but it should at least be solid). |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Fri, 2012-03-23 07:21
|
|
Thank you I downloaded and installed your link but the version is 3.4.1, it is the right one ? Just to know before I start testing ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Fri, 2012-03-23 07:53
|
|
Yep, I guess so.. The dir you have extracted should be: fredrike-pear4gallery3-6032bae This is a release created in the middle of the committed code, that's why I have not updated the version in the theme. |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Fri, 2012-03-23 09:59
|
|
Ok just made some test with 3.4.2 Tag Cloud : same problem, it's the big one I get, not the one for the sidebar so then I wen back to the version I had before : 3.2.1 Tag Cloud : works fine ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Fri, 2012-03-23 12:56
|
|
petri wrote:
Ok Some more clarification please.. What is wrong in the facebook-comment module of 3.4.2? In 3.2.1 we did not even have support for facebook-comment Is the speed the same in 3.4.2 and 3.2.1? No more quirquiensees except for the two modules? |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Sun, 2012-03-25 01:47
|
|
As you understood, the problem of the 3.4.2 and 3.5 Facebook module, in Pear, is that the thumbnail that is shown on the Facebook page does not represent the picture on the page itself but the thumbnail of the album, which does not make a lot of sense, but I understand that it is the theme of Pear itself that causes the problem. I hope you can find a solution there. Meanwhile I will search on my side and see what the other themes are doing. For the tag cloud, see the two pictures attached. The tag cloud has two display mode, the first one is to be displayed in the sidebar, the second is to be displayed in a page, as a big flash element. The one that we can see since 3.4.2 seems to be the one that is displayed in a page. Speed is same in 3.4.2 and 3.2.1 Appart form that, could not find any other bugs... ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Sun, 2012-03-25 07:00
|
|
petri wrote:
As you understood, the problem of the 3.4.2 and 3.5 Facebook module, in Pear, is that the thumbnail that is shown on the Facebook page does not represent the picture on the page itself but the thumbnail of the album, which does not make a lot of sense, but I understand that it is the theme of Pear itself that causes the problem. I hope you can find a solution there. Meanwhile I will search on my side and see what the other themes are doing. The problem with Pear is that I've removed the photo page and are using javascript and overlays to mimic that functions. When one tries to access a photo page (like Facebook is doing from the comment link) I redirect (with a 302 http-code) to the album page. I have a few solutions for this, but it will more or less make the rest of the them (when accessed with a photo url) less responsive and slower. Perhaps I have to check who is trying to access the page (if it's FB it is ok if the page is a bit slow). This it the code that breaks the thumb in FB (https://github.com/fredrike/pear4gallery3/blob/v3.4.2/views/page.html.php#L14) and according to https://developers.facebook.com/tools/debug FB is following the 302 redirect correctly. <? if ($theme->page_subtype == "photo"):
foreach (end($parents)->viewable()->children() as $i => $child)
if(!($child->is_album() || $child->is_movie()))
if($child->url() == $_SERVER['REQUEST_URI']) {
header("HTTP/1.1 302 Found");
header("Location: ".end($parents)->url()."#img=$i&viewMode=detail&redirected=true");
die(0);
}?>
<? endif ?>
petri wrote:
For the tag cloud, see the two pictures attached. The tag cloud has two display mode, the first one is to be displayed in the sidebar, the second is to be displayed in a page, as a big flash element. The one that we can see since 3.4.2 seems to be the one that is displayed in a page. Looks strange, the modifications made should not affect that appearance. petri wrote:
Speed is same in 3.4.2 and 3.2.1 Good, nothing major broken that part. petri wrote:
Appart form that, could not find any other bugs... Great! |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Mon, 2012-03-26 12:41
|
|
erlis wrote:
Fixes for FB-comments et al. In version 3.4.3 test it and let me know what you think. I had to remove the 302 http redirect and use a html-meta redirect instead (Making the photo link a bit slower but now it's working ;)) |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Tue, 2012-03-27 02:42
|
|
Thank you Erlis, You did it ! It is slow indeed (especially from China) but it does what it should do. For the autoresize of the comment pop up, I wonder if you have the same display as I do : the window never seems to open itself at full resize (see attachement), the loading wheel keeps on spinning....but this could also come from the fact that I am in China and using a VPN to access Facebook. For the Tag cloud bug, I am going to compare the display code on 3.4.3 (same bug) and 3.2.1 and see if I can find a difference of some sort. I'll let you know. ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Tue, 2012-03-27 05:22
|
|
petri wrote:
For the autoresize of the comment pop up, I wonder if you have the same display as I do : the window never seems to open itself at full resize (see attachement), the loading wheel keeps on spinning....but this could also come from the fact that I am in China and using a VPN to access Facebook. Yes, I've noticed that bug as well, the strange thing is that if you press the comment icon twice it will work the second time.. I'll try to sort it out during the day. For debugging the Tag cloud have a look at the changes in github. |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Tue, 2012-03-27 10:15
|
|
No luck for the tag cloud, I went through all your changes but with the poor knowledge of php or java I have, I did not find anything that would tell me why it was working before and not now. So I just added a line in screen.css Quote:
/* Tag Cloud ~~~~~~~~~~~~~~~~~~~~~~~~~~ */ it's a cheat, but it works ! ;-) ------ |
|
|
erlis
Joined: 2004-01-16
Posts: 205 |
Posted: Tue, 2012-03-27 12:08
|
|
petri wrote:
No luck for the tag cloud, I went through all your changes but with the poor knowledge of php or java I have, I did not find anything that would tell me why it was working before and not now. This is the line: https://github.com/fredrike/pear4gallery3/compare/v3.2.1...v3.4.3#L10R17 the problem is that the tag-cloud is initiated when the page is "ready" but I initiate the sidebar when the page have "loaded". Two solutions: 1. Initiate the sidebar on "ready"/make sure the css for the sidebar is set to 220.. I like 1. better, get back to you when I have adopted that.. Update: (I did not find time to press 'post comment') Fix can be downloaded from github now: https://github.com/fredrike/pear4gallery3/zipball/v3.4.3.1 |
|
|
petri
Joined: 2005-12-15
Posts: 253 |
Posted: Tue, 2012-03-27 12:31
|
|
Sorry I found two more bugs, I guess I did not test everything yet Custom logo : when activated, it shows only on Firefox, not on Chrome neither Safari (all for mac) Captionator module : when on the caption page, there is no scroll bar so not possible to edit and save when the page is long. I know this is another module problem, hope you can find an easy fix. edit : did not see your previous comment, will test and get back to you |
|
|
manchesterca
Joined: 2012-04-12
Posts: 1 |
Posted: Sun, 2012-04-15 16:47
|
|
First, love the theme, it's fantastic. |
|
