Google Maps + Gallery

I will wait for Termite to make the call, he might have some changes to make as well.
I don't have CVS and I don't need the _try_ to learn something that I would rarely use. If I learn CVS then something else would have to be forgotten. ;-)

Cheers!

Hope this is the right place to post a bug.

Version: 0.4.7c
Description: When I use the install link from the admin page I only get a blank page.
Problem: In de file module.inc, function upgrade, when you install map for the first time the variable $currentVersion is undefined, so expressions like 'case ($currentVersion == "0"):' [line 308] won't match. The switch() matches in line 366 and the script fails.
Fix: Changing the line to 'case ($currentVersion == ""):' was enough for me, but I think that a best workaround is needed.
Note: I found this problem only in one of my systems, in other everything was fine.

Hope this helps

I realize you are talking with floridave about your problem; but,
I am interested in whether you are referring to the map module
-or- the map theme. I have been working on the map theme.

I see we have a issue that we show the escaping slash. BUT I don't see a failure of the Javascript:
http://gallery2.ca/gallery2/main.php?g2_view=map.ShowMap&g2_filter=apostrophe
That link has a marker to a album that has a apostrophe in the title as well as the summary.

Like I said I DO see a issue that the escapes are showing in the summary as well as the filter dropdown but not a failure of the JS.
Like galmoid asked it might just be in the 'theme'?

Dave
____________________________________________________
Gallery Frames / Mods || G1 Test Gallery

I have facing some problem. It work fine with FF but trouble with IE!
I'm using 0.47c.

William

Well!

Happy new year to everybody I have been without Internet access for a bit and that feels weird (not in a good way).

Now I'm back and I will also start the work on the module again very soon.

I have read all of the posts a here is a first comment:

I need to gather the changes made by floridave as well as fixes the couple bugs found. This will make a quick version 0.4.7d to use

Right after that I will do the cleaning before adding anymore feature (it will be easier to work on the code after that)

See you soon !
-------------------------
The Termite

I will try to make the update to CVS tomorrow or as soon as I can

I just want to say that the module does not work with the PG theme because of some conflicting Javascript. I have not gotten time to look into this but will after version 0.4.8 is released

Regarding an update to the 'g' infowindows . . .

Does anybody have any opinion regarding putting some
"value added"(? ) links in them? I am thinking
about:
---
Location:
-105.63624,35.9744
View location at Terraserver
(Unfortunately, USA only)
View Localtion at TopoZone
(Unfortunately, USA only)
WeatherBonk.com this location

Zoom In
---
'Location' is already in them and 'Zoom In' is
configurable in -all- infowindows through admin.

What do you think? Any other links? Maybe they could be added
to the admin screen (like Zoom In)? Maybe it is not at all a good
idea?

I know floridave has been looking into the weather thing.

Just a quick note. With the problem related to slashes. did anyone try stripslashes
?

It would seem like an easy way if it works
-------------------------
The Termite

Termite,
What about what I mentioned above? If those lines can be
changed then I think a band-aid (stripslashes) wouldn't
be a good idea? Thoughts anybody?

Ok, I gave a shot to the "band-aid" and the following just works fine it seems:

            $pointHash[$entity->_id]['title']= stripslashes($entity->_title);
            $pointHash[$entity->_id]['summary']= stripslashes($entity->_summary);
            $pointHash[$entity->_id]['description']= stripslashes($entity->_description);

Any objection as to use this instead ? (i'm not sure why a preg was used in the first place ??)

let me know

-------------------------
The Termite

Bottom line is:

Here you go. Version 0.4.7d:

Includes fixes for transparency (thx floridave)
Includes fixes for apostrophes (thx galmoid)
Includes fix for new install (No currentVersion)

Small changes but bigger ones are to come soon ;-)

-------------------------
The Termite

lol, no dander up :-D

Sweet. so I guess we will keep it as it is. version 0.4.7d is the version to start from. I totally forgot I had started the "GROUP" feature. So i will finish it because there is not a lot to do and then start the cleanup.

The next version will be 0.5.0 and I will also start the writing of a "dev" guide so that people know about all of the functions created and also how the module work in the coding details. it's easier to get more code added.

Yes, I'm all for this! I was also thinking of an optional (via Admin panel) defined link that would display in the infowindow. For example, image of a place (mountain, lake, attraction, etc.) at say a national park. The infowindow could have a link to that national park or whatever the case may be. The link should spawn a new browser window.

Make it so the link displayed does not need to be the http:// (in case of really long urls). The admin panel for this option would have TWO text boxes to fill out -- the URL and the text you want to have displayed. Probably other methods of doing this, I'm just thinking out loud here. Make sense or have I confused you?

I added some z-index to the custom map controls. I am not sure if they are now needed or not. The map controls are just <div>s over the map and should render correctly without them. It might have been a left over from some other versions I had tried.
There should not be any calculated z-indexes that I know of for the custom controls.
Termite, Do you want me to look into that or have you got that under control?

Dave

This is the option I am leaning too;
A text box where the user puts in the weather ID code ,
or zip/post code or the best bet is the airport code.
Then this would be a bit better to maintain and code as well.

@DST; I guess the rest of Canada will have to follow as well...
if they want to maintain some consistancy.

Dave

Concerning the weather thing I would agree with the latest choices. A new box is no big deal and if the person does not want it or does not care, it would just be empty (which is fine).

We should use that option then as it will make everything easier

floridave, I don't mind you look into the z-index issue as I still have some Internet issue it seems (it's hard for me to post a message ... 20-30 tries )

I'll be working on the code cleanup and let you all know when I'm done (will take a few days I'm sure)

See you
-------------------------
The Termite

I always believe that choice is a good thing; therefor, would vote for
the ability to have infowindow "value added" links configurable via
the admin screen (maybe the infowindow thing is growing towards it's
own admin tab?). An infowindow generator would really be ideal (I think
this may be beyond my pea brain though). It would make it unnecessary
to have many separate templates. I like Your idea Termite.

I got to looking at the weather thing after floridave started (hoping
multiple research could come up with an answer) and found some free
ways to determine an airport code via coordinates; but, the whole
thing quickly became unwieldy. That is when I thought, just put in a link
to weatherbonk.

On the zoom in/zoom out thing: I vote for the zoom out to be available
"on the map" as well as next to the zoom in on the infowindow(s) (here
is an ideal example of the benefit of the generator - all of our
infowindows will require updating, separately, to accomodate the expanded
zoom capability).

I will post a new set of 'g' infowindows (I'll name them 'g2'...) for y'alls
inspection. I'll just leave the links I mentioned in place for the
moment. These templates will solve a several of problems I've found...
not the least of which is lonnng descriptions (try putting a lonnng
description on one of your images and see what I mean ).

No i didn't really take it over, but as for infos, he actually created this theme to answer the original need (marry google map + gallery) and then kinda left the them tail off when the module got started.

I started adding some things on the module and after seeing that no-one else was willing at the time. I just took it over

I would suggest you do the same with the theme for the time being. Just create a new version 1.0.4 and everything is fine. version 1.0.3 was already created by me to fix a couple of bugs

Well that's a very valid discussion. eventually the module would have the picture stip (I already have the idea on how to make it) With the combination of the Album filtering and the rewrite module, it would be possible very easily to make the module behave the same way the theme does.

So my guess is eventually the theme will not be usefull unless there is some roadblock along the way.

For the time being the work you've done is great on the theme and you should just simply create a version 1.0.4 and update the wiki pages to reflect the new version.

that's only my opinion thought

Map Theme 1.0.4 (not to be confused with the Map Module!)

Here it is . . . 1.0.4

I have created the zipfile to include the directory structure 'themes/map'.
The zipfile should be placed in your top level gallery directory (where
you would see the 'themes' directory) and unzipped from there. I did this
intentionally to try and avoid a possible mishap of unzipping it in the
modules directory and, well, you know.

If you already have installed aprevious version of the map theme (not to
be confused with the Map Module!) then I would rename that directory and
move it up one directory out of the themes directory. Then unzip 1.0.4.

Make sure you go through the map theme admin/setup screen in site admin/themes
and see what is there (more options!). For instance, you can place the pic
bar on top of the map, below, right or left.

There are even tooltips that will show up when you hover over a pic -or-
a marker. The tooltips will display the summary, if turned on and available,
or revert to the pic title otherwise.

The infowindows are, I think, a thing of beauty.

No doubt, it works for me; but I dread let you all lose on it.
Please try it out and let me know what you think.

P.S. The files are a mix of unix and windows. If on windows use wordpad
and not notepad (notepad will run the lines together).

Here are the new 'g' infowindow templates. They contain the links that
were mentioned previously (as well as other good (I hope) things).

I ask that the following changes be made to MapHeader.tpl (these are
not necessary for the 'g' templates to work; but, they remove some
unnecessary restrictions (truncation) on the summary and description
fields).

line 416:

416             {if $map.showItemSummaries && !empty($point.summary)} "{$point.summary|markup|entitytruncate:256|replace:"href":" target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

change to:

           {if $map.showItemSummaries && !empty($point.summary)} "{$point.summary|markup|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

line 422:

422             {if $map.showItemDescriptions && !empty($point.description)} "{$point.description|markup|entitytruncate:256|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

change to:

           {if $map.showItemDescriptions && !empty($point.description)} "{$point.description|markup|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

line 434:

434             {if $map.showItemSummaries && !empty($point.summary)} "{$point.summary|markup|entitytruncate:256|replace:"href":" target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

change to:

           {if $map.showItemSummaries && !empty($point.summary)} "{$point.summary|markup|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

line 440:

440             {if $map.showItemDescriptions && !empty($point.description)} "{$point.description|markup|entitytruncate:256|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

change to:

           {if $map.showItemDescriptions && !empty($point.description)} "{$point.description|markup|replace:"href":"target='gpop' onClick=\"window.open(href, 'gpop','left=20,top=20,scrollbars=yes').focus();return false;\" href"|escape:"javascript"}"{else}""{/if}

Please let me know what you all think.

Please let me know when I can gain access, again.
I'll have a look; but, it looks like you may have
a/some typo(s) regarding the link (Of course, it
would not be the first time I have been incorrect).
I think it is also causing the horizontal scrollbar
to appear. I tried to taylor the settings to prevent
that from happening.

By the way, you -can- now use apostrophes (I think).

Glad you like it.

I hope you don't mind but instead of overwriting the old ones I simply renamed them g2tabbed, etc ...

I think it's nice to give the option whether to use the new ones or not

Funny, that is what I did at first; but, before I posted the
zipfile I realized that more changes to MapHeader.tpl would
be required. Remember, there are several tests (if statements)
that check for 'gtabbed, gtable, gdefault, gcentered'
MapWindowType and new 'g2' names would need to be included in
these tests.
I leave the decisions to You.